You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@texera.apache.org by "Yicong-Huang (via GitHub)" <gi...@apache.org> on 2026/06/28 09:23:51 UTC
[PR] chore(ci): move LICENSE-binary version-drift tests into the infra job [texera]
Yicong-Huang opened a new pull request, #5965:
URL: https://github.com/apache/texera/pull/5965
### What changes were proposed in this PR?
Stacked on top of #5961 (the `infra` CI job lives there).
Move `bin/licensing/test_*.py` — the unit tests for the per-module `LICENSE-binary` version-drift checker — from `pyamber` into `infra`.
```
Before: After:
───────────────────────────────────── ─────────────────────────────────────
pyamber (ubuntu × 3.10/3.11/3.12/3.13) infra (ubuntu, macos)
├─ Unit-test licensing scripts × 4 ├─ Unit-test licensing scripts × 1
└─ pip-licenses / amber tests ├─ Run shell smoke tests
└─ Run Python unit tests (pytest
infra (ubuntu, macos) covers bin/licensing/ +
├─ Run shell smoke tests bin/local-dev/tests/)
└─ Run Python unit tests
```
Same stdlib `unittest.TestCase` tests — `pytest` discovers them without rewriting. Single combined `pytest bin/local-dev/tests/ bin/licensing/` invocation so test failures are easy to attribute.
The `infra` job grows from "dev-loop tooling only" to "any project-tooling under `bin/*` that isn't tied to a specific service". Comment + labeler glob updated to match; `bin/licensing/**` now picks up the job automatically.
### Any related issues, documentation, discussions?
Closes #5964.
### How was this PR tested?
Locally on this checkout:
```
$ python -m pytest bin/local-dev/tests/ bin/licensing/ -v --tb=short
============================== 91 passed in 0.27s ==============================
$ bash bin/local-dev/tests/test_local_dev_sh.sh
9 passed, 0 failed
```
53 licensing tests (`test_check_binary_deps.py` + `test_generate_notice_binary.py`) + 38 local-dev TUI / dirty-detection tests, all on Python 3.12.
### Was this PR authored or co-authored using generative AI tooling?
Generated-by: Claude Code (Anthropic, Claude Opus 4.7).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(ci): move LICENSE-binary version-drift tests into the infra job [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5965:
URL: https://github.com/apache/texera/pull/5965#issuecomment-4825511128
<!-- texera-reviewer-suggestion -->
### Automated Reviewer Suggestions
Based on the `git blame` history of the changed files, we recommend the following reviewers:
- No candidates found from `git blame` history.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(ci): move LICENSE-binary version-drift tests into the infra job [texera]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #5965:
URL: https://github.com/apache/texera/pull/5965#issuecomment-4825528893
<!-- texera-benchmarks-comment -->
## ⚠️ Benchmark changes need a look
🟢 0 better · 🔴 1 worse · ⚪ 14 noise (<±5%) · 0 without baseline
> Compared against main `de6c31a` benchmarked on **this same runner**, so the delta is largely free of cross-runner hardware noise. The "7d avg" column still reflects the gh-pages dashboard. Treat <±5% as noise unless repeated.
[Dashboard](https://apache.github.io/texera/dev/bench/) · [Run](https://github.com/apache/texera/actions/runs/28317849775)
| | config | throughput | MB/s | latency | max Δ latest / 7d |
|---|---|---:|---:|---:|---:|
| 🔴 | bs=10 sw=10 sl=64 | 408 | 0.249 | 23,431/33,994/33,994 us | 🔴 +8.3% / 🔴 +119.8% |
| ⚪ | bs=100 sw=10 sl=64 | 799 | 0.488 | 122,479/147,114/147,114 us | ⚪ within ±5% / 🔴 +33.7% |
| ⚪ | bs=1000 sw=10 sl=64 | 923 | 0.563 | 1,088,760/1,107,914/1,107,914 us | ⚪ within ±5% / 🔴 +7.2% |
<details><summary>Baseline details</summary>
Latest main `de6c31a` from same runner
| config | metric | PR | latest main | 7d avg | Δ latest | Δ 7d |
|---|---|---:|---:|---:|---:|---:|
| bs=10 sw=10 sl=64 | throughput | 408 tuples/sec | 415 tuples/sec | 756.6 tuples/sec | -1.7% | -46.1% |
| bs=10 sw=10 sl=64 | MB/s | 0.249 MB/s | 0.253 MB/s | 0.462 MB/s | -1.6% | -46.1% |
| bs=10 sw=10 sl=64 | p50 | 23,431 us | 21,642 us | 13,009 us | +8.3% | +80.1% |
| bs=10 sw=10 sl=64 | p95 | 33,994 us | 35,100 us | 15,463 us | -3.2% | +119.8% |
| bs=10 sw=10 sl=64 | p99 | 33,994 us | 35,100 us | 18,561 us | -3.2% | +83.1% |
| bs=100 sw=10 sl=64 | throughput | 799 tuples/sec | 829 tuples/sec | 963.83 tuples/sec | -3.6% | -17.1% |
| bs=100 sw=10 sl=64 | MB/s | 0.488 MB/s | 0.506 MB/s | 0.588 MB/s | -3.6% | -17.0% |
| bs=100 sw=10 sl=64 | p50 | 122,479 us | 118,850 us | 103,320 us | +3.1% | +18.5% |
| bs=100 sw=10 sl=64 | p95 | 147,114 us | 145,658 us | 110,058 us | +1.0% | +33.7% |
| bs=100 sw=10 sl=64 | p99 | 147,114 us | 145,658 us | 118,543 us | +1.0% | +24.1% |
| bs=1000 sw=10 sl=64 | throughput | 923 tuples/sec | 928 tuples/sec | 989.07 tuples/sec | -0.5% | -6.7% |
| bs=1000 sw=10 sl=64 | MB/s | 0.563 MB/s | 0.567 MB/s | 0.604 MB/s | -0.7% | -6.7% |
| bs=1000 sw=10 sl=64 | p50 | 1,088,760 us | 1,083,236 us | 1,015,599 us | +0.5% | +7.2% |
| bs=1000 sw=10 sl=64 | p95 | 1,107,914 us | 1,160,830 us | 1,055,944 us | -4.6% | +4.9% |
| bs=1000 sw=10 sl=64 | p99 | 1,107,914 us | 1,160,830 us | 1,086,834 us | -4.6% | +1.9% |
</details>
<details><summary>Raw CSV</summary>
```csv
config_idx,batch_size,schema_width,string_len,num_batches,total_ms,total_tuples,total_bytes,tuples_per_sec,mb_per_sec,lat_p50_us,lat_p95_us,lat_p99_us
0,10,10,64,20,490.52,200,128000,408,0.249,23431.22,33993.81,33993.81
1,100,10,64,20,2502.69,2000,1280000,799,0.488,122479.19,147113.70,147113.70
2,1000,10,64,20,21674.22,20000,12800000,923,0.563,1088759.57,1107914.24,1107914.24
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(ci): move LICENSE-binary version-drift tests into the infra job [texera]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #5965:
URL: https://github.com/apache/texera/pull/5965#issuecomment-4825512293
## [Codecov](https://app.codecov.io/gh/apache/texera/pull/5965?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 55.22%. Comparing base ([`de6c31a`](https://app.codecov.io/gh/apache/texera/commit/de6c31ac48ddf829b00c78b1d4f45b826236ff9d?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`73344eb`](https://app.codecov.io/gh/apache/texera/commit/73344eba65b9ff6169f2e9a268b08b9e0d0fc163?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## main #5965 +/- ##
=========================================
Coverage 55.22% 55.22%
Complexity 2986 2986
=========================================
Files 1117 1117
Lines 43258 43258
Branches 4668 4668
=========================================
Hits 23891 23891
Misses 17956 17956
Partials 1411 1411
```
| [Flag](https://app.codecov.io/gh/apache/texera/pull/5965/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | | *Carryforward flag |
|---|---|---|---|
| [access-control-service](https://app.codecov.io/gh/apache/texera/pull/5965/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `70.00% <ø> (ø)` | | Carriedforward from [de6c31a](https://app.codecov.io/gh/apache/texera/commit/de6c31ac48ddf829b00c78b1d4f45b826236ff9d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [agent-service](https://app.codecov.io/gh/apache/texera/pull/5965/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `34.36% <ø> (ø)` | | |
| [amber](https://app.codecov.io/gh/apache/texera/pull/5965/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `57.75% <ø> (ø)` | | Carriedforward from [de6c31a](https://app.codecov.io/gh/apache/texera/commit/de6c31ac48ddf829b00c78b1d4f45b826236ff9d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [computing-unit-managing-service](https://app.codecov.io/gh/apache/texera/pull/5965/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | | Carriedforward from [de6c31a](https://app.codecov.io/gh/apache/texera/commit/de6c31ac48ddf829b00c78b1d4f45b826236ff9d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [config-service](https://app.codecov.io/gh/apache/texera/pull/5965/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `51.56% <ø> (ø)` | | Carriedforward from [de6c31a](https://app.codecov.io/gh/apache/texera/commit/de6c31ac48ddf829b00c78b1d4f45b826236ff9d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [file-service](https://app.codecov.io/gh/apache/texera/pull/5965/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `59.02% <ø> (ø)` | | Carriedforward from [de6c31a](https://app.codecov.io/gh/apache/texera/commit/de6c31ac48ddf829b00c78b1d4f45b826236ff9d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [frontend](https://app.codecov.io/gh/apache/texera/pull/5965/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `48.81% <ø> (ø)` | | Carriedforward from [de6c31a](https://app.codecov.io/gh/apache/texera/commit/de6c31ac48ddf829b00c78b1d4f45b826236ff9d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [notebook-migration-service](https://app.codecov.io/gh/apache/texera/pull/5965/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `78.57% <ø> (ø)` | | Carriedforward from [de6c31a](https://app.codecov.io/gh/apache/texera/commit/de6c31ac48ddf829b00c78b1d4f45b826236ff9d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [pyamber](https://app.codecov.io/gh/apache/texera/pull/5965/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.20% <ø> (ø)` | | Carriedforward from [de6c31a](https://app.codecov.io/gh/apache/texera/commit/de6c31ac48ddf829b00c78b1d4f45b826236ff9d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [python](https://app.codecov.io/gh/apache/texera/pull/5965/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `90.76% <ø> (ø)` | | Carriedforward from [de6c31a](https://app.codecov.io/gh/apache/texera/commit/de6c31ac48ddf829b00c78b1d4f45b826236ff9d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
| [workflow-compiling-service](https://app.codecov.io/gh/apache/texera/pull/5965/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `55.14% <ø> (ø)` | | Carriedforward from [de6c31a](https://app.codecov.io/gh/apache/texera/commit/de6c31ac48ddf829b00c78b1d4f45b826236ff9d?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) |
*This pull request uses carry forward flags. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/texera/pull/5965?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] chore(ci): move LICENSE-binary version-drift tests into the infra job [texera]
Posted by "Yicong-Huang (via GitHub)" <gi...@apache.org>.
Yicong-Huang merged PR #5965:
URL: https://github.com/apache/texera/pull/5965
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@texera.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org