You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/29 04:04:44 UTC

[GitHub] [pulsar] codelipenghui commented on a change in pull request #12233: [Python] Allow required=False default=None setting on fields

codelipenghui commented on a change in pull request #12233:
URL: https://github.com/apache/pulsar/pull/12233#discussion_r718135581



##########
File path: pulsar-client-cpp/python/pulsar/schema/definition.py
##########
@@ -60,8 +64,10 @@ class Record(with_metaclass(RecordMeta, object)):
     # This field is used to set namespace for Avro Record schema.
     _avro_namespace = None
 
-    def __init__(self, default=None, required_default=False, required=False, *args, **kwargs):

Review comment:
       Shall we need to keep the old configuration `required_default=False` for compatibility consideration?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org