You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2021/12/20 11:17:24 UTC
[GitHub] [hudi] harsh1231 opened a new pull request #4404: [HUDI-2558] Fixing Clustering w/ sort columns with null values fails
harsh1231 opened a new pull request #4404:
URL: https://github.com/apache/hudi/pull/4404
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
*(For example: This pull request adds quick-start document.)*
## Brief change log
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4404: [HUDI-2558] Fixing Clustering w/ sort columns with null values fails
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4404:
URL: https://github.com/apache/hudi/pull/4404#issuecomment-999392623
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4593",
"triggerID" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"triggerType" : "PUSH"
}, {
"hash" : "cb1cc9010c0c9d572bc5db55ee67b51df735ee59",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4662",
"triggerID" : "cb1cc9010c0c9d572bc5db55ee67b51df735ee59",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fbca0322a0dc67f938d3489536fd660c70a4b506 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4593)
* cb1cc9010c0c9d572bc5db55ee67b51df735ee59 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4662)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4404: [HUDI-2558] Fixing Clustering w/ sort columns with null values fails
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4404:
URL: https://github.com/apache/hudi/pull/4404#issuecomment-997874729
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4593",
"triggerID" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fbca0322a0dc67f938d3489536fd660c70a4b506 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4593)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] harsh1231 commented on a change in pull request #4404: [HUDI-2558] Fixing Clustering w/ sort columns with null values fails
Posted by GitBox <gi...@apache.org>.
harsh1231 commented on a change in pull request #4404:
URL: https://github.com/apache/hudi/pull/4404#discussion_r776611838
##########
File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/execution/bulkinsert/RDDCustomColumnsSortPartitioner.java
##########
@@ -55,8 +55,17 @@ public RDDCustomColumnsSortPartitioner(String[] columnNames, Schema schema) {
final String[] sortColumns = this.sortColumnNames;
final SerializableSchema schema = this.serializableSchema;
return records.sortBy(
- record -> HoodieAvroUtils.getRecordColumnValues(record, sortColumns, schema),
+ record -> {
+ Object recordValue = HoodieAvroUtils.getRecordColumnValues(record, sortColumns, schema);
+ // null values are replaced with empty string for null_first order
+ if (recordValue == null) {
+ return "";
Review comment:
`add another parameter to replace nulls by user-defined value` not sure we need that as of now
@codope
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4404: [HUDI-2558] Fixing Clustering w/ sort columns with null values fails
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4404:
URL: https://github.com/apache/hudi/pull/4404#issuecomment-1002935877
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4593",
"triggerID" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"triggerType" : "PUSH"
}, {
"hash" : "cb1cc9010c0c9d572bc5db55ee67b51df735ee59",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4662",
"triggerID" : "cb1cc9010c0c9d572bc5db55ee67b51df735ee59",
"triggerType" : "PUSH"
}, {
"hash" : "71505f07ad3215a36e8a617b98c2e372abd8d2a5",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4666",
"triggerID" : "71505f07ad3215a36e8a617b98c2e372abd8d2a5",
"triggerType" : "PUSH"
}, {
"hash" : "4943271f6883384c7355a47d0d407f227ac02688",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4812",
"triggerID" : "4943271f6883384c7355a47d0d407f227ac02688",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 4943271f6883384c7355a47d0d407f227ac02688 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4812)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] harsh1231 commented on a change in pull request #4404: [HUDI-2558] Fixing Clustering w/ sort columns with null values fails
Posted by GitBox <gi...@apache.org>.
harsh1231 commented on a change in pull request #4404:
URL: https://github.com/apache/hudi/pull/4404#discussion_r773603089
##########
File path: hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/sql/hudi/HoodieComparator.scala
##########
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.hudi
+
+class HoodieComparator[S] extends Ordering[S] {
+ import com.google.common.collect.Ordering
Review comment:
`JavaRDD.scala` implements sortBy , which internally uses `sortBy` of `RDD.scala`
JavaRDD ->uses implicit natural ordering
```
def sortBy[S](f: JFunction[T, S], ascending: Boolean, numPartitions: Int): JavaRDD[T] = {
def fn: (T) => S = (x: T) => f.call(x)
import com.google.common.collect.Ordering // shadows scala.math.Ordering
implicit val ordering = Ordering.natural().asInstanceOf[Ordering[S]]
implicit val ctag: ClassTag[S] = fakeClassTag
wrapRDD(rdd.sortBy(fn, ascending, numPartitions))
} ```
to keep behaviour consistent I have used the same natural ordering for non-nullable objects .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4404: [HUDI-2558] Fixing Clustering w/ sort columns with null values fails
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4404:
URL: https://github.com/apache/hudi/pull/4404#issuecomment-999390839
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4593",
"triggerID" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"triggerType" : "PUSH"
}, {
"hash" : "cb1cc9010c0c9d572bc5db55ee67b51df735ee59",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cb1cc9010c0c9d572bc5db55ee67b51df735ee59",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fbca0322a0dc67f938d3489536fd660c70a4b506 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4593)
* cb1cc9010c0c9d572bc5db55ee67b51df735ee59 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope merged pull request #4404: [HUDI-2558] Fixing Clustering w/ sort columns with null values fails
Posted by GitBox <gi...@apache.org>.
codope merged pull request #4404:
URL: https://github.com/apache/hudi/pull/4404
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4404: [HUDI-2558] Fixing Clustering w/ sort columns with null values fails
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4404:
URL: https://github.com/apache/hudi/pull/4404#issuecomment-999390839
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4593",
"triggerID" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"triggerType" : "PUSH"
}, {
"hash" : "cb1cc9010c0c9d572bc5db55ee67b51df735ee59",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "cb1cc9010c0c9d572bc5db55ee67b51df735ee59",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fbca0322a0dc67f938d3489536fd660c70a4b506 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4593)
* cb1cc9010c0c9d572bc5db55ee67b51df735ee59 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4404: [HUDI-2558] Fixing Clustering w/ sort columns with null values fails
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4404:
URL: https://github.com/apache/hudi/pull/4404#issuecomment-999474624
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4593",
"triggerID" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"triggerType" : "PUSH"
}, {
"hash" : "cb1cc9010c0c9d572bc5db55ee67b51df735ee59",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4662",
"triggerID" : "cb1cc9010c0c9d572bc5db55ee67b51df735ee59",
"triggerType" : "PUSH"
}, {
"hash" : "71505f07ad3215a36e8a617b98c2e372abd8d2a5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4666",
"triggerID" : "71505f07ad3215a36e8a617b98c2e372abd8d2a5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 71505f07ad3215a36e8a617b98c2e372abd8d2a5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4666)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] harsh1231 commented on a change in pull request #4404: [HUDI-2558] Fixing Clustering w/ sort columns with null values fails
Posted by GitBox <gi...@apache.org>.
harsh1231 commented on a change in pull request #4404:
URL: https://github.com/apache/hudi/pull/4404#discussion_r773598781
##########
File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/execution/bulkinsert/RDDCustomColumnsSortPartitioner.java
##########
@@ -54,9 +55,9 @@ public RDDCustomColumnsSortPartitioner(String[] columnNames, Schema schema) {
int outputSparkPartitions) {
final String[] sortColumns = this.sortColumnNames;
final SerializableSchema schema = this.serializableSchema;
- return records.sortBy(
+ return CustomJavaRDD.fromRDD(records,records.classTag()).sortBy(
Review comment:
Yes we just want to sort it deterministic way , `null_first` or null_last`
`public static Object getRecordColumnValues(HoodieRecord<? extends HoodieRecordPayload> record,
String[] columns,
SerializableSchema schema) `
return type is `object`
if we can make it string then we don't need to write own sortBy implementation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4404: [HUDI-2558] Fixing Clustering w/ sort columns with null values fails
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4404:
URL: https://github.com/apache/hudi/pull/4404#issuecomment-997874729
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4593",
"triggerID" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fbca0322a0dc67f938d3489536fd660c70a4b506 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4593)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4404: [HUDI-2558] Fixing Clustering w/ sort columns with null values fails
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4404:
URL: https://github.com/apache/hudi/pull/4404#issuecomment-999434326
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4593",
"triggerID" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"triggerType" : "PUSH"
}, {
"hash" : "cb1cc9010c0c9d572bc5db55ee67b51df735ee59",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4662",
"triggerID" : "cb1cc9010c0c9d572bc5db55ee67b51df735ee59",
"triggerType" : "PUSH"
}, {
"hash" : "71505f07ad3215a36e8a617b98c2e372abd8d2a5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4666",
"triggerID" : "71505f07ad3215a36e8a617b98c2e372abd8d2a5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cb1cc9010c0c9d572bc5db55ee67b51df735ee59 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4662)
* 71505f07ad3215a36e8a617b98c2e372abd8d2a5 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4666)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4404: [HUDI-2558] Fixing Clustering w/ sort columns with null values fails
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4404:
URL: https://github.com/apache/hudi/pull/4404#issuecomment-1002915633
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4593",
"triggerID" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"triggerType" : "PUSH"
}, {
"hash" : "cb1cc9010c0c9d572bc5db55ee67b51df735ee59",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4662",
"triggerID" : "cb1cc9010c0c9d572bc5db55ee67b51df735ee59",
"triggerType" : "PUSH"
}, {
"hash" : "71505f07ad3215a36e8a617b98c2e372abd8d2a5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4666",
"triggerID" : "71505f07ad3215a36e8a617b98c2e372abd8d2a5",
"triggerType" : "PUSH"
}, {
"hash" : "4943271f6883384c7355a47d0d407f227ac02688",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4943271f6883384c7355a47d0d407f227ac02688",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 71505f07ad3215a36e8a617b98c2e372abd8d2a5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4666)
* 4943271f6883384c7355a47d0d407f227ac02688 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] harsh1231 commented on a change in pull request #4404: [HUDI-2558] Fixing Clustering w/ sort columns with null values fails
Posted by GitBox <gi...@apache.org>.
harsh1231 commented on a change in pull request #4404:
URL: https://github.com/apache/hudi/pull/4404#discussion_r773598781
##########
File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/execution/bulkinsert/RDDCustomColumnsSortPartitioner.java
##########
@@ -54,9 +55,9 @@ public RDDCustomColumnsSortPartitioner(String[] columnNames, Schema schema) {
int outputSparkPartitions) {
final String[] sortColumns = this.sortColumnNames;
final SerializableSchema schema = this.serializableSchema;
- return records.sortBy(
+ return CustomJavaRDD.fromRDD(records,records.classTag()).sortBy(
Review comment:
Yes we just want to sort it deterministic way , `null_first` or `null_last`
`public static Object getRecordColumnValues(HoodieRecord<? extends HoodieRecordPayload> record,
String[] columns,
SerializableSchema schema)`
return type is `object`
if we can make it string then we don't need to write own sortBy implementation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4404: [HUDI-2558] Fixing Clustering w/ sort columns with null values fails
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4404:
URL: https://github.com/apache/hudi/pull/4404#issuecomment-999400297
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4593",
"triggerID" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"triggerType" : "PUSH"
}, {
"hash" : "cb1cc9010c0c9d572bc5db55ee67b51df735ee59",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4662",
"triggerID" : "cb1cc9010c0c9d572bc5db55ee67b51df735ee59",
"triggerType" : "PUSH"
}, {
"hash" : "71505f07ad3215a36e8a617b98c2e372abd8d2a5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "71505f07ad3215a36e8a617b98c2e372abd8d2a5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cb1cc9010c0c9d572bc5db55ee67b51df735ee59 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4662)
* 71505f07ad3215a36e8a617b98c2e372abd8d2a5 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on a change in pull request #4404: [HUDI-2558] Fixing Clustering w/ sort columns with null values fails
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #4404:
URL: https://github.com/apache/hudi/pull/4404#discussion_r773607678
##########
File path: hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/sql/hudi/HoodieComparator.scala
##########
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.hudi
+
+class HoodieComparator[S] extends Ordering[S] {
+ import com.google.common.collect.Ordering
Review comment:
Great job digging deeper. :). Love to avoid the custom RDD approach if possible as mentioned above
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4404: [HUDI-2558] Fixing Clustering w/ sort columns with null values fails
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4404:
URL: https://github.com/apache/hudi/pull/4404#issuecomment-999392623
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4593",
"triggerID" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"triggerType" : "PUSH"
}, {
"hash" : "cb1cc9010c0c9d572bc5db55ee67b51df735ee59",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4662",
"triggerID" : "cb1cc9010c0c9d572bc5db55ee67b51df735ee59",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fbca0322a0dc67f938d3489536fd660c70a4b506 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4593)
* cb1cc9010c0c9d572bc5db55ee67b51df735ee59 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4662)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on a change in pull request #4404: [HUDI-2558] Fixing Clustering w/ sort columns with null values fails
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #4404:
URL: https://github.com/apache/hudi/pull/4404#discussion_r773568585
##########
File path: hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/sql/hudi/CustomJavaRDD.scala
##########
@@ -0,0 +1,39 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.hudi
+
+import org.apache.spark.api.java.JavaSparkContext.fakeClassTag
+import org.apache.spark.api.java.{JavaRDD, function}
+import org.apache.spark.rdd.RDD
+import scala.reflect.ClassTag
+
+class CustomJavaRDD[T](override val rdd: RDD[T])(implicit override val classTag: ClassTag[T]) extends JavaRDD (rdd)(classTag) {
Review comment:
javadocs/scaladocs?
##########
File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/execution/bulkinsert/RDDCustomColumnsSortPartitioner.java
##########
@@ -54,9 +55,9 @@ public RDDCustomColumnsSortPartitioner(String[] columnNames, Schema schema) {
int outputSparkPartitions) {
final String[] sortColumns = this.sortColumnNames;
final SerializableSchema schema = this.serializableSchema;
- return records.sortBy(
+ return CustomJavaRDD.fromRDD(records,records.classTag()).sortBy(
Review comment:
could you please help me understand this change? Looks like `HoodieAvroUtils.getRecordColumnValues(record, sortColumns, schema)` returns a string. Could we not sort by `Option<String>` or even a `"null"` string value if the column value is null? We just want it to sort consistently and not break, that's all correct? Would n't that suffice without resorting to custom java rdds ?
##########
File path: hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/sql/hudi/HoodieComparator.scala
##########
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.hudi
+
+class HoodieComparator[S] extends Ordering[S] {
+ import com.google.common.collect.Ordering
Review comment:
we cannot use guava inside Hudi. Its an illegal import in java code. Love to again understand why this is needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4404: [HUDI-2558] Fixing Clustering w/ sort columns with null values fails
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4404:
URL: https://github.com/apache/hudi/pull/4404#issuecomment-1002916682
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4593",
"triggerID" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"triggerType" : "PUSH"
}, {
"hash" : "cb1cc9010c0c9d572bc5db55ee67b51df735ee59",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4662",
"triggerID" : "cb1cc9010c0c9d572bc5db55ee67b51df735ee59",
"triggerType" : "PUSH"
}, {
"hash" : "71505f07ad3215a36e8a617b98c2e372abd8d2a5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4666",
"triggerID" : "71505f07ad3215a36e8a617b98c2e372abd8d2a5",
"triggerType" : "PUSH"
}, {
"hash" : "4943271f6883384c7355a47d0d407f227ac02688",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4812",
"triggerID" : "4943271f6883384c7355a47d0d407f227ac02688",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 71505f07ad3215a36e8a617b98c2e372abd8d2a5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4666)
* 4943271f6883384c7355a47d0d407f227ac02688 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4812)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4404: [HUDI-2558] Fixing Clustering w/ sort columns with null values fails
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4404:
URL: https://github.com/apache/hudi/pull/4404#issuecomment-997833642
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fbca0322a0dc67f938d3489536fd660c70a4b506 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] vinothchandar commented on a change in pull request #4404: [HUDI-2558] Fixing Clustering w/ sort columns with null values fails
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on a change in pull request #4404:
URL: https://github.com/apache/hudi/pull/4404#discussion_r773607065
##########
File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/execution/bulkinsert/RDDCustomColumnsSortPartitioner.java
##########
@@ -54,9 +55,9 @@ public RDDCustomColumnsSortPartitioner(String[] columnNames, Schema schema) {
int outputSparkPartitions) {
final String[] sortColumns = this.sortColumnNames;
final SerializableSchema schema = this.serializableSchema;
- return records.sortBy(
+ return CustomJavaRDD.fromRDD(records,records.classTag()).sortBy(
Review comment:
Definitely seems to be returning a string. I think we should sort lexicographically the byte representation if you ask me. So if we can could map `null` deterministically to some string/byte and avoid this customization, I'd prefer that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4404: [HUDI-2558] Fixing Clustering w/ sort columns with null values fails
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4404:
URL: https://github.com/apache/hudi/pull/4404#issuecomment-999400297
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4593",
"triggerID" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"triggerType" : "PUSH"
}, {
"hash" : "cb1cc9010c0c9d572bc5db55ee67b51df735ee59",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4662",
"triggerID" : "cb1cc9010c0c9d572bc5db55ee67b51df735ee59",
"triggerType" : "PUSH"
}, {
"hash" : "71505f07ad3215a36e8a617b98c2e372abd8d2a5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "71505f07ad3215a36e8a617b98c2e372abd8d2a5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cb1cc9010c0c9d572bc5db55ee67b51df735ee59 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4662)
* 71505f07ad3215a36e8a617b98c2e372abd8d2a5 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] harsh1231 commented on a change in pull request #4404: [HUDI-2558] Fixing Clustering w/ sort columns with null values fails
Posted by GitBox <gi...@apache.org>.
harsh1231 commented on a change in pull request #4404:
URL: https://github.com/apache/hudi/pull/4404#discussion_r776596753
##########
File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/execution/bulkinsert/RDDCustomColumnsSortPartitioner.java
##########
@@ -55,8 +55,17 @@ public RDDCustomColumnsSortPartitioner(String[] columnNames, Schema schema) {
final String[] sortColumns = this.sortColumnNames;
final SerializableSchema schema = this.serializableSchema;
return records.sortBy(
- record -> HoodieAvroUtils.getRecordColumnValues(record, sortColumns, schema),
+ record -> {
+ Object recordValue = HoodieAvroUtils.getRecordColumnValues(record, sortColumns, schema);
+ // null values are replaced with empty string for null_first order
+ if (recordValue == null) {
+ return "";
Review comment:
`if (columns.length == 1) {
return HoodieAvroUtils.getNestedFieldVal(genericRecord, columns[0], true);
}` this nested trace can return data type other than string from `convertValueForAvroLogicalTypes`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] harsh1231 commented on a change in pull request #4404: [HUDI-2558] Fixing Clustering w/ sort columns with null values fails
Posted by GitBox <gi...@apache.org>.
harsh1231 commented on a change in pull request #4404:
URL: https://github.com/apache/hudi/pull/4404#discussion_r776596935
##########
File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/execution/bulkinsert/RDDCustomColumnsSortPartitioner.java
##########
@@ -55,8 +55,17 @@ public RDDCustomColumnsSortPartitioner(String[] columnNames, Schema schema) {
final String[] sortColumns = this.sortColumnNames;
final SerializableSchema schema = this.serializableSchema;
return records.sortBy(
- record -> HoodieAvroUtils.getRecordColumnValues(record, sortColumns, schema),
+ record -> {
+ Object recordValue = HoodieAvroUtils.getRecordColumnValues(record, sortColumns, schema);
+ // null values are replaced with empty string for null_first order
+ if (recordValue == null) {
+ return "";
Review comment:
Will update using `StringUtils.EMPTY_STRING`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4404: [HUDI-2558] Fixing Clustering w/ sort columns with null values fails
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4404:
URL: https://github.com/apache/hudi/pull/4404#issuecomment-1002916682
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4593",
"triggerID" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"triggerType" : "PUSH"
}, {
"hash" : "cb1cc9010c0c9d572bc5db55ee67b51df735ee59",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4662",
"triggerID" : "cb1cc9010c0c9d572bc5db55ee67b51df735ee59",
"triggerType" : "PUSH"
}, {
"hash" : "71505f07ad3215a36e8a617b98c2e372abd8d2a5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4666",
"triggerID" : "71505f07ad3215a36e8a617b98c2e372abd8d2a5",
"triggerType" : "PUSH"
}, {
"hash" : "4943271f6883384c7355a47d0d407f227ac02688",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4812",
"triggerID" : "4943271f6883384c7355a47d0d407f227ac02688",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 71505f07ad3215a36e8a617b98c2e372abd8d2a5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4666)
* 4943271f6883384c7355a47d0d407f227ac02688 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4812)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4404: [HUDI-2558] Fixing Clustering w/ sort columns with null values fails
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4404:
URL: https://github.com/apache/hudi/pull/4404#issuecomment-997835907
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4593",
"triggerID" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fbca0322a0dc67f938d3489536fd660c70a4b506 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4593)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4404: [HUDI-2558] Fixing Clustering w/ sort columns with null values fails
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4404:
URL: https://github.com/apache/hudi/pull/4404#issuecomment-997835907
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4593",
"triggerID" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fbca0322a0dc67f938d3489536fd660c70a4b506 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4593)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4404: [HUDI-2558] Fixing Clustering w/ sort columns with null values fails
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4404:
URL: https://github.com/apache/hudi/pull/4404#issuecomment-997833642
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fbca0322a0dc67f938d3489536fd660c70a4b506 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] harsh1231 commented on a change in pull request #4404: [HUDI-2558] Fixing Clustering w/ sort columns with null values fails
Posted by GitBox <gi...@apache.org>.
harsh1231 commented on a change in pull request #4404:
URL: https://github.com/apache/hudi/pull/4404#discussion_r773598781
##########
File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/execution/bulkinsert/RDDCustomColumnsSortPartitioner.java
##########
@@ -54,9 +55,9 @@ public RDDCustomColumnsSortPartitioner(String[] columnNames, Schema schema) {
int outputSparkPartitions) {
final String[] sortColumns = this.sortColumnNames;
final SerializableSchema schema = this.serializableSchema;
- return records.sortBy(
+ return CustomJavaRDD.fromRDD(records,records.classTag()).sortBy(
Review comment:
`public static Object getRecordColumnValues(HoodieRecord<? extends HoodieRecordPayload> record,
String[] columns,
SerializableSchema schema) `
return type is `object`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] harsh1231 commented on a change in pull request #4404: [HUDI-2558] Fixing Clustering w/ sort columns with null values fails
Posted by GitBox <gi...@apache.org>.
harsh1231 commented on a change in pull request #4404:
URL: https://github.com/apache/hudi/pull/4404#discussion_r773598781
##########
File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/execution/bulkinsert/RDDCustomColumnsSortPartitioner.java
##########
@@ -54,9 +55,9 @@ public RDDCustomColumnsSortPartitioner(String[] columnNames, Schema schema) {
int outputSparkPartitions) {
final String[] sortColumns = this.sortColumnNames;
final SerializableSchema schema = this.serializableSchema;
- return records.sortBy(
+ return CustomJavaRDD.fromRDD(records,records.classTag()).sortBy(
Review comment:
Yes we just want to sort it deterministic way , `null_first` or null_last`
`public static Object getRecordColumnValues(HoodieRecord<? extends HoodieRecordPayload> record,
String[] columns,
SerializableSchema schema)`
return type is `object`
if we can make it string then we don't need to write own sortBy implementation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] harsh1231 commented on a change in pull request #4404: [HUDI-2558] Fixing Clustering w/ sort columns with null values fails
Posted by GitBox <gi...@apache.org>.
harsh1231 commented on a change in pull request #4404:
URL: https://github.com/apache/hudi/pull/4404#discussion_r773603089
##########
File path: hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/sql/hudi/HoodieComparator.scala
##########
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.hudi
+
+class HoodieComparator[S] extends Ordering[S] {
+ import com.google.common.collect.Ordering
Review comment:
`JavaRDD.scala` implements sortBy , which internally uses `sortBy` of `RDD.scala`
JavaRDD ->uses implicit natural ordering
```def sortBy[S](f: JFunction[T, S], ascending: Boolean, numPartitions: Int): JavaRDD[T] = {
def fn: (T) => S = (x: T) => f.call(x)
import com.google.common.collect.Ordering // shadows scala.math.Ordering
implicit val ordering = Ordering.natural().asInstanceOf[Ordering[S]]
implicit val ctag: ClassTag[S] = fakeClassTag
wrapRDD(rdd.sortBy(fn, ascending, numPartitions))
}```
to keep behaviour consistent I have used the same natural ordering for non-nullable objects .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] codope commented on a change in pull request #4404: [HUDI-2558] Fixing Clustering w/ sort columns with null values fails
Posted by GitBox <gi...@apache.org>.
codope commented on a change in pull request #4404:
URL: https://github.com/apache/hudi/pull/4404#discussion_r775876469
##########
File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/execution/bulkinsert/RDDCustomColumnsSortPartitioner.java
##########
@@ -55,8 +55,17 @@ public RDDCustomColumnsSortPartitioner(String[] columnNames, Schema schema) {
final String[] sortColumns = this.sortColumnNames;
final SerializableSchema schema = this.serializableSchema;
return records.sortBy(
- record -> HoodieAvroUtils.getRecordColumnValues(record, sortColumns, schema),
+ record -> {
+ Object recordValue = HoodieAvroUtils.getRecordColumnValues(record, sortColumns, schema);
+ // null values are replaced with empty string for null_first order
+ if (recordValue == null) {
+ return "";
Review comment:
Consider using `StringUtils.EMPTY_STRING`.
##########
File path: hudi-client/hudi-spark-client/src/main/java/org/apache/hudi/execution/bulkinsert/RDDCustomColumnsSortPartitioner.java
##########
@@ -55,8 +55,17 @@ public RDDCustomColumnsSortPartitioner(String[] columnNames, Schema schema) {
final String[] sortColumns = this.sortColumnNames;
final SerializableSchema schema = this.serializableSchema;
return records.sortBy(
- record -> HoodieAvroUtils.getRecordColumnValues(record, sortColumns, schema),
+ record -> {
+ Object recordValue = HoodieAvroUtils.getRecordColumnValues(record, sortColumns, schema);
+ // null values are replaced with empty string for null_first order
+ if (recordValue == null) {
+ return "";
+ } else {
+ return recordValue.toString();
Review comment:
Consider using `StringUtils#objToString`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] harsh1231 commented on a change in pull request #4404: [HUDI-2558] Fixing Clustering w/ sort columns with null values fails
Posted by GitBox <gi...@apache.org>.
harsh1231 commented on a change in pull request #4404:
URL: https://github.com/apache/hudi/pull/4404#discussion_r773711405
##########
File path: hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/sql/hudi/HoodieComparator.scala
##########
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.hudi
+
+class HoodieComparator[S] extends Ordering[S] {
+ import com.google.common.collect.Ordering
Review comment:
@vinothchandar have made it string sort (should do null_first)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4404: [HUDI-2558] Fixing Clustering w/ sort columns with null values fails
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4404:
URL: https://github.com/apache/hudi/pull/4404#issuecomment-999398343
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4593",
"triggerID" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"triggerType" : "PUSH"
}, {
"hash" : "cb1cc9010c0c9d572bc5db55ee67b51df735ee59",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4662",
"triggerID" : "cb1cc9010c0c9d572bc5db55ee67b51df735ee59",
"triggerType" : "PUSH"
}, {
"hash" : "71505f07ad3215a36e8a617b98c2e372abd8d2a5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "71505f07ad3215a36e8a617b98c2e372abd8d2a5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fbca0322a0dc67f938d3489536fd660c70a4b506 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4593)
* cb1cc9010c0c9d572bc5db55ee67b51df735ee59 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4662)
* 71505f07ad3215a36e8a617b98c2e372abd8d2a5 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] harsh1231 commented on a change in pull request #4404: [HUDI-2558] Fixing Clustering w/ sort columns with null values fails
Posted by GitBox <gi...@apache.org>.
harsh1231 commented on a change in pull request #4404:
URL: https://github.com/apache/hudi/pull/4404#discussion_r773603089
##########
File path: hudi-client/hudi-spark-client/src/main/scala/org/apache/spark/sql/hudi/HoodieComparator.scala
##########
@@ -0,0 +1,30 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.hudi
+
+class HoodieComparator[S] extends Ordering[S] {
+ import com.google.common.collect.Ordering
Review comment:
`JavaRDD.scala` implements sortBy , which internally uses `sortBy` of `RDD.scala`
JavaRDD ->uses implicit natural ordering
`def sortBy[S](f: JFunction[T, S], ascending: Boolean, numPartitions: Int): JavaRDD[T] = {
def fn: (T) => S = (x: T) => f.call(x)
import com.google.common.collect.Ordering // shadows scala.math.Ordering
implicit val ordering = Ordering.natural().asInstanceOf[Ordering[S]]
implicit val ctag: ClassTag[S] = fakeClassTag
wrapRDD(rdd.sortBy(fn, ascending, numPartitions))
}`
to keep behaviour consistent I have used the same natural ordering for non-nullable objects .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4404: [HUDI-2558] Fixing Clustering w/ sort columns with null values fails
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4404:
URL: https://github.com/apache/hudi/pull/4404#issuecomment-999474624
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4593",
"triggerID" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"triggerType" : "PUSH"
}, {
"hash" : "cb1cc9010c0c9d572bc5db55ee67b51df735ee59",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4662",
"triggerID" : "cb1cc9010c0c9d572bc5db55ee67b51df735ee59",
"triggerType" : "PUSH"
}, {
"hash" : "71505f07ad3215a36e8a617b98c2e372abd8d2a5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4666",
"triggerID" : "71505f07ad3215a36e8a617b98c2e372abd8d2a5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 71505f07ad3215a36e8a617b98c2e372abd8d2a5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4666)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4404: [HUDI-2558] Fixing Clustering w/ sort columns with null values fails
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4404:
URL: https://github.com/apache/hudi/pull/4404#issuecomment-999434326
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4593",
"triggerID" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"triggerType" : "PUSH"
}, {
"hash" : "cb1cc9010c0c9d572bc5db55ee67b51df735ee59",
"status" : "CANCELED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4662",
"triggerID" : "cb1cc9010c0c9d572bc5db55ee67b51df735ee59",
"triggerType" : "PUSH"
}, {
"hash" : "71505f07ad3215a36e8a617b98c2e372abd8d2a5",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4666",
"triggerID" : "71505f07ad3215a36e8a617b98c2e372abd8d2a5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* cb1cc9010c0c9d572bc5db55ee67b51df735ee59 Azure: [CANCELED](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4662)
* 71505f07ad3215a36e8a617b98c2e372abd8d2a5 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4666)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4404: [HUDI-2558] Fixing Clustering w/ sort columns with null values fails
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4404:
URL: https://github.com/apache/hudi/pull/4404#issuecomment-999398343
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4593",
"triggerID" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"triggerType" : "PUSH"
}, {
"hash" : "cb1cc9010c0c9d572bc5db55ee67b51df735ee59",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4662",
"triggerID" : "cb1cc9010c0c9d572bc5db55ee67b51df735ee59",
"triggerType" : "PUSH"
}, {
"hash" : "71505f07ad3215a36e8a617b98c2e372abd8d2a5",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "71505f07ad3215a36e8a617b98c2e372abd8d2a5",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fbca0322a0dc67f938d3489536fd660c70a4b506 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4593)
* cb1cc9010c0c9d572bc5db55ee67b51df735ee59 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4662)
* 71505f07ad3215a36e8a617b98c2e372abd8d2a5 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4404: [HUDI-2558] Fixing Clustering w/ sort columns with null values fails
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4404:
URL: https://github.com/apache/hudi/pull/4404#issuecomment-1002915633
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4593",
"triggerID" : "fbca0322a0dc67f938d3489536fd660c70a4b506",
"triggerType" : "PUSH"
}, {
"hash" : "cb1cc9010c0c9d572bc5db55ee67b51df735ee59",
"status" : "DELETED",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4662",
"triggerID" : "cb1cc9010c0c9d572bc5db55ee67b51df735ee59",
"triggerType" : "PUSH"
}, {
"hash" : "71505f07ad3215a36e8a617b98c2e372abd8d2a5",
"status" : "FAILURE",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4666",
"triggerID" : "71505f07ad3215a36e8a617b98c2e372abd8d2a5",
"triggerType" : "PUSH"
}, {
"hash" : "4943271f6883384c7355a47d0d407f227ac02688",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "4943271f6883384c7355a47d0d407f227ac02688",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* 71505f07ad3215a36e8a617b98c2e372abd8d2a5 Azure: [FAILURE](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=4666)
* 4943271f6883384c7355a47d0d407f227ac02688 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org