You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cloudstack.apache.org by al...@apache.org on 2013/04/11 23:22:43 UTC

[20/47] git commit: updated refs/heads/internallb to 3795048

Not using entity factory


Project: http://git-wip-us.apache.org/repos/asf/cloudstack/repo
Commit: http://git-wip-us.apache.org/repos/asf/cloudstack/commit/cf7d40c6
Tree: http://git-wip-us.apache.org/repos/asf/cloudstack/tree/cf7d40c6
Diff: http://git-wip-us.apache.org/repos/asf/cloudstack/diff/cf7d40c6

Branch: refs/heads/internallb
Commit: cf7d40c6cd4c340aa71df959fad06e8b69070d06
Parents: e9300d2
Author: Prachi Damle <pr...@cloud.com>
Authored: Mon Mar 18 11:09:29 2013 -0700
Committer: Prachi Damle <pr...@cloud.com>
Committed: Thu Apr 11 13:22:54 2013 -0700

----------------------------------------------------------------------
 .../platform/orchestration/CloudOrchestrator.java  |   63 +++++++--------
 1 files changed, 31 insertions(+), 32 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/cloudstack/blob/cf7d40c6/engine/orchestration/src/org/apache/cloudstack/platform/orchestration/CloudOrchestrator.java
----------------------------------------------------------------------
diff --git a/engine/orchestration/src/org/apache/cloudstack/platform/orchestration/CloudOrchestrator.java b/engine/orchestration/src/org/apache/cloudstack/platform/orchestration/CloudOrchestrator.java
index c07931b..963e4d7 100755
--- a/engine/orchestration/src/org/apache/cloudstack/platform/orchestration/CloudOrchestrator.java
+++ b/engine/orchestration/src/org/apache/cloudstack/platform/orchestration/CloudOrchestrator.java
@@ -51,7 +51,6 @@ import com.cloud.user.dao.AccountDao;
 import com.cloud.utils.Pair;
 import com.cloud.utils.component.ComponentContext;
 import com.cloud.vm.NicProfile;
-import com.cloud.vm.UserVmVO;
 import com.cloud.vm.VMInstanceVO;
 import com.cloud.vm.VirtualMachineManager;
 import com.cloud.vm.dao.UserVmDao;
@@ -66,25 +65,25 @@ public class CloudOrchestrator implements OrchestrationService {
 
 	@Inject
 	private VirtualMachineManager _itMgr;
-	
+
 	@Inject
 	protected VMTemplateDao _templateDao = null;
-	
+
     @Inject
     protected VMInstanceDao _vmDao;
-    
+
     @Inject
     protected UserVmDao _userVmDao = null;
-    
+
 	@Inject
 	protected ServiceOfferingDao _serviceOfferingDao;
-	
+
 	@Inject
 	protected DiskOfferingDao _diskOfferingDao = null;
-	
+
 	@Inject
 	protected NetworkDao _networkDao;
-	
+
 	@Inject
 	protected AccountDao _accountDao = null;
 
@@ -147,17 +146,17 @@ public class CloudOrchestrator implements OrchestrationService {
 
     @Override
     public VirtualMachineEntity createVirtualMachine(
-            String id, 
-            String owner, 
-            String templateId, 
-            String hostName, 
+            String id,
+            String owner,
+            String templateId,
+            String hostName,
             String displayName,
             String hypervisor,
-            int cpu, 
-            int speed, 
+            int cpu,
+            int speed,
             long memory,
             Long diskSize,
-            List<String> computeTags, 
+            List<String> computeTags,
             List<String> rootDiskTags,
             Map<String, NicProfile> networkNicMap, DeploymentPlan plan) throws InsufficientCapacityException {
 
@@ -173,22 +172,22 @@ public class CloudOrchestrator implements OrchestrationService {
 
     	VirtualMachineEntityImpl vmEntity = ComponentContext.inject(VirtualMachineEntityImpl.class);
     	vmEntity.init(id, owner, hostName, displayName, cpu, speed, memory, computeTags, rootDiskTags, new ArrayList<String>(networkNicMap.keySet()));
-        
-    	
+
+
     	HypervisorType hypervisorType = HypervisorType.valueOf(hypervisor);
 
     	//load vm instance and offerings and call virtualMachineManagerImpl
     	VMInstanceVO vm = _vmDao.findByUuid(id);
-    	
+
 		// If the template represents an ISO, a disk offering must be passed in, and will be used to create the root disk
 		// Else, a disk offering is optional, and if present will be used to create the data disk
 
     	Pair<DiskOfferingVO, Long> rootDiskOffering = new Pair<DiskOfferingVO, Long>(null, null);
 		List<Pair<DiskOfferingVO, Long>> dataDiskOfferings = new ArrayList<Pair<DiskOfferingVO, Long>>();
- 
+
 		ServiceOfferingVO offering = _serviceOfferingDao.findById(vm.getServiceOfferingId());
 		rootDiskOffering.first(offering);
-		
+
 		if(vm.getDiskOfferingId() != null){
     		DiskOfferingVO diskOffering = _diskOfferingDao.findById(vm.getDiskOfferingId());
     		if (diskOffering == null) {
@@ -205,32 +204,32 @@ public class CloudOrchestrator implements OrchestrationService {
     		}
     		dataDiskOfferings.add(new Pair<DiskOfferingVO, Long>(diskOffering, size));
 		}
-		
-		
-		
+
+
+
     	if (_itMgr.allocate(_userVmDao.findById(vm.getId(), true), _templateDao.findById(new Long(templateId)), offering, rootDiskOffering, dataDiskOfferings, networkIpMap, null,	plan, hypervisorType, _accountDao.findById(new Long(owner))) == null) {
 			return null;
 		}
-    	
+
         return vmEntity;
     }
 
     @Override
     public VirtualMachineEntity createVirtualMachineFromScratch(String id, String owner, String isoId, String hostName, String displayName, String hypervisor, String os, int cpu, int speed, long memory,Long diskSize,
             List<String> computeTags, List<String> rootDiskTags, Map<String, NicProfile> networkNicMap, DeploymentPlan plan)  throws InsufficientCapacityException {
-		
+
     	// VirtualMachineEntityImpl vmEntity = new VirtualMachineEntityImpl(id, owner, hostName, displayName, cpu, speed, memory, computeTags, rootDiskTags, networks, vmEntityManager);
     	VirtualMachineEntityImpl vmEntity = ComponentContext.inject(VirtualMachineEntityImpl.class);
     	vmEntity.init(id, owner, hostName, displayName, cpu, speed, memory, computeTags, rootDiskTags, new ArrayList<String>(networkNicMap.keySet()));
 
     	//load vm instance and offerings and call virtualMachineManagerImpl
     	VMInstanceVO vm = _vmDao.findByUuid(id);
-    	
-    	
+
+
 		Pair<DiskOfferingVO, Long> rootDiskOffering = new Pair<DiskOfferingVO, Long>(null, null);
 		ServiceOfferingVO offering = _serviceOfferingDao.findById(vm.getServiceOfferingId());
 		rootDiskOffering.first(offering);
-		
+
 		List<Pair<DiskOfferingVO, Long>> dataDiskOfferings = new ArrayList<Pair<DiskOfferingVO, Long>>();
 		Long diskOfferingId = vm.getDiskOfferingId();
 		if (diskOfferingId == null) {
@@ -251,7 +250,7 @@ public class CloudOrchestrator implements OrchestrationService {
 		}
 		rootDiskOffering.first(diskOffering);
 		rootDiskOffering.second(size);
-		
+
         List<Pair<NetworkVO, NicProfile>> networkIpMap = new ArrayList<Pair<NetworkVO, NicProfile>>();
         for (String uuid : networkNicMap.keySet()) {
             NetworkVO network = _networkDao.findByUuid(uuid);
@@ -259,13 +258,13 @@ public class CloudOrchestrator implements OrchestrationService {
                 networkIpMap.add(new Pair<NetworkVO, NicProfile>(network, networkNicMap.get(uuid)));
             }
         }
-		
+
 		HypervisorType hypervisorType = HypervisorType.valueOf(hypervisor);
-		
+
     	if (_itMgr.allocate(_userVmDao.findById(vm.getId(), true), _templateDao.findById(new Long(isoId)), offering, rootDiskOffering, dataDiskOfferings, networkIpMap, null,	plan, hypervisorType, _accountDao.findById(new Long(owner))) == null) {
 			return null;
 		}
-    	
+
         return vmEntity;
     }