You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/03/02 16:07:06 UTC
[GitHub] [incubator-nuttx] jerpelea opened a new pull request #2954: libs: Author Gregory Nutt: update licenses to Apache
jerpelea opened a new pull request #2954:
URL: https://github.com/apache/incubator-nuttx/pull/2954
## Summary
Gregory Nutt has submitted the SGA and we can migrate the licenses to Apache.
## Impact
none
## Testing
none
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 merged pull request #2954: libs: Author Gregory Nutt: update licenses to Apache
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 merged pull request #2954:
URL: https://github.com/apache/incubator-nuttx/pull/2954
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2954: libs: Author Gregory Nutt: update licenses to Apache
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2954:
URL: https://github.com/apache/incubator-nuttx/pull/2954#discussion_r586393187
##########
File path: include/stdio.h
##########
@@ -72,15 +72,15 @@
# define CONFIG_LIBC_TMPDIR "/tmp"
#endif
-#define P_tmpdir CONFIG_LIBC_TMPDIR
+#define p_tmpdir CONFIG_LIBC_TMPDIR
Review comment:
we can't change P_tmpdir/L_tmpnam since both is defined by standard:
https://pubs.opengroup.org/onlinepubs/9699919799/functions/tempnam.html
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] jerpelea commented on a change in pull request #2954: libs: Author Gregory Nutt: update licenses to Apache
Posted by GitBox <gi...@apache.org>.
jerpelea commented on a change in pull request #2954:
URL: https://github.com/apache/incubator-nuttx/pull/2954#discussion_r586403087
##########
File path: include/stdio.h
##########
@@ -72,15 +72,15 @@
# define CONFIG_LIBC_TMPDIR "/tmp"
#endif
-#define P_tmpdir CONFIG_LIBC_TMPDIR
+#define p_tmpdir CONFIG_LIBC_TMPDIR
Review comment:
thanks for the info
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-nuttx] xiaoxiang781216 commented on a change in pull request #2954: libs: Author Gregory Nutt: update licenses to Apache
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on a change in pull request #2954:
URL: https://github.com/apache/incubator-nuttx/pull/2954#discussion_r586394027
##########
File path: include/stdio.h
##########
@@ -72,15 +72,15 @@
# define CONFIG_LIBC_TMPDIR "/tmp"
#endif
-#define P_tmpdir CONFIG_LIBC_TMPDIR
+#define p_tmpdir CONFIG_LIBC_TMPDIR
Review comment:
But we can add them to nxstyle white list:
https://github.com/apache/incubator-nuttx/blob/master/tools/nxstyle.c#L207
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org