You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/01/16 19:26:54 UTC
[GitHub] [spark] imback82 opened a new pull request #31209: [SPARK-34139][SQL] UnresolvedTableOrView should retain SQL text position for DDL commands
imback82 opened a new pull request #31209:
URL: https://github.com/apache/spark/pull/31209
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Currently, there are many DDL commands where the position of the unresolved identifiers are incorrect:
```
scala> sql("CACHE TABLE unknown")
org.apache.spark.sql.AnalysisException: Table or view not found: unknown; line 1 pos 0;
```
, whereas the `pos` should be `12`.
This PR proposes to fix this issue for commands using `UnresolvedRelation`:
```
CACHE TABLE unknown
UNCACHE TABLE unknown
DELETE FROM unknown
UPDATE unknown SET name='abc'
MERGE INTO unknown1 AS target USING unknown2 AS source ON target.col = source.col WHEN MATCHED THEN DELETE
INSERT INTO TABLE unknown SELECT 1
INSERT OVERWRITE TABLE unknown VALUES (1, 'a')
```
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
To fix a bug.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
Yes, now the above example will print the following:
```
org.apache.spark.sql.AnalysisException: Table or view not found: unknown; line 1 pos 12;
```
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Add a new test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31209: [SPARK-34139][SQL] UnresolvedRelation should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761720461
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38738/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31209: [SPARK-34139][SQL] UnresolvedRelation should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761731415
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134153/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31209: [SPARK-34139][SQL] UnresolvedRelation should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761879245
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38747/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31209: [SPARK-34139][SQL] UnresolvedRelation should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761879256
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38747/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31209: [SPARK-34139][SQL] UnresolvedRelation should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761712671
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38738/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] jaceklaskowski commented on a change in pull request #31209: [SPARK-34139][SQL] UnresolvedRelation should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
jaceklaskowski commented on a change in pull request #31209:
URL: https://github.com/apache/spark/pull/31209#discussion_r559166445
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -2170,6 +2168,14 @@ class AstBuilder extends SqlBaseBaseVisitor[AnyRef] with SQLConfHelper with Logg
}
}
+ /**
+ * Create an [[UnresolvedRelatiohn]] from a multi-part identifier context.
Review comment:
nit: typo in `Relation`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31209: [SPARK-34139][SQL] UnresolvedRelation should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761911088
**[Test build #134164 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134164/testReport)** for PR 31209 at commit [`b461309`](https://github.com/apache/spark/commit/b4613099db8e3b31b36e1671838c345facb79145).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31209: [SPARK-34139][SQL] UnresolvedRelation should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761720461
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38738/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31209: [SPARK-34139][SQL] UnresolvedRelation should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761870517
**[Test build #134164 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134164/testReport)** for PR 31209 at commit [`b461309`](https://github.com/apache/spark/commit/b4613099db8e3b31b36e1671838c345facb79145).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31209: [SPARK-34139][SQL] UnresolvedRelation should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761870517
**[Test build #134164 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134164/testReport)** for PR 31209 at commit [`b461309`](https://github.com/apache/spark/commit/b4613099db8e3b31b36e1671838c345facb79145).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31209: [SPARK-34139][SQL] UnresolvedRelation should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761860899
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38745/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31209: [SPARK-34139][SQL] UnresolvedTableOrView should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761640744
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38733/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan closed pull request #31209: [SPARK-34139][SQL] UnresolvedRelation should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
cloud-fan closed pull request #31209:
URL: https://github.com/apache/spark/pull/31209
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31209: [SPARK-34139][SQL] UnresolvedRelation should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761915289
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134164/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31209: [SPARK-34139][SQL] UnresolvedRelation should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761860899
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38745/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31209: [SPARK-34139][SQL] UnresolvedTableOrView should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761684383
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31209: [SPARK-34139][SQL] UnresolvedRelation should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761713519
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38736/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31209: [SPARK-34139][SQL] UnresolvedRelation should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761885065
**[Test build #134162 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134162/testReport)** for PR 31209 at commit [`8e88318`](https://github.com/apache/spark/commit/8e883180b310aa055beb40d11da30a973cb168f7).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31209: [SPARK-34139][SQL] UnresolvedRelation should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761738896
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134155/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31209: [SPARK-34139][SQL] UnresolvedTableOrView should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761700123
**[Test build #134153 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134153/testReport)** for PR 31209 at commit [`93e2709`](https://github.com/apache/spark/commit/93e27096930e3554e97f9fb05d412c2b701ab377).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31209: [SPARK-34139][SQL] UnresolvedRelation should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761915289
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134164/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31209: [SPARK-34139][SQL] UnresolvedRelation should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761708009
**[Test build #134155 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134155/testReport)** for PR 31209 at commit [`997b5ae`](https://github.com/apache/spark/commit/997b5ae5569d21fc8fd3ef39b91917fa996f0d87).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] imback82 commented on a change in pull request #31209: [SPARK-34139][SQL] UnresolvedRelation should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
imback82 commented on a change in pull request #31209:
URL: https://github.com/apache/spark/pull/31209#discussion_r559207963
##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/parser/AstBuilder.scala
##########
@@ -2170,6 +2168,14 @@ class AstBuilder extends SqlBaseBaseVisitor[AnyRef] with SQLConfHelper with Logg
}
}
+ /**
+ * Create an [[UnresolvedRelatiohn]] from a multi-part identifier context.
Review comment:
Thanks, fixed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31209: [SPARK-34139][SQL] UnresolvedRelation should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761859679
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38745/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31209: [SPARK-34139][SQL] UnresolvedRelation should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761879256
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38747/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31209: [SPARK-34139][SQL] UnresolvedRelation should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761708009
**[Test build #134155 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134155/testReport)** for PR 31209 at commit [`997b5ae`](https://github.com/apache/spark/commit/997b5ae5569d21fc8fd3ef39b91917fa996f0d87).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31209: [SPARK-34139][SQL] UnresolvedRelation should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761730165
**[Test build #134153 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134153/testReport)** for PR 31209 at commit [`93e2709`](https://github.com/apache/spark/commit/93e27096930e3554e97f9fb05d412c2b701ab377).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31209: [SPARK-34139][SQL] UnresolvedRelation should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761731415
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134153/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31209: [SPARK-34139][SQL] UnresolvedRelation should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761700123
**[Test build #134153 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134153/testReport)** for PR 31209 at commit [`93e2709`](https://github.com/apache/spark/commit/93e27096930e3554e97f9fb05d412c2b701ab377).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31209: [SPARK-34139][SQL] UnresolvedTableOrView should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761670520
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38733/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31209: [SPARK-34139][SQL] UnresolvedRelation should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761705525
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38736/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] cloud-fan commented on pull request #31209: [SPARK-34139][SQL] UnresolvedRelation should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
cloud-fan commented on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-762001539
thanks, merging to master!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31209: [SPARK-34139][SQL] UnresolvedRelation should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761716515
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38738/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31209: [SPARK-34139][SQL] UnresolvedRelation should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761851593
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38745/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31209: [SPARK-34139][SQL] UnresolvedTableOrView should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761684384
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31209: [SPARK-34139][SQL] UnresolvedTableOrView should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761622711
**[Test build #134150 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134150/testReport)** for PR 31209 at commit [`4f5466c`](https://github.com/apache/spark/commit/4f5466cb63285dbcdf59a69a672a0d6eb783bba5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31209: [SPARK-34139][SQL] UnresolvedRelation should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761886444
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134162/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31209: [SPARK-34139][SQL] UnresolvedRelation should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761844310
**[Test build #134162 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134162/testReport)** for PR 31209 at commit [`8e88318`](https://github.com/apache/spark/commit/8e883180b310aa055beb40d11da30a973cb168f7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31209: [SPARK-34139][SQL] UnresolvedRelation should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761708647
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38736/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31209: [SPARK-34139][SQL] UnresolvedTableOrView should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761622711
**[Test build #134150 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134150/testReport)** for PR 31209 at commit [`4f5466c`](https://github.com/apache/spark/commit/4f5466cb63285dbcdf59a69a672a0d6eb783bba5).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] imback82 commented on pull request #31209: [SPARK-34139][SQL] UnresolvedRelation should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
imback82 commented on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761971621
cc @cloud-fan
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31209: [SPARK-34139][SQL] UnresolvedRelation should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761844310
**[Test build #134162 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134162/testReport)** for PR 31209 at commit [`8e88318`](https://github.com/apache/spark/commit/8e883180b310aa055beb40d11da30a973cb168f7).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31209: [SPARK-34139][SQL] UnresolvedRelation should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761734579
**[Test build #134155 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134155/testReport)** for PR 31209 at commit [`997b5ae`](https://github.com/apache/spark/commit/997b5ae5569d21fc8fd3ef39b91917fa996f0d87).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31209: [SPARK-34139][SQL] UnresolvedRelation should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761738896
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134155/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31209: [SPARK-34139][SQL] UnresolvedRelation should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761713519
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/38736/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31209: [SPARK-34139][SQL] UnresolvedTableOrView should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761682921
**[Test build #134150 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/134150/testReport)** for PR 31209 at commit [`4f5466c`](https://github.com/apache/spark/commit/4f5466cb63285dbcdf59a69a672a0d6eb783bba5).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31209: [SPARK-34139][SQL] UnresolvedRelation should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761886444
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/134162/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31209: [SPARK-34139][SQL] UnresolvedRelation should retain SQL text position for DDL commands
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31209:
URL: https://github.com/apache/spark/pull/31209#issuecomment-761875639
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/38747/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org