You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "HappenLee (via GitHub)" <gi...@apache.org> on 2023/04/23 18:12:06 UTC
[GitHub] [doris] HappenLee opened a new pull request, #18979: [Compile](vec) Fix compile by USE_BHREAD_SCANNER
HappenLee opened a new pull request, #18979:
URL: https://github.com/apache/doris/pull/18979
# Proposed changes
Support compile `USE_BTHREAD_SCANNER=ON`
## Problem summary
Describe your changes.
## Checklist(Required)
* [ ] Does it affect the original behavior
* [ ] Has unit tests been added
* [ ] Has document been added or modified
* [ ] Does it need to update dependencies
* [ ] Is this PR support rollback (If NO, please explain WHY)
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #18979: [Compile](vec) Fix compile by USE_BHREAD_SCANNER
Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #18979:
URL: https://github.com/apache/doris/pull/18979#issuecomment-1519129636
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 34.78 seconds
stream load tsv: 429 seconds loaded 74807831229 Bytes, about 166 MB/s
stream load json: 24 seconds loaded 2358488459 Bytes, about 93 MB/s
stream load orc: 59 seconds loaded 1101869774 Bytes, about 17 MB/s
stream load parquet: 30 seconds loaded 861443392 Bytes, about 27 MB/s
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230423184203_clickbench_pr_133635.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dataroaring merged pull request #18979: [Compile](vec) Fix compile by USE_BHREAD_SCANNER
Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #18979:
URL: https://github.com/apache/doris/pull/18979
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on a diff in pull request #18979: [Compile](vec) Fix compile by USE_BHREAD_SCANNER
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #18979:
URL: https://github.com/apache/doris/pull/18979#discussion_r1174622735
##########
be/src/vec/exec/scan/pip_scanner_context.h:
##########
@@ -38,7 +38,7 @@ class PipScannerContext : public vectorized::ScannerContext {
Status get_block_from_queue(RuntimeState* state, vectorized::BlockUPtr* block, bool* eos,
int id, bool wait = false) override {
{
- std::unique_lock<std::mutex> l(_transfer_lock);
+ std::unique_lock l(_transfer_lock);
if (state->is_cancelled()) {
Review Comment:
warning: member access into incomplete type 'doris::RuntimeState' [clang-diagnostic-error]
```cpp
if (state->is_cancelled()) {
^
```
**be/src/udf/udf.h:33:** forward declaration of 'doris::RuntimeState'
```cpp
class RuntimeState;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] HappenLee commented on pull request #18979: [Compile](vec) Fix compile by USE_BHREAD_SCANNER
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on PR #18979:
URL: https://github.com/apache/doris/pull/18979#issuecomment-1519124450
run buildall
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org