You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/02/15 03:54:09 UTC

[GitHub] [incubator-nuttx] xiaoxiang781216 commented on pull request #5485: boards: sabre-6quad: Add -fno-common to Make.defs

xiaoxiang781216 commented on pull request #5485:
URL: https://github.com/apache/incubator-nuttx/pull/5485#issuecomment-1039826690


   Yes, I think the direction is right. -fno-common should be added to all source code(elf binary and core os) who want to use elf related feature.
   Since elf is a common feature, I would suggest to add -fno-common in ARCHCFLAGS for all board files(except we hit the error similar to esp32c3-devkit:wapi. Otherwise, people will hit the similar issue again and again.
   BTW, -fno-common encourage the good practice, I don't there is any negative side effect to enable it(except compatible with some prebuilt library).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org