You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by Zhen Zhang <ne...@gmail.com> on 2013/06/19 09:27:05 UTC
Review Request: refactor ZKHelixManager to handle zk session expiry more
reliably
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11961/
-----------------------------------------------------------
Review request for helix, Kishore Gopalakrishna and Shi Lu.
Description
-------
1) separate HelixManager impl for participant, controller, and distributed controller
2) take care of consecutive handleNewSession() and session expiry during handleNewSession()
3) fix HelixManager#isLeader() bug by comparing both instanceName and sessionId
4) a few other fixes
Diffs
-----
helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java ff45c74
helix-core/src/main/java/org/apache/helix/healthcheck/ParticipantHealthReportCollectorImpl.java 1b337fd
helix-core/src/main/java/org/apache/helix/manager/zk/AbstractHelixManager.java e69de29
helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java cfe40c1
helix-core/src/main/java/org/apache/helix/manager/zk/DistributedLeaderElection.java e69de29
helix-core/src/main/java/org/apache/helix/manager/zk/HelixController.java e69de29
helix-core/src/main/java/org/apache/helix/manager/zk/HelixControllerNewSessionHandler.java e69de29
helix-core/src/main/java/org/apache/helix/manager/zk/HelixDistributedController.java e69de29
helix-core/src/main/java/org/apache/helix/manager/zk/HelixParticipant.java e69de29
helix-core/src/main/java/org/apache/helix/manager/zk/HelixParticipantNewSessionHandler.java e69de29
helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java ba9b400
helix-core/src/test/java/org/apache/helix/integration/TestHelixDistributedController.java e69de29
helix-core/src/test/java/org/apache/helix/integration/TestHelixParticipant.java e69de29
Diff: https://reviews.apache.org/r/11961/diff/
Testing
-------
all original tests passed
add two new tests:
TestHelixParticipant.java
TestHelixDistributedController.java
both new tests passed
Thanks,
Zhen Zhang
Re: Review Request: refactor ZKHelixManager to handle zk session expiry more
reliably
Posted by Kishore Gopalakrishna <ki...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11961/#review22130
-----------------------------------------------------------
Ship it!
Ship It!
helix-core/src/main/java/org/apache/helix/manager/zk/HelixParticipant.java
<https://reviews.apache.org/r/11961/#comment45531>
rename it to carry over previous state
- Kishore Gopalakrishna
On June 19, 2013, 7:27 a.m., Zhen Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11961/
> -----------------------------------------------------------
>
> (Updated June 19, 2013, 7:27 a.m.)
>
>
> Review request for helix, Kishore Gopalakrishna and Shi Lu.
>
>
> Description
> -------
>
> 1) separate HelixManager impl for participant, controller, and distributed controller
> 2) take care of consecutive handleNewSession() and session expiry during handleNewSession()
> 3) fix HelixManager#isLeader() bug by comparing both instanceName and sessionId
> 4) a few other fixes
>
>
> Diffs
> -----
>
> helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java ff45c74
> helix-core/src/main/java/org/apache/helix/healthcheck/ParticipantHealthReportCollectorImpl.java 1b337fd
> helix-core/src/main/java/org/apache/helix/manager/zk/AbstractHelixManager.java e69de29
> helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java cfe40c1
> helix-core/src/main/java/org/apache/helix/manager/zk/DistributedLeaderElection.java e69de29
> helix-core/src/main/java/org/apache/helix/manager/zk/HelixController.java e69de29
> helix-core/src/main/java/org/apache/helix/manager/zk/HelixControllerNewSessionHandler.java e69de29
> helix-core/src/main/java/org/apache/helix/manager/zk/HelixDistributedController.java e69de29
> helix-core/src/main/java/org/apache/helix/manager/zk/HelixParticipant.java e69de29
> helix-core/src/main/java/org/apache/helix/manager/zk/HelixParticipantNewSessionHandler.java e69de29
> helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java ba9b400
> helix-core/src/test/java/org/apache/helix/integration/TestHelixDistributedController.java e69de29
> helix-core/src/test/java/org/apache/helix/integration/TestHelixParticipant.java e69de29
>
> Diff: https://reviews.apache.org/r/11961/diff/
>
>
> Testing
> -------
>
> all original tests passed
>
> add two new tests:
> TestHelixParticipant.java
> TestHelixDistributedController.java
>
> both new tests passed
>
>
> Thanks,
>
> Zhen Zhang
>
>
Re: Review Request: refactor ZKHelixManager to handle zk session expiry more
reliably
Posted by Shi Lu <lu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11961/#review22134
-----------------------------------------------------------
Ship it!
Ship It!
- Shi Lu
On June 19, 2013, 7:27 a.m., Zhen Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11961/
> -----------------------------------------------------------
>
> (Updated June 19, 2013, 7:27 a.m.)
>
>
> Review request for helix, Kishore Gopalakrishna and Shi Lu.
>
>
> Description
> -------
>
> 1) separate HelixManager impl for participant, controller, and distributed controller
> 2) take care of consecutive handleNewSession() and session expiry during handleNewSession()
> 3) fix HelixManager#isLeader() bug by comparing both instanceName and sessionId
> 4) a few other fixes
>
>
> Diffs
> -----
>
> helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java ff45c74
> helix-core/src/main/java/org/apache/helix/healthcheck/ParticipantHealthReportCollectorImpl.java 1b337fd
> helix-core/src/main/java/org/apache/helix/manager/zk/AbstractHelixManager.java e69de29
> helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java cfe40c1
> helix-core/src/main/java/org/apache/helix/manager/zk/DistributedLeaderElection.java e69de29
> helix-core/src/main/java/org/apache/helix/manager/zk/HelixController.java e69de29
> helix-core/src/main/java/org/apache/helix/manager/zk/HelixControllerNewSessionHandler.java e69de29
> helix-core/src/main/java/org/apache/helix/manager/zk/HelixDistributedController.java e69de29
> helix-core/src/main/java/org/apache/helix/manager/zk/HelixParticipant.java e69de29
> helix-core/src/main/java/org/apache/helix/manager/zk/HelixParticipantNewSessionHandler.java e69de29
> helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java ba9b400
> helix-core/src/test/java/org/apache/helix/integration/TestHelixDistributedController.java e69de29
> helix-core/src/test/java/org/apache/helix/integration/TestHelixParticipant.java e69de29
>
> Diff: https://reviews.apache.org/r/11961/diff/
>
>
> Testing
> -------
>
> all original tests passed
>
> add two new tests:
> TestHelixParticipant.java
> TestHelixDistributedController.java
>
> both new tests passed
>
>
> Thanks,
>
> Zhen Zhang
>
>
Re: Review Request: refactor ZKHelixManager to handle zk session expiry more
reliably
Posted by Zhen Zhang <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11961/
-----------------------------------------------------------
(Updated June 21, 2013, 8:55 p.m.)
Review request for helix, Kishore Gopalakrishna and Shi Lu.
Changes
-------
minor changes
Description
-------
1) separate HelixManager impl for participant, controller, and distributed controller
2) take care of consecutive handleNewSession() and session expiry during handleNewSession()
3) fix HelixManager#isLeader() bug by comparing both instanceName and sessionId
4) a few other fixes
Diffs (updated)
-----
helix-core/src/main/java/org/apache/helix/controller/GenericHelixController.java ff45c74
helix-core/src/main/java/org/apache/helix/healthcheck/ParticipantHealthReportCollectorImpl.java 1b337fd
helix-core/src/main/java/org/apache/helix/manager/zk/AbstractManager.java e69de29
helix-core/src/main/java/org/apache/helix/manager/zk/CallbackHandler.java cfe40c1
helix-core/src/main/java/org/apache/helix/manager/zk/ControllerManager.java e69de29
helix-core/src/main/java/org/apache/helix/manager/zk/ControllerManagerHelper.java e69de29
helix-core/src/main/java/org/apache/helix/manager/zk/DistributedControllerManager.java e69de29
helix-core/src/main/java/org/apache/helix/manager/zk/DistributedLeaderElection.java e69de29
helix-core/src/main/java/org/apache/helix/manager/zk/ParticipantManager.java e69de29
helix-core/src/main/java/org/apache/helix/messaging/handling/HelixTaskExecutor.java ba9b400
helix-core/src/test/java/org/apache/helix/integration/manager/TestDistributedControllerManager.java e69de29
helix-core/src/test/java/org/apache/helix/integration/manager/TestParticipantManager.java e69de29
Diff: https://reviews.apache.org/r/11961/diff/
Testing
-------
all original tests passed
add two new tests:
TestHelixParticipant.java
TestHelixDistributedController.java
both new tests passed
Thanks,
Zhen Zhang