[jira] [Commented] (CALCITE-1803) Push Project that follows Aggregate down to Druid

["Julian Hyde (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/CALCITE-1803?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16089025#comment-16089025 ] 

Julian Hyde commented on CALCITE-1803:
--------------------------------------

[~axeisghost], Coverity discovered an issue with your code. Please review and correct if necessary.

{noformat}
*** CID 150320:  Control flow issues  (MISSING_BREAK)
/druid/src/main/java/org/apache/calcite/adapter/druid/DruidConnectionImpl.java: 353 in org.apache.calcite.adapter.druid.DruidConnectionImpl.parseField(java.util.List, java.util.List, int, org.apache.calcite.interpreter.Row$RowBuilder, com.fasterxml.jackson.core.JsonParser)()
347             case PRIMITIVE_SHORT:
348             case INTEGER:
349             case PRIMITIVE_INT:
350               if (s.equals("Infinity") || s.equals("-Infinity") || s.equals("NaN")) {
351                 throw new RuntimeException("/ by zero");
352               }
   CID 150320:  Control flow issues  (MISSING_BREAK)
   The above case falls through to this one.
353             case FLOAT:
354             case PRIMITIVE_FLOAT:
355             case PRIMITIVE_DOUBLE:
356             case NUMBER:
357             case DOUBLE:
358               if (s.equals("Infinity")) {

{noformat}

> Push Project that follows Aggregate down to Druid
> -------------------------------------------------
>
>                 Key: CALCITE-1803
>                 URL: https://issues.apache.org/jira/browse/CALCITE-1803
>             Project: Calcite
>          Issue Type: New Feature
>          Components: druid
>    Affects Versions: 1.11.0
>            Reporter: Junxian Wu
>            Assignee: Junxian Wu
>             Fix For: 1.14.0
>
>   Original Estimate: 336h
>  Remaining Estimate: 336h
>
> Druid post aggregations are not supported when parsing SQL queries. By implementing post aggregations, we can offload some computation to the druid cluster rather than aggregate on the client side.
> Example usage:
> {{SELECT SUM("column1") - SUM("column2") FROM "table";}}
> This query will be parsed into two separate Druid aggregations according to current rules. Then the results will be subtracted in Calcite. By using the {{postAggregations}} field in the druid query, the subtraction could be done in Druid cluster. Although the previous example is simple, the difference will be obvious when the number of result rows are large. (Multiple rows result will happen when group by is used).
> Questions:
> After I push Post aggregation into Druid query, what should I change on the project relational correlation? In the case of the example above, the {{BindableProject}} will have the expression to representation the subtraction. If I push the post aggregation into druid query, the expression of subtraction should be replaced by the representation of the post aggregations result. For now, the project expression seems can only point to the aggregations results. Since post aggregations have to point to aggregations results too, it could not be placed in the parallel level as aggregation. Where should I put post aggregations?



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)