[GitHub] [incubator-devlake-helm-chart] matrixji commented on a diff in pull request #86: Refactor: Optimize The Chart Structure

["matrixji (via GitHub)" <gi...@apache.org>]

matrixji commented on code in PR #86:
URL: https://github.com/apache/incubator-devlake-helm-chart/pull/86#discussion_r1132463206


##########
charts/devlake/templates/grafana/deployment.yaml:
##########
@@ -82,76 +78,10 @@ spec:
         {{- toYaml . | nindent 8 }}
       {{- end }}
       volumes:
-        {{- if ne .Values.option.localtime "" }}
         - name: {{ include "devlake.fullname" . }}-grafana-localtime
           hostPath:
-            path: {{ .Values.option.localtime }}
+            path: /etc/localtime

Review Comment:
   some environments may not have `/etc/localtime` on host. Maybe we could change to setting `TZ` environment variable in another PR.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@devlake.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org