[GitHub] spark pull request: [SPARK-14950][SQL] Fix BroadcastHashJoin's uni...

[davies <gi...@git.apache.org>]

Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/12730#discussion_r61282299
  
    --- Diff: sql/core/src/main/scala/org/apache/spark/sql/execution/joins/BroadcastHashJoinExec.scala ---
    @@ -351,11 +359,12 @@ case class BroadcastHashJoinExec(
        */
       private def codegenAnti(ctx: CodegenContext, input: Seq[ExprCode]): String = {
         val (broadcastRelation, relationTerm) = prepareBroadcast(ctx)
    +    val uniqueKeyCodePath = broadcastRelation.value.keyIsUnique
         val (keyEv, anyNull) = genStreamSideJoinKey(ctx, input)
    -    val (matched, checkCondition, _) = getJoinCondition(ctx, input)
    +    val (matched, checkCondition, _) = getJoinCondition(ctx, input, uniqueKeyCodePath)
    --- End diff --
    
    checkCondition is also used by non-unique-key


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org