You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2020/02/11 10:04:19 UTC
[GitHub] [incubator-livy] codecov-io edited a comment on issue #228:
[LIVY-663][API] exposing job id and session id in livy client
codecov-io edited a comment on issue #228: [LIVY-663][API] exposing job id and session id in livy client
URL: https://github.com/apache/incubator-livy/pull/228#issuecomment-529365575
# [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/228?src=pr&el=h1) Report
> Merging [#228](https://codecov.io/gh/apache/incubator-livy/pull/228?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-livy/commit/f4ab5ef5d389d5743410f5839ffc79aea8943c9c?src=pr&el=desc) will **decrease** coverage by `<.01%`.
> The diff coverage is `71.42%`.
[![Impacted file tree graph](https://codecov.io/gh/apache/incubator-livy/pull/228/graphs/tree.svg?width=650&token=0MkVbiUFwE&height=150&src=pr)](https://codecov.io/gh/apache/incubator-livy/pull/228?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #228 +/- ##
============================================
- Coverage 68.12% 68.12% -0.01%
- Complexity 960 963 +3
============================================
Files 104 104
Lines 5946 5951 +5
Branches 899 899
============================================
+ Hits 4051 4054 +3
- Misses 1314 1316 +2
Partials 581 581
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-livy/pull/228?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [api/src/main/java/org/apache/livy/JobHandle.java](https://codecov.io/gh/apache/incubator-livy/pull/228/diff?src=pr&el=tree#diff-YXBpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L0pvYkhhbmRsZS5qYXZh) | `100% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
| [...c/src/main/java/org/apache/livy/rsc/RSCClient.java](https://codecov.io/gh/apache/incubator-livy/pull/228/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9SU0NDbGllbnQuamF2YQ==) | `73.05% <0%> (-0.45%)` | `20 <0> (ø)` | |
| [...ala/org/apache/livy/scalaapi/LivyScalaClient.scala](https://codecov.io/gh/apache/incubator-livy/pull/228/diff?src=pr&el=tree#diff-c2NhbGEtYXBpL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zY2FsYWFwaS9MaXZ5U2NhbGFDbGllbnQuc2NhbGE=) | `83.87% <100%> (+0.53%)` | `8 <1> (+1)` | :arrow_up: |
| [...n/java/org/apache/livy/client/http/HttpClient.java](https://codecov.io/gh/apache/incubator-livy/pull/228/diff?src=pr&el=tree#diff-Y2xpZW50LWh0dHAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2xpdnkvY2xpZW50L2h0dHAvSHR0cENsaWVudC5qYXZh) | `85.48% <100%> (ø)` | `15 <1> (ø)` | :arrow_down: |
| [...c/main/java/org/apache/livy/rsc/JobHandleImpl.java](https://codecov.io/gh/apache/incubator-livy/pull/228/diff?src=pr&el=tree#diff-cnNjL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9saXZ5L3JzYy9Kb2JIYW5kbGVJbXBsLmphdmE=) | `74.07% <100%> (+0.99%)` | `8 <1> (+1)` | :arrow_up: |
| [...ava/org/apache/livy/client/http/JobHandleImpl.java](https://codecov.io/gh/apache/incubator-livy/pull/228/diff?src=pr&el=tree#diff-Y2xpZW50LWh0dHAvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL2xpdnkvY2xpZW50L2h0dHAvSm9iSGFuZGxlSW1wbC5qYXZh) | `75.45% <100%> (+0.22%)` | `14 <1> (+1)` | :arrow_up: |
| [...cala/org/apache/livy/scalaapi/ScalaJobHandle.scala](https://codecov.io/gh/apache/incubator-livy/pull/228/diff?src=pr&el=tree#diff-c2NhbGEtYXBpL3NyYy9tYWluL3NjYWxhL29yZy9hcGFjaGUvbGl2eS9zY2FsYWFwaS9TY2FsYUpvYkhhbmRsZS5zY2FsYQ==) | `51.42% <50%> (-1.52%)` | `8 <1> (+1)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-livy/pull/228?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-livy/pull/228?src=pr&el=footer). Last update [f4ab5ef...6ff7fbf](https://codecov.io/gh/apache/incubator-livy/pull/228?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services