You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2019/01/30 07:47:08 UTC

[GitHub] alex-the-man commented on a change in pull request #142: [LIVY-552][WIP] Add JWTFilter to validate incoming JWT tokens

alex-the-man commented on a change in pull request #142: [LIVY-552][WIP] Add JWTFilter to validate incoming JWT tokens
URL: https://github.com/apache/incubator-livy/pull/142#discussion_r252144906
 
 

 ##########
 File path: server/src/main/scala/org/apache/livy/LivyConf.scala
 ##########
 @@ -168,6 +168,10 @@ object LivyConf {
   val THRIFT_DELEGATION_TOKEN_RENEW_INTERVAL =
     Entry("livy.server.thrift.delegation.token.renew-interval", "1d")
 
+  val JWT_FILTER_ENABLED = Entry("livy.jwt.filter.enabled", false)
+  val JWT_HEADER_NAME = Entry("livy.jwt.header.name", "Authentication")
+  val JWT_SIGNATURE_PUBLIC_KEY_PATH = Entry("livy.jwt.public-key.path", null)
 
 Review comment:
   Is there any chance we need to support multiple public keys for key rotation?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services