You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/01/19 12:07:54 UTC

[GitHub] [shardingsphere] tristaZero commented on a change in pull request #9084: [SQL Definition Collation][Oracle]Collate the SQL definition of DROP TABLE

tristaZero commented on a change in pull request #9084:
URL: https://github.com/apache/shardingsphere/pull/9084#discussion_r560129967



##########
File path: shardingsphere-sql-parser/shardingsphere-sql-parser-test/src/main/resources/sql/supported/ddl/drop.xml
##########
@@ -23,6 +23,7 @@
     <sql-case id="drop_table_restrict" value="DROP TABLE t_log RESTRICT" db-types="MySQL,PostgreSQL" />
     <sql-case id="drop_table_cascade" value="DROP TABLE t_log CASCADE" db-types="MySQL,PostgreSQL" />
     <sql-case id="drop_table_cascade_constraints_and_purge" value="DROP TABLE t_log CASCADE CONSTRAINTS PURGE" db-types="Oracle" />
+    <sql-case id="drop_table_purge" value="DROP TABLE t_log PURGE" db-types="Oracle" />

Review comment:
       
   I suppose `DROP TABLE from db PURGE` is a more valuable case. Could you add this one or replace that simple one?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org