[GitHub] [flink] dianfu commented on a change in pull request #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF

[GitBox <gi...@apache.org>]

dianfu commented on a change in pull request #11598: [FLINK-16914][python] Support ArrayType in vectorized Python UDF
URL: https://github.com/apache/flink/pull/11598#discussion_r402069877
 
 

 ##########
 File path: flink-python/src/main/java/org/apache/flink/table/runtime/arrow/writers/BaseRowIntWriter.java
 ##########
 @@ -19,22 +19,22 @@
 package org.apache.flink.table.runtime.arrow.writers;
 
 import org.apache.flink.annotation.Internal;
-import org.apache.flink.table.dataformat.BaseRow;
+import org.apache.flink.table.dataformat.TypeGetterSetters;
 
 import org.apache.arrow.vector.IntVector;
 
 /**
  * {@link ArrowFieldWriter} for Int.
  */
 @Internal
-public final class BaseRowIntWriter extends ArrowFieldWriter<BaseRow> {
+public final class BaseRowIntWriter<T extends TypeGetterSetters> extends ArrowFieldWriter<T> {
 
 Review comment:
   Make sense to me. Have renamed the original IntWriter to RowIntWriter and BaseRowIntWriter to IntWriter. Also updated the other classes.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services