You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "xinrong-meng (via GitHub)" <gi...@apache.org> on 2023/04/05 18:12:35 UTC

[GitHub] [spark] xinrong-meng commented on a diff in pull request #40665: [SPARK-42621][PS] Add inclusive parameter for pd.date_range

xinrong-meng commented on code in PR #40665:
URL: https://github.com/apache/spark/pull/40665#discussion_r1158855225


##########
python/pyspark/pandas/namespace.py:
##########
@@ -1782,12 +1780,8 @@ def date_range(
         Normalize start/end dates to midnight before generating date range.
     name : str, default None
         Name of the resulting DatetimeIndex.
-    closed : {None, 'left', 'right'}, optional
-        Make the interval closed with respect to the given frequency to
-        the 'left', 'right', or both sides (None, the default).
-
-        .. deprecated:: 3.4.0
-
+    inclusive : {"both", "neither", "left", "right"}, default "both"

Review Comment:
   nit: Shall we add `versionadded`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org