You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by cu...@apache.org on 2019/03/26 20:19:33 UTC

[arrow] branch master updated: ARROW-5014: [Java] Fix typos in Flight module

This is an automated email from the ASF dual-hosted git repository.

cutlerb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/master by this push:
     new 60e01fd  ARROW-5014: [Java] Fix typos in Flight module
60e01fd is described below

commit 60e01fd9e40fc2aa4edb495c0fa140601fec96d4
Author: Bryan Cutler <cu...@gmail.com>
AuthorDate: Tue Mar 26 13:19:23 2019 -0700

    ARROW-5014: [Java] Fix typos in Flight module
    
    This fixes a few typos that I found while going through the Java Flight module.
    
    Author: Bryan Cutler <cu...@gmail.com>
    
    Closes #4037 from BryanCutler/java-fix-flight-typos-ARROW-5014 and squashes the following commits:
    
    4eb9912 <Bryan Cutler> fix typos in java flight module
---
 java/flight/src/main/java/org/apache/arrow/flight/FlightClient.java    | 2 +-
 java/flight/src/main/java/org/apache/arrow/flight/FlightProducer.java  | 2 +-
 .../src/main/java/org/apache/arrow/flight/example/FlightHolder.java    | 2 +-
 .../src/main/java/org/apache/arrow/flight/example/InMemoryStore.java   | 2 +-
 .../src/main/java/org/apache/arrow/flight/grpc/AddWritableBuffer.java  | 2 +-
 .../test/java/org/apache/arrow/flight/perf/PerformanceTestServer.java  | 3 +--
 6 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/java/flight/src/main/java/org/apache/arrow/flight/FlightClient.java b/java/flight/src/main/java/org/apache/arrow/flight/FlightClient.java
index b7a7e3f..f6bc452 100644
--- a/java/flight/src/main/java/org/apache/arrow/flight/FlightClient.java
+++ b/java/flight/src/main/java/org/apache/arrow/flight/FlightClient.java
@@ -86,7 +86,7 @@ public class FlightClient implements AutoCloseable {
 
   /**
    * Get a list of available flights.
-   * @param criteria Critera for selecting flights
+   * @param criteria Criteria for selecting flights
    * @return FlightInfo Iterable
    */
   public Iterable<FlightInfo> listFlights(Criteria criteria) {
diff --git a/java/flight/src/main/java/org/apache/arrow/flight/FlightProducer.java b/java/flight/src/main/java/org/apache/arrow/flight/FlightProducer.java
index fc320f5..f2415f2 100644
--- a/java/flight/src/main/java/org/apache/arrow/flight/FlightProducer.java
+++ b/java/flight/src/main/java/org/apache/arrow/flight/FlightProducer.java
@@ -23,7 +23,7 @@ import org.apache.arrow.flight.impl.Flight.PutResult;
 import org.apache.arrow.vector.VectorSchemaRoot;
 
 /**
- * API to Implement an Arrow Flight server.
+ * API to Implement an Arrow Flight producer.
  */
 public interface FlightProducer {
 
diff --git a/java/flight/src/main/java/org/apache/arrow/flight/example/FlightHolder.java b/java/flight/src/main/java/org/apache/arrow/flight/example/FlightHolder.java
index fff6ab3..de4d94e 100644
--- a/java/flight/src/main/java/org/apache/arrow/flight/example/FlightHolder.java
+++ b/java/flight/src/main/java/org/apache/arrow/flight/example/FlightHolder.java
@@ -56,7 +56,7 @@ public class FlightHolder implements AutoCloseable {
   }
 
   public Stream.StreamCreator addStream(Schema schema) {
-    Preconditions.checkArgument(schema.equals(schema), "Stream schema inconsitent with existing schema.");
+    Preconditions.checkArgument(schema.equals(schema), "Stream schema inconsistent with existing schema.");
     return new Stream.StreamCreator(schema, allocator, t -> {
       synchronized (streams) {
         streams.add(t);
diff --git a/java/flight/src/main/java/org/apache/arrow/flight/example/InMemoryStore.java b/java/flight/src/main/java/org/apache/arrow/flight/example/InMemoryStore.java
index dd06f79..c95ee95 100644
--- a/java/flight/src/main/java/org/apache/arrow/flight/example/InMemoryStore.java
+++ b/java/flight/src/main/java/org/apache/arrow/flight/example/InMemoryStore.java
@@ -143,7 +143,7 @@ public class InMemoryStore implements FlightProducer, AutoCloseable {
   @Override
   public void listActions(StreamListener<ActionType> listener) {
     listener.onNext(new ActionType("get", "pull a stream. Action must be done via standard get mechanism"));
-    listener.onNext(new ActionType("put", "push a stream. Action must be done via standard get mechanism"));
+    listener.onNext(new ActionType("put", "push a stream. Action must be done via standard put mechanism"));
     listener.onNext(new ActionType("drop", "delete a flight. Action body is a JSON encoded path."));
     listener.onCompleted();
   }
diff --git a/java/flight/src/main/java/org/apache/arrow/flight/grpc/AddWritableBuffer.java b/java/flight/src/main/java/org/apache/arrow/flight/grpc/AddWritableBuffer.java
index 80158d7..07b19c2 100644
--- a/java/flight/src/main/java/org/apache/arrow/flight/grpc/AddWritableBuffer.java
+++ b/java/flight/src/main/java/org/apache/arrow/flight/grpc/AddWritableBuffer.java
@@ -30,7 +30,7 @@ import io.netty.buffer.ByteBuf;
 /**
  * Allow a user to add a ByteBuf based InputStream directly into GRPC WritableBuffer to avoid an
  * extra copy. This could be solved in GRPC by adding a ByteBufListable interface on InputStream and
- * letting BufferChainOutputStream take adavantage of it.
+ * letting BufferChainOutputStream take advantage of it.
  */
 public class AddWritableBuffer {
 
diff --git a/java/flight/src/test/java/org/apache/arrow/flight/perf/PerformanceTestServer.java b/java/flight/src/test/java/org/apache/arrow/flight/perf/PerformanceTestServer.java
index 6bd83ae..fe63147 100644
--- a/java/flight/src/test/java/org/apache/arrow/flight/perf/PerformanceTestServer.java
+++ b/java/flight/src/test/java/org/apache/arrow/flight/perf/PerformanceTestServer.java
@@ -36,7 +36,6 @@ import org.apache.arrow.flight.Location;
 import org.apache.arrow.flight.Result;
 import org.apache.arrow.flight.Ticket;
 import org.apache.arrow.flight.auth.ServerAuthHandler;
-import org.apache.arrow.flight.example.ExampleFlightServer;
 import org.apache.arrow.flight.impl.Flight.PutResult;
 import org.apache.arrow.flight.perf.impl.PerfOuterClass.Perf;
 import org.apache.arrow.flight.perf.impl.PerfOuterClass.Token;
@@ -54,7 +53,7 @@ import com.google.protobuf.InvalidProtocolBufferException;
 
 public class PerformanceTestServer implements AutoCloseable {
 
-  private static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(ExampleFlightServer.class);
+  private static final org.slf4j.Logger logger = org.slf4j.LoggerFactory.getLogger(PerformanceTestServer.class);
 
   private final FlightServer flightServer;
   private final Location location;