You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Udo Kohlmeyer <ud...@apache.com> on 2019/10/30 17:54:08 UTC
[DISCUSS] - Upgrading from Spring 4 to Spring 5
Hi there fellow Apache Geode Devs,
We would like to propose the upgrade of the Spring libraries within
Geode Project.
Currently the project is using Spring 4, which is EOL Q1 2020.
The link the proposal can be found here
<https://cwiki.apache.org/confluence/display/GEODE/%5BDiscussion%5D+-+Upgrade+Spring+version+from+Spring+4+to+Spring+5.x>.
Please provide feedback on this proposal as comments on the proposal's
comment section within Apache Geode wiki. Feedback will closed on 8
November 2019.
--Udo
[1]
https://cwiki.apache.org/confluence/display/GEODE/%5BDiscussion%5D+-+Upgrade+Spring+version+from+Spring+4+to+Spring+5.x
Re: [DISCUSS] - Upgrading from Spring 4 to Spring 5
Posted by Udo Kohlmeyer <ud...@apache.com>.
@Naba, Thank you for this.
I think we have identified quite a few PR's (I think we could name
around 5 ppl who have started this).
The intent is to align the versions with verified BOM versions. THAT
should hopefully help this exercise be simplified.
--Udo
On 11/7/19 3:37 PM, Nabarun Nag wrote:
> Initial attempts have been made : https://github.com/apache/geode/pull/4256
> This PR has Maintainers edit permissions enabled.
>
> We need to figure out a plan on these following springframework
> dependencies too.
> - spring-hateos [geode - 0.25.0 RELEASE latest 1.0.1 RELEASE]
> - spring-plugin-core [geode - 1.2.0 RELEASE latest 2.0.0 RELEASE]
> - spring-plugin-metadata [geode - 1.2.0 RELEASE latest 2.0.0 RELEASE]
>
>
>
>
> On Thu, Nov 7, 2019 at 2:43 PM Jason Huynh <jh...@pivotal.io> wrote:
>
>> +1
>>
>> On Thu, Nov 7, 2019 at 1:28 PM Dan Smith <ds...@pivotal.io> wrote:
>>
>>> +1
>>>
>>> On Thu, Nov 7, 2019 at 12:49 PM Jens Deppe <jd...@pivotal.io> wrote:
>>>
>>>> +1
>>>>
>>>> On Wed, Oct 30, 2019 at 1:39 PM Udo Kohlmeyer <ud...@apache.com> wrote:
>>>>
>>>>> Sorry,
>>>>>
>>>>> To clarify... When we change the Spring version we would be looking
>> at
>>>>> looking to use the latest version and it's associated BOM.
>>>>>
>>>>> That might be inclusive of other Spring project upgrades.
>>>>>
>>>>> --Udo
>>>>>
>>>>> On 10/30/19 1:35 PM, Nabarun Nag wrote:
>>>>>> Hi Udo,
>>>>>> Maven has the latest as 5.2.0.RELEASE as the latest version. In
>> the
>>>>>> Dependency.groovy file, we have been putting the full version
>> number.
>>>>> Hence
>>>>>> I am guessing you are suggesting we put 5.2.0.RELEASE?
>>>>>>
>>>>>> What about the status of the following dependencies?
>>>>>>
>>>>>> 'org.springframework.hateoas', name: 'spring-hateoas', version:
>>>>>> '0.25.0.RELEASE'
>>>>>> 'org.springframework.ldap', name: 'spring-ldap-core', version:
>>>>>> '2.3.2.RELEASE'
>>>>>> 'org.springframework.shell', name: 'spring-shell', version:
>>>>> '1.2.0.RELEASE'
>>>>>> Regards
>>>>>> Naba
>>>>>>
Re: [DISCUSS] - Upgrading from Spring 4 to Spring 5
Posted by Nabarun Nag <nn...@pivotal.io>.
Initial attempts have been made : https://github.com/apache/geode/pull/4256
This PR has Maintainers edit permissions enabled.
We need to figure out a plan on these following springframework
dependencies too.
- spring-hateos [geode - 0.25.0 RELEASE latest 1.0.1 RELEASE]
- spring-plugin-core [geode - 1.2.0 RELEASE latest 2.0.0 RELEASE]
- spring-plugin-metadata [geode - 1.2.0 RELEASE latest 2.0.0 RELEASE]
On Thu, Nov 7, 2019 at 2:43 PM Jason Huynh <jh...@pivotal.io> wrote:
> +1
>
> On Thu, Nov 7, 2019 at 1:28 PM Dan Smith <ds...@pivotal.io> wrote:
>
> > +1
> >
> > On Thu, Nov 7, 2019 at 12:49 PM Jens Deppe <jd...@pivotal.io> wrote:
> >
> > > +1
> > >
> > > On Wed, Oct 30, 2019 at 1:39 PM Udo Kohlmeyer <ud...@apache.com> wrote:
> > >
> > > > Sorry,
> > > >
> > > > To clarify... When we change the Spring version we would be looking
> at
> > > > looking to use the latest version and it's associated BOM.
> > > >
> > > > That might be inclusive of other Spring project upgrades.
> > > >
> > > > --Udo
> > > >
> > > > On 10/30/19 1:35 PM, Nabarun Nag wrote:
> > > > > Hi Udo,
> > > > > Maven has the latest as 5.2.0.RELEASE as the latest version. In
> the
> > > > > Dependency.groovy file, we have been putting the full version
> number.
> > > > Hence
> > > > > I am guessing you are suggesting we put 5.2.0.RELEASE?
> > > > >
> > > > > What about the status of the following dependencies?
> > > > >
> > > > > 'org.springframework.hateoas', name: 'spring-hateoas', version:
> > > > > '0.25.0.RELEASE'
> > > > > 'org.springframework.ldap', name: 'spring-ldap-core', version:
> > > > > '2.3.2.RELEASE'
> > > > > 'org.springframework.shell', name: 'spring-shell', version:
> > > > '1.2.0.RELEASE'
> > > > >
> > > > > Regards
> > > > > Naba
> > > > >
> > > >
> > >
> >
>
Re: [DISCUSS] - Upgrading from Spring 4 to Spring 5
Posted by Jason Huynh <jh...@pivotal.io>.
+1
On Thu, Nov 7, 2019 at 1:28 PM Dan Smith <ds...@pivotal.io> wrote:
> +1
>
> On Thu, Nov 7, 2019 at 12:49 PM Jens Deppe <jd...@pivotal.io> wrote:
>
> > +1
> >
> > On Wed, Oct 30, 2019 at 1:39 PM Udo Kohlmeyer <ud...@apache.com> wrote:
> >
> > > Sorry,
> > >
> > > To clarify... When we change the Spring version we would be looking at
> > > looking to use the latest version and it's associated BOM.
> > >
> > > That might be inclusive of other Spring project upgrades.
> > >
> > > --Udo
> > >
> > > On 10/30/19 1:35 PM, Nabarun Nag wrote:
> > > > Hi Udo,
> > > > Maven has the latest as 5.2.0.RELEASE as the latest version. In the
> > > > Dependency.groovy file, we have been putting the full version number.
> > > Hence
> > > > I am guessing you are suggesting we put 5.2.0.RELEASE?
> > > >
> > > > What about the status of the following dependencies?
> > > >
> > > > 'org.springframework.hateoas', name: 'spring-hateoas', version:
> > > > '0.25.0.RELEASE'
> > > > 'org.springframework.ldap', name: 'spring-ldap-core', version:
> > > > '2.3.2.RELEASE'
> > > > 'org.springframework.shell', name: 'spring-shell', version:
> > > '1.2.0.RELEASE'
> > > >
> > > > Regards
> > > > Naba
> > > >
> > >
> >
>
Re: [DISCUSS] - Upgrading from Spring 4 to Spring 5
Posted by Dan Smith <ds...@pivotal.io>.
+1
On Thu, Nov 7, 2019 at 12:49 PM Jens Deppe <jd...@pivotal.io> wrote:
> +1
>
> On Wed, Oct 30, 2019 at 1:39 PM Udo Kohlmeyer <ud...@apache.com> wrote:
>
> > Sorry,
> >
> > To clarify... When we change the Spring version we would be looking at
> > looking to use the latest version and it's associated BOM.
> >
> > That might be inclusive of other Spring project upgrades.
> >
> > --Udo
> >
> > On 10/30/19 1:35 PM, Nabarun Nag wrote:
> > > Hi Udo,
> > > Maven has the latest as 5.2.0.RELEASE as the latest version. In the
> > > Dependency.groovy file, we have been putting the full version number.
> > Hence
> > > I am guessing you are suggesting we put 5.2.0.RELEASE?
> > >
> > > What about the status of the following dependencies?
> > >
> > > 'org.springframework.hateoas', name: 'spring-hateoas', version:
> > > '0.25.0.RELEASE'
> > > 'org.springframework.ldap', name: 'spring-ldap-core', version:
> > > '2.3.2.RELEASE'
> > > 'org.springframework.shell', name: 'spring-shell', version:
> > '1.2.0.RELEASE'
> > >
> > > Regards
> > > Naba
> > >
> >
>
Re: [DISCUSS] - Upgrading from Spring 4 to Spring 5
Posted by Jens Deppe <jd...@pivotal.io>.
+1
On Wed, Oct 30, 2019 at 1:39 PM Udo Kohlmeyer <ud...@apache.com> wrote:
> Sorry,
>
> To clarify... When we change the Spring version we would be looking at
> looking to use the latest version and it's associated BOM.
>
> That might be inclusive of other Spring project upgrades.
>
> --Udo
>
> On 10/30/19 1:35 PM, Nabarun Nag wrote:
> > Hi Udo,
> > Maven has the latest as 5.2.0.RELEASE as the latest version. In the
> > Dependency.groovy file, we have been putting the full version number.
> Hence
> > I am guessing you are suggesting we put 5.2.0.RELEASE?
> >
> > What about the status of the following dependencies?
> >
> > 'org.springframework.hateoas', name: 'spring-hateoas', version:
> > '0.25.0.RELEASE'
> > 'org.springframework.ldap', name: 'spring-ldap-core', version:
> > '2.3.2.RELEASE'
> > 'org.springframework.shell', name: 'spring-shell', version:
> '1.2.0.RELEASE'
> >
> > Regards
> > Naba
> >
>
Re: [DISCUSS] - Upgrading from Spring 4 to Spring 5
Posted by Udo Kohlmeyer <ud...@apache.com>.
Sorry,
To clarify... When we change the Spring version we would be looking at
looking to use the latest version and it's associated BOM.
That might be inclusive of other Spring project upgrades.
--Udo
On 10/30/19 1:35 PM, Nabarun Nag wrote:
> Hi Udo,
> Maven has the latest as 5.2.0.RELEASE as the latest version. In the
> Dependency.groovy file, we have been putting the full version number. Hence
> I am guessing you are suggesting we put 5.2.0.RELEASE?
>
> What about the status of the following dependencies?
>
> 'org.springframework.hateoas', name: 'spring-hateoas', version:
> '0.25.0.RELEASE'
> 'org.springframework.ldap', name: 'spring-ldap-core', version:
> '2.3.2.RELEASE'
> 'org.springframework.shell', name: 'spring-shell', version: '1.2.0.RELEASE'
>
> Regards
> Naba
>
Re: [DISCUSS] - Upgrading from Spring 4 to Spring 5
Posted by Nabarun Nag <nn...@apache.org>.
Hi Udo,
Maven has the latest as 5.2.0.RELEASE as the latest version. In the
Dependency.groovy file, we have been putting the full version number. Hence
I am guessing you are suggesting we put 5.2.0.RELEASE?
What about the status of the following dependencies?
'org.springframework.hateoas', name: 'spring-hateoas', version:
'0.25.0.RELEASE'
'org.springframework.ldap', name: 'spring-ldap-core', version:
'2.3.2.RELEASE'
'org.springframework.shell', name: 'spring-shell', version: '1.2.0.RELEASE'
Regards
Naba
Re: [DISCUSS] - Upgrading from Spring 4 to Spring 5
Posted by Udo Kohlmeyer <ud...@apache.com>.
@Naba,
At this point 5.2.x is the weapon of choice. Might be 5.3.x, depending
on when we get to doing this.
--Udo
On 10/30/19 12:02 PM, Nabarun Nag wrote:
> Hi Udo
>
> +1,
> 5.2.0.RELEASE to be specific?
>
> On Wed, Oct 30, 2019 at 11:04 AM Ju@N <ju...@gmail.com> wrote:
>
>> Hello Udo,
>>
>> Big +1 for the proposal!.
>> That said, I believe it was agreed a couple of months ago in the
>> *Lightweight
>> RFC Process [1] *that the whole discussion should be done in the [DISCUSS]
>> email thread directly and not as comments within the proposal itself, you
>> might want to double check that and reply to the thread so the entire
>> discussion remains in one single place.
>> Cheers.
>>
>> [1]:
>> https://cwiki.apache.org/confluence/display/GEODE/Lightweight+RFC+Process
>>
>> On Wed, Oct 30, 2019 at 5:54 PM Udo Kohlmeyer <ud...@apache.com> wrote:
>>
>>> Hi there fellow Apache Geode Devs,
>>>
>>> We would like to propose the upgrade of the Spring libraries within
>>> Geode Project.
>>>
>>> Currently the project is using Spring 4, which is EOL Q1 2020.
>>>
>>> The link the proposal can be found here
>>> <
>>>
>> https://cwiki.apache.org/confluence/display/GEODE/%5BDiscussion%5D+-+Upgrade+Spring+version+from+Spring+4+to+Spring+5.x
>>> .
>>>
>>>
>>>
>>> Please provide feedback on this proposal as comments on the proposal's
>>> comment section within Apache Geode wiki. Feedback will closed on 8
>>> November 2019.
>>>
>>> --Udo
>>>
>>>
>>> [1]
>>>
>>>
>> https://cwiki.apache.org/confluence/display/GEODE/%5BDiscussion%5D+-+Upgrade+Spring+version+from+Spring+4+to+Spring+5.x
>>>
>> --
>> Ju@N
>>
Re: [DISCUSS] - Upgrading from Spring 4 to Spring 5
Posted by Nabarun Nag <nn...@apache.org>.
Hi Udo
+1,
5.2.0.RELEASE to be specific?
On Wed, Oct 30, 2019 at 11:04 AM Ju@N <ju...@gmail.com> wrote:
> Hello Udo,
>
> Big +1 for the proposal!.
> That said, I believe it was agreed a couple of months ago in the
> *Lightweight
> RFC Process [1] *that the whole discussion should be done in the [DISCUSS]
> email thread directly and not as comments within the proposal itself, you
> might want to double check that and reply to the thread so the entire
> discussion remains in one single place.
> Cheers.
>
> [1]:
> https://cwiki.apache.org/confluence/display/GEODE/Lightweight+RFC+Process
>
> On Wed, Oct 30, 2019 at 5:54 PM Udo Kohlmeyer <ud...@apache.com> wrote:
>
> > Hi there fellow Apache Geode Devs,
> >
> > We would like to propose the upgrade of the Spring libraries within
> > Geode Project.
> >
> > Currently the project is using Spring 4, which is EOL Q1 2020.
> >
> > The link the proposal can be found here
> > <
> >
> https://cwiki.apache.org/confluence/display/GEODE/%5BDiscussion%5D+-+Upgrade+Spring+version+from+Spring+4+to+Spring+5.x
> >.
> >
> >
> >
> > Please provide feedback on this proposal as comments on the proposal's
> > comment section within Apache Geode wiki. Feedback will closed on 8
> > November 2019.
> >
> > --Udo
> >
> >
> > [1]
> >
> >
> https://cwiki.apache.org/confluence/display/GEODE/%5BDiscussion%5D+-+Upgrade+Spring+version+from+Spring+4+to+Spring+5.x
> >
> >
>
> --
> Ju@N
>
Re: [DISCUSS] - Upgrading from Spring 4 to Spring 5
Posted by "Ju@N" <ju...@gmail.com>.
Hello Udo,
Big +1 for the proposal!.
That said, I believe it was agreed a couple of months ago in the *Lightweight
RFC Process [1] *that the whole discussion should be done in the [DISCUSS]
email thread directly and not as comments within the proposal itself, you
might want to double check that and reply to the thread so the entire
discussion remains in one single place.
Cheers.
[1]:
https://cwiki.apache.org/confluence/display/GEODE/Lightweight+RFC+Process
On Wed, Oct 30, 2019 at 5:54 PM Udo Kohlmeyer <ud...@apache.com> wrote:
> Hi there fellow Apache Geode Devs,
>
> We would like to propose the upgrade of the Spring libraries within
> Geode Project.
>
> Currently the project is using Spring 4, which is EOL Q1 2020.
>
> The link the proposal can be found here
> <
> https://cwiki.apache.org/confluence/display/GEODE/%5BDiscussion%5D+-+Upgrade+Spring+version+from+Spring+4+to+Spring+5.x>.
>
>
>
> Please provide feedback on this proposal as comments on the proposal's
> comment section within Apache Geode wiki. Feedback will closed on 8
> November 2019.
>
> --Udo
>
>
> [1]
>
> https://cwiki.apache.org/confluence/display/GEODE/%5BDiscussion%5D+-+Upgrade+Spring+version+from+Spring+4+to+Spring+5.x
>
>
--
Ju@N