You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/10/06 17:38:03 UTC
[GitHub] [airflow] potiuk opened a new pull request #11314: Moves Commiter's guide to CONTRIBUTING.rst
potiuk opened a new pull request #11314:
URL: https://github.com/apache/airflow/pull/11314
I decided to move it to CONTRIBUTING.rst as is it is an important
documentation on what policies we have agreed to as community and
also it is a great resource for the contributor to learn what are
the committer's responsibilities.
Fixes: #10181
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/master/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/master/UPDATING.md).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on a change in pull request #11314: Moves Commiter's guide to CONTRIBUTING.rst
Posted by GitBox <gi...@apache.org>.
ashb commented on a change in pull request #11314:
URL: https://github.com/apache/airflow/pull/11314#discussion_r500981601
##########
File path: CONTRIBUTING.rst
##########
@@ -1153,6 +1153,32 @@ Here are a few rules that are important to keep in mind when you enter our commu
* It’s OK to express your own emotions while communicating - it helps other people to understand you
* Be considerate for feelings of others. Tell about how you feel not what you think of others
+Committer Responsibilities
+==========================
+
+Committers are more than contributors. While it's important for committers to maintain standing by
+committing code, their key role is to build and foster a healthy and active community.
+This means that committers should:
+
+* Review PRs in a timely and reliable fashion
+* They should also help to actively whittle down the PR backlog
+* Answer questions (i.e. on the dev list, in PRs, in Github Issues, slack, etc...)
+* Take on core changes/bugs/feature requests
+* Some changes are important enough that a committer needs to ensure it gets done. This is especially
+ the case if no one from the community is taking it on.
+* Improve processes and tooling
+* Refactoring code
+
+Commit Policy
+=============
+
+The following commit policy passed by a vote 8(binding FOR) to 0 against on May 27, 2016 on the dev list:
+
+* Commits need a +1 vote from a committer who is not the author
+* Furthermore, do not +1 or merge a PR that regresses linting or does not pass CI tests.
Review comment:
We often do this when it's only a single job today fails with an obvious transient error, so we should change this process.
Also a +1 is separate from a merge - +1 days I am happy with the approach, but says nothing about test results. Again we all do this all the time.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #11314: Moves Commiter's guide to CONTRIBUTING.rst
Posted by GitBox <gi...@apache.org>.
potiuk merged pull request #11314:
URL: https://github.com/apache/airflow/pull/11314
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on a change in pull request #11314: Moves Commiter's guide to CONTRIBUTING.rst
Posted by GitBox <gi...@apache.org>.
potiuk commented on a change in pull request #11314:
URL: https://github.com/apache/airflow/pull/11314#discussion_r501101932
##########
File path: CONTRIBUTING.rst
##########
@@ -1153,6 +1153,32 @@ Here are a few rules that are important to keep in mind when you enter our commu
* It’s OK to express your own emotions while communicating - it helps other people to understand you
* Be considerate for feelings of others. Tell about how you feel not what you think of others
+Committer Responsibilities
+==========================
+
+Committers are more than contributors. While it's important for committers to maintain standing by
+committing code, their key role is to build and foster a healthy and active community.
+This means that committers should:
+
+* Review PRs in a timely and reliable fashion
+* They should also help to actively whittle down the PR backlog
+* Answer questions (i.e. on the dev list, in PRs, in Github Issues, slack, etc...)
+* Take on core changes/bugs/feature requests
+* Some changes are important enough that a committer needs to ensure it gets done. This is especially
+ the case if no one from the community is taking it on.
+* Improve processes and tooling
+* Refactoring code
+
+Commit Policy
+=============
+
+The following commit policy passed by a vote 8(binding FOR) to 0 against on May 27, 2016 on the dev list:
+
+* Commits need a +1 vote from a committer who is not the author
+* Furthermore, do not +1 or merge a PR that regresses linting or does not pass CI tests.
Review comment:
Agree. Just copied it from 2016. I am happy to change it to "Raality". I assume we do not have to vote on it since we are all doing it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org