[jira] [Commented] (AIRFLOW-2861) Need index on log table

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AIRFLOW-2861?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16570098#comment-16570098 ] 

ASF GitHub Bot commented on AIRFLOW-2861:
-----------------------------------------

vardancse opened a new pull request #3709: [AIRFLOW-2861][Improvement] Added index on log table, will make delete dag optimized
URL: https://github.com/apache/incubator-airflow/pull/3709
 
 
   
   
   Make sure you have checked _all_ steps below.
   
   ### Jira
   
   - [ ] My PR addresses the following [Airflow Jira](https://issues.apache.org/jira/browse/AIRFLOW/) issues and references them in the PR title. For example, "\[AIRFLOW-XXX\] My Airflow PR"
     - https://issues.apache.org/jira/browse/AIRFLOW-2861
     - In case you are fixing a typo in the documentation you can prepend your commit with \[AIRFLOW-XXX\], code changes always need a Jira issue.
   
   ### Description
   
   - [ ] Here are some details about my PR, including screenshots of any UI changes:
   Delete dag functionality is added in v1-10-stable, whose implementation during the metadata cleanup part, look for classes which has attribute named as dag_id and then formulate the query on matching model and then delete from metadata, we've few numbers where we've observed slowness especially in log table because it doesn't have any single or multiple-column index. Creating an index would boost the performance though insertion will be a bit slower. Since deletion will be a sync call, would be good idea to create index.
   
   ### Tests
   
   - [ ] My PR adds the following unit tests __OR__ does not need testing for this extremely good reason:
   
   ### Commits
   
   - [ ] My commits all reference Jira issues in their subject lines, and I have squashed multiple commits if they address the same issue. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
     1. Subject is separated from body by a blank line
     1. Subject is limited to 50 characters (not including Jira issue reference)
     1. Subject does not end with a period
     1. Subject uses the imperative mood ("add", not "adding")
     1. Body wraps at 72 characters
     1. Body explains "what" and "why", not "how"
   
   ### Documentation
   
   - [ ] In case of new functionality, my PR adds documentation that describes how to use it.
     - When adding new operators/hooks/sensors, the autoclass documentation generation needs to be added.
   
   ### Code Quality
   
   - [ ] Passes `git diff upstream/master -u -- "*.py" | flake8 --diff`
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Need index on log table
> -----------------------
>
>                 Key: AIRFLOW-2861
>                 URL: https://issues.apache.org/jira/browse/AIRFLOW-2861
>             Project: Apache Airflow
>          Issue Type: Improvement
>          Components: database
>    Affects Versions: 1.10.0
>            Reporter: Vardan Gupta
>            Assignee: Vardan Gupta
>            Priority: Major
>
> Delete dag functionality is added in v1-10-stable, whose implementation during the metadata cleanup [part|https://github.com/apache/incubator-airflow/blob/dc78b9196723ca6724185231ccd6f5bbe8edcaf3/airflow/api/common/experimental/delete_dag.py#L48], look for classes which has attribute named as dag_id and then formulate the query on matching model and then delete from metadata, we've few numbers where we've observed slowness especially in log table because it doesn't have any single or multiple-column index. Creating an index would boost the performance though insertion will be a bit slower. Since deletion will be a sync call, would be good idea to create index.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)