[GitHub] [storm] Crim commented on a change in pull request #3314: [STORM-3680] Upgrade Jedis Library

[GitBox <gi...@apache.org>]

Crim commented on a change in pull request #3314:
URL: https://github.com/apache/storm/pull/3314#discussion_r460467568



##########
File path: external/storm-redis/src/main/java/org/apache/storm/redis/common/container/JedisCommandsContainer.java
##########
@@ -12,24 +12,51 @@
 
 package org.apache.storm.redis.common.container;
 
+import redis.clients.jedis.GeoCoordinate;
+
 import java.io.Closeable;
-import redis.clients.jedis.JedisCommands;
+import java.util.List;
+
 
 /**
  * Interfaces for containers which stores instances implementing JedisCommands.
  */
-public interface JedisCommandsInstanceContainer extends Closeable {
-    /**
-     * Borrows instance from container.
-     * @return instance which implements JedisCommands
-     */
-    JedisCommands getInstance();
+public interface JedisCommandsContainer extends Closeable {

Review comment:
       Likely `JedisCommandsAdapter` is a better name here as we are providing a single unified interface ontop of both `JedisPool` and `JedisCluster` as Jedis removed the `JedisCommands` interface from covering both.  See https://github.com/xetorthio/jedis/pull/1932 for more details on why this required




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org