You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@storm.apache.org by haohui <gi...@git.apache.org> on 2016/01/07 03:05:31 UTC
[GitHub] storm pull request: STORM-1404. Mockito test failures in storm-kaf...
GitHub user haohui opened a pull request:
https://github.com/apache/storm/pull/993
STORM-1404. Mockito test failures in storm-kafka.
This PR fixes the failed test reported in STORM-1404. It replaces the unreliable `Thread.sleep()` with comprehensive mocking to make sure the tests are reliable.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/haohui/storm STORM-1404
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/storm/pull/993.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #993
----
commit de90b185c4976522562dc6f161ed88dbedd2a0fa
Author: Haohui Mai <wh...@apache.org>
Date: 2016-01-07T02:04:13Z
STORM-1404. Mockito test failures in storm-kafka.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1404. Mockito test failures in storm-kaf...
Posted by haohui <gi...@git.apache.org>.
Github user haohui commented on the pull request:
https://github.com/apache/storm/pull/993#issuecomment-170099926
The test passed locally. Committing.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1404. Mockito test failures in storm-kaf...
Posted by harshach <gi...@git.apache.org>.
Github user harshach commented on the pull request:
https://github.com/apache/storm/pull/993#issuecomment-169539886
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1404. Mockito test failures in storm-kaf...
Posted by haohui <gi...@git.apache.org>.
Github user haohui commented on the pull request:
https://github.com/apache/storm/pull/993#issuecomment-170101211
Merged in 1f1ba77be849e50cdc09fcfe08dcec8f4984b4f9
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] storm pull request: STORM-1404. Mockito test failures in storm-kaf...
Posted by haohui <gi...@git.apache.org>.
Github user haohui closed the pull request at:
https://github.com/apache/storm/pull/993
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---