You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by "jmjoy (via GitHub)" <gi...@apache.org> on 2023/03/15 02:41:59 UTC

[GitHub] [skywalking] jmjoy opened a new issue, #10539: [Feature] [Eyes] Add option `--summary` for `license-eye dependency check`.

jmjoy opened a new issue, #10539:
URL: https://github.com/apache/skywalking/issues/10539

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/skywalking/issues?q=is%3Aissue) and found no similar feature requirement.
   
   
   ### Description
   
   Now command `license-eye dependency resolve` support `--summary` option, which will generate the summary license file, but command `license-eye dependency check` not.
   
   But in CI, the summary license file also need to be checked, the current method is to compare the generated license file from `resolve` with the original one, if `check` supports `--summary`, that would be much more convenient.
   
   ### Use case
   
   Github action `apache/skywalking-eyes/dependency` supports check the summary license file.
   
   ### Related issues
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [X] Yes I am willing to submit a PR!
   
   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of Conduct](https://www.apache.org/foundation/policies/conduct)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] jmjoy closed issue #10539: [Feature] [Eyes] Add option `--summary` for `license-eye dependency check`.

Posted by "jmjoy (via GitHub)" <gi...@apache.org>.
jmjoy closed issue #10539: [Feature] [Eyes] Add option `--summary` for `license-eye dependency check`.
URL: https://github.com/apache/skywalking/issues/10539


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] jmjoy commented on issue #10539: [Feature] [Eyes] Add option `--summary` for `license-eye dependency check`.

Posted by "jmjoy (via GitHub)" <gi...@apache.org>.
jmjoy commented on issue #10539:
URL: https://github.com/apache/skywalking/issues/10539#issuecomment-1469248012

   @kezhenxu94 How about the idea?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [skywalking] kezhenxu94 commented on issue #10539: [Feature] [Eyes] Add option `--summary` for `license-eye dependency check`.

Posted by "kezhenxu94 (via GitHub)" <gi...@apache.org>.
kezhenxu94 commented on issue #10539:
URL: https://github.com/apache/skywalking/issues/10539#issuecomment-1469322537

   `check` is to check incompatible licenses, adding `--summary` to `check` command sounds like "the summary of incompatible licenses", if you wan to check the summary file, consider adding an option to `resolve` command like `--exit-code` , if the summary file changes after resolve command, set the exit code 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org