[GitHub] [inlong] healchow commented on a diff in pull request #7808: [INLONG-7783][Agent] Support sink data tor Kafka

["healchow (via GitHub)" <gi...@apache.org>]

healchow commented on code in PR #7808:
URL: https://github.com/apache/inlong/pull/7808#discussion_r1161645152


##########
inlong-agent/agent-common/src/main/java/org/apache/inlong/agent/constant/AgentConstants.java:
##########
@@ -171,12 +171,26 @@ public class AgentConstants {
     public static final String DEFAULT_COMPRESSION_TYPE = "NONE";
 
     public static final String PULSAR_CLIENT_PRODUCER_NUM = "agent.sink.pulsar.producer.num";
+    public static final String KAFKA_SINK_PRODUCER_NUM = "agent.sink.kafka.producer.num";

Review Comment:
   Suggested naming it like Pulsar, for example:
   
   ```suggestion
       public static final String KAFKA_CLIENT_PRODUCER_NUM = "agent.sink.kafka.producer.num";
   ```



##########
inlong-agent/agent-common/src/main/java/org/apache/inlong/agent/constant/AgentConstants.java:
##########
@@ -171,12 +171,26 @@ public class AgentConstants {
     public static final String DEFAULT_COMPRESSION_TYPE = "NONE";
 
     public static final String PULSAR_CLIENT_PRODUCER_NUM = "agent.sink.pulsar.producer.num";
+    public static final String KAFKA_SINK_PRODUCER_NUM = "agent.sink.kafka.producer.num";
     public static final int DEFAULT_PRODUCER_NUM = 3;
 
     public static final String PULSAR_CLIENT_ENABLE_ASYNC_SEND = "agent.sink.pulsar.enbale.async.send";
+    public static final String KAFKA_PRODUCER_ENABLE_ASYNC_SEND = "agent.sink.kafka.enbale.async.send";

Review Comment:
   ditto.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org