You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@maven.apache.org by ca...@apache.org on 2005/06/07 21:09:05 UTC
svn commit: r188845 - in /maven/maven-1/plugins/trunk/checkstyle:
plugin.jelly project.xml xdocs/changes.xml
Author: carlos
Date: Tue Jun 7 12:09:03 2005
New Revision: 188845
URL: http://svn.apache.org/viewcvs?rev=188845&view=rev
Log:
Removed deprecated use of root classloader
Modified:
maven/maven-1/plugins/trunk/checkstyle/plugin.jelly
maven/maven-1/plugins/trunk/checkstyle/project.xml
maven/maven-1/plugins/trunk/checkstyle/xdocs/changes.xml
Modified: maven/maven-1/plugins/trunk/checkstyle/plugin.jelly
URL: http://svn.apache.org/viewcvs/maven/maven-1/plugins/trunk/checkstyle/plugin.jelly?rev=188845&r1=188844&r2=188845&view=diff
==============================================================================
--- maven/maven-1/plugins/trunk/checkstyle/plugin.jelly (original)
+++ maven/maven-1/plugins/trunk/checkstyle/plugin.jelly Tue Jun 7 12:09:03 2005
@@ -71,8 +71,7 @@
</j:otherwise>
</j:choose>
- <ant:taskdef name="checkstyle"
- classname="com.puppycrawl.tools.checkstyle.CheckStyleTask">
+ <ant:taskdef resource="checkstyletask.properties">
<ant:classpath>
<ant:pathelement location="${plugin.getDependencyPath('checkstyle:checkstyle')}"/>
<ant:pathelement location="${plugin.getDependencyPath('checkstyle:checkstyle-optional')}"/>
Modified: maven/maven-1/plugins/trunk/checkstyle/project.xml
URL: http://svn.apache.org/viewcvs/maven/maven-1/plugins/trunk/checkstyle/project.xml?rev=188845&r1=188844&r2=188845&view=diff
==============================================================================
--- maven/maven-1/plugins/trunk/checkstyle/project.xml (original)
+++ maven/maven-1/plugins/trunk/checkstyle/project.xml Tue Jun 7 12:09:03 2005
@@ -140,41 +140,26 @@
<groupId>antlr</groupId>
<artifactId>antlr</artifactId>
<version>2.7.5</version>
- <properties>
- <classloader>root</classloader>
- </properties>
</dependency>
<dependency>
<groupId>checkstyle</groupId>
<artifactId>checkstyle</artifactId>
<version>4.0-beta1</version>
- <properties>
- <classloader>root</classloader>
- </properties>
</dependency>
<dependency>
<groupId>checkstyle</groupId>
<artifactId>checkstyle-optional</artifactId>
<version>4.0-beta1</version>
- <properties>
- <classloader>root</classloader>
- </properties>
</dependency>
<dependency>
<groupId>regexp</groupId>
<artifactId>regexp</artifactId>
<version>1.3</version>
- <properties>
- <classloader>root</classloader>
- </properties>
</dependency>
<dependency>
<groupId>commons-beanutils</groupId>
<artifactId>commons-beanutils-core</artifactId>
<version>1.7.0</version>
- <properties>
- <classloader>root</classloader>
- </properties>
</dependency>
</dependencies>
</project>
Modified: maven/maven-1/plugins/trunk/checkstyle/xdocs/changes.xml
URL: http://svn.apache.org/viewcvs/maven/maven-1/plugins/trunk/checkstyle/xdocs/changes.xml?rev=188845&r1=188844&r2=188845&view=diff
==============================================================================
--- maven/maven-1/plugins/trunk/checkstyle/xdocs/changes.xml (original)
+++ maven/maven-1/plugins/trunk/checkstyle/xdocs/changes.xml Tue Jun 7 12:09:03 2005
@@ -26,7 +26,9 @@
</properties>
<body>
<release version="3.0-SNAPSHOT" date="in CVS">
+ <action dev="carlos" type="update">Support for Java5</action>
<action dev="carlos" type="update">Upgraded to checkstyle 4.0beta1</action>
+ <action dev="carlos" type="fix">Remove deprecated use of root classloader</action>
</release>
<release version="2.5" date="2004-10-12">
<action dev="vmassol" type="add">Added new
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r188845 - in /maven/maven-1/plugins/trunk/checkstyle:
plugin.jelly project.xml xdocs/changes.xml
Posted by Brett Porter <br...@apache.org>.
Nope... that's why I reverted back. I know I deprecated the
classloaders, but it seems they remain essential in some cases without
completely reworking m1's internals, which ain't gonna happen :)
- Brett
Carlos Sanchez wrote:
>Hi Brett,
>
>Maybe you were right :(
>
>I'm getting
>
>Can't find/access AST Node typecom.puppycrawl.tools.checkstyle.api.DetailAST
>
>seems that for each source file, but the curious thing is that only
>after running another goal like java:compile or site, not when running
>checkstyle alone or after clean.
>
>Any idea?
>
>TIA
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r188845 - in /maven/maven-1/plugins/trunk/checkstyle: plugin.jelly project.xml xdocs/changes.xml
Posted by Carlos Sanchez <ca...@gmail.com>.
Hi Brett,
Maybe you were right :(
I'm getting
Can't find/access AST Node typecom.puppycrawl.tools.checkstyle.api.DetailAST
seems that for each source file, but the curious thing is that only
after running another goal like java:compile or site, not when running
checkstyle alone or after clean.
Any idea?
TIA
On 6/7/05, Brett Porter <br...@apache.org> wrote:
>
> cool, thanks.
>
> Carlos Sanchez wrote:
>
> >It's working for me with 1.0.2
> >
> >Cheers
> >
> >Carlos
> >
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r188845 - in /maven/maven-1/plugins/trunk/checkstyle:
plugin.jelly project.xml xdocs/changes.xml
Posted by Brett Porter <br...@apache.org>.
cool, thanks.
Carlos Sanchez wrote:
>It's working for me with 1.0.2
>
>Cheers
>
>Carlos
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r188845 - in /maven/maven-1/plugins/trunk/checkstyle: plugin.jelly project.xml xdocs/changes.xml
Posted by Carlos Sanchez <ca...@gmail.com>.
It's working for me with 1.0.2
Cheers
Carlos
On 6/7/05, Brett Porter <br...@apache.org> wrote:
> Does this work? I think I tried it, and I got some failures. Maybe it
> worked under 1.1 and not 1.0, or vice versa.
>
> - Brett
>
> carlos@apache.org wrote:
>
> >Author: carlos
> >Date: Tue Jun 7 12:09:03 2005
> >New Revision: 188845
> >
> >URL: http://svn.apache.org/viewcvs?rev=188845&view=rev
> >Log:
> >Removed deprecated use of root classloader
> >
> >Modified:
> > maven/maven-1/plugins/trunk/checkstyle/plugin.jelly
> > maven/maven-1/plugins/trunk/checkstyle/project.xml
> > maven/maven-1/plugins/trunk/checkstyle/xdocs/changes.xml
> >
> >Modified: maven/maven-1/plugins/trunk/checkstyle/plugin.jelly
> >URL: http://svn.apache.org/viewcvs/maven/maven-1/plugins/trunk/checkstyle/plugin.jelly?rev=188845&r1=188844&r2=188845&view=diff
> >==============================================================================
> >--- maven/maven-1/plugins/trunk/checkstyle/plugin.jelly (original)
> >+++ maven/maven-1/plugins/trunk/checkstyle/plugin.jelly Tue Jun 7 12:09:03 2005
> >@@ -71,8 +71,7 @@
> > </j:otherwise>
> > </j:choose>
> >
> >- <ant:taskdef name="checkstyle"
> >- classname="com.puppycrawl.tools.checkstyle.CheckStyleTask">
> >+ <ant:taskdef resource="checkstyletask.properties">
> > <ant:classpath>
> > <ant:pathelement location="${plugin.getDependencyPath('checkstyle:checkstyle')}"/>
> > <ant:pathelement location="${plugin.getDependencyPath('checkstyle:checkstyle-optional')}"/>
> >
> >Modified: maven/maven-1/plugins/trunk/checkstyle/project.xml
> >URL: http://svn.apache.org/viewcvs/maven/maven-1/plugins/trunk/checkstyle/project.xml?rev=188845&r1=188844&r2=188845&view=diff
> >==============================================================================
> >--- maven/maven-1/plugins/trunk/checkstyle/project.xml (original)
> >+++ maven/maven-1/plugins/trunk/checkstyle/project.xml Tue Jun 7 12:09:03 2005
> >@@ -140,41 +140,26 @@
> > <groupId>antlr</groupId>
> > <artifactId>antlr</artifactId>
> > <version>2.7.5</version>
> >- <properties>
> >- <classloader>root</classloader>
> >- </properties>
> > </dependency>
> > <dependency>
> > <groupId>checkstyle</groupId>
> > <artifactId>checkstyle</artifactId>
> > <version>4.0-beta1</version>
> >- <properties>
> >- <classloader>root</classloader>
> >- </properties>
> > </dependency>
> > <dependency>
> > <groupId>checkstyle</groupId>
> > <artifactId>checkstyle-optional</artifactId>
> > <version>4.0-beta1</version>
> >- <properties>
> >- <classloader>root</classloader>
> >- </properties>
> > </dependency>
> > <dependency>
> > <groupId>regexp</groupId>
> > <artifactId>regexp</artifactId>
> > <version>1.3</version>
> >- <properties>
> >- <classloader>root</classloader>
> >- </properties>
> > </dependency>
> > <dependency>
> > <groupId>commons-beanutils</groupId>
> > <artifactId>commons-beanutils-core</artifactId>
> > <version>1.7.0</version>
> >- <properties>
> >- <classloader>root</classloader>
> >- </properties>
> > </dependency>
> > </dependencies>
> > </project>
> >
> >Modified: maven/maven-1/plugins/trunk/checkstyle/xdocs/changes.xml
> >URL: http://svn.apache.org/viewcvs/maven/maven-1/plugins/trunk/checkstyle/xdocs/changes.xml?rev=188845&r1=188844&r2=188845&view=diff
> >==============================================================================
> >--- maven/maven-1/plugins/trunk/checkstyle/xdocs/changes.xml (original)
> >+++ maven/maven-1/plugins/trunk/checkstyle/xdocs/changes.xml Tue Jun 7 12:09:03 2005
> >@@ -26,7 +26,9 @@
> > </properties>
> > <body>
> > <release version="3.0-SNAPSHOT" date="in CVS">
> >+ <action dev="carlos" type="update">Support for Java5</action>
> > <action dev="carlos" type="update">Upgraded to checkstyle 4.0beta1</action>
> >+ <action dev="carlos" type="fix">Remove deprecated use of root classloader</action>
> > </release>
> > <release version="2.5" date="2004-10-12">
> > <action dev="vmassol" type="add">Added new
> >
> >
> >
> >---------------------------------------------------------------------
> >To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> >For additional commands, e-mail: dev-help@maven.apache.org
> >
> >
> >
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
> For additional commands, e-mail: dev-help@maven.apache.org
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org
Re: svn commit: r188845 - in /maven/maven-1/plugins/trunk/checkstyle:
plugin.jelly project.xml xdocs/changes.xml
Posted by Brett Porter <br...@apache.org>.
Does this work? I think I tried it, and I got some failures. Maybe it
worked under 1.1 and not 1.0, or vice versa.
- Brett
carlos@apache.org wrote:
>Author: carlos
>Date: Tue Jun 7 12:09:03 2005
>New Revision: 188845
>
>URL: http://svn.apache.org/viewcvs?rev=188845&view=rev
>Log:
>Removed deprecated use of root classloader
>
>Modified:
> maven/maven-1/plugins/trunk/checkstyle/plugin.jelly
> maven/maven-1/plugins/trunk/checkstyle/project.xml
> maven/maven-1/plugins/trunk/checkstyle/xdocs/changes.xml
>
>Modified: maven/maven-1/plugins/trunk/checkstyle/plugin.jelly
>URL: http://svn.apache.org/viewcvs/maven/maven-1/plugins/trunk/checkstyle/plugin.jelly?rev=188845&r1=188844&r2=188845&view=diff
>==============================================================================
>--- maven/maven-1/plugins/trunk/checkstyle/plugin.jelly (original)
>+++ maven/maven-1/plugins/trunk/checkstyle/plugin.jelly Tue Jun 7 12:09:03 2005
>@@ -71,8 +71,7 @@
> </j:otherwise>
> </j:choose>
>
>- <ant:taskdef name="checkstyle"
>- classname="com.puppycrawl.tools.checkstyle.CheckStyleTask">
>+ <ant:taskdef resource="checkstyletask.properties">
> <ant:classpath>
> <ant:pathelement location="${plugin.getDependencyPath('checkstyle:checkstyle')}"/>
> <ant:pathelement location="${plugin.getDependencyPath('checkstyle:checkstyle-optional')}"/>
>
>Modified: maven/maven-1/plugins/trunk/checkstyle/project.xml
>URL: http://svn.apache.org/viewcvs/maven/maven-1/plugins/trunk/checkstyle/project.xml?rev=188845&r1=188844&r2=188845&view=diff
>==============================================================================
>--- maven/maven-1/plugins/trunk/checkstyle/project.xml (original)
>+++ maven/maven-1/plugins/trunk/checkstyle/project.xml Tue Jun 7 12:09:03 2005
>@@ -140,41 +140,26 @@
> <groupId>antlr</groupId>
> <artifactId>antlr</artifactId>
> <version>2.7.5</version>
>- <properties>
>- <classloader>root</classloader>
>- </properties>
> </dependency>
> <dependency>
> <groupId>checkstyle</groupId>
> <artifactId>checkstyle</artifactId>
> <version>4.0-beta1</version>
>- <properties>
>- <classloader>root</classloader>
>- </properties>
> </dependency>
> <dependency>
> <groupId>checkstyle</groupId>
> <artifactId>checkstyle-optional</artifactId>
> <version>4.0-beta1</version>
>- <properties>
>- <classloader>root</classloader>
>- </properties>
> </dependency>
> <dependency>
> <groupId>regexp</groupId>
> <artifactId>regexp</artifactId>
> <version>1.3</version>
>- <properties>
>- <classloader>root</classloader>
>- </properties>
> </dependency>
> <dependency>
> <groupId>commons-beanutils</groupId>
> <artifactId>commons-beanutils-core</artifactId>
> <version>1.7.0</version>
>- <properties>
>- <classloader>root</classloader>
>- </properties>
> </dependency>
> </dependencies>
> </project>
>
>Modified: maven/maven-1/plugins/trunk/checkstyle/xdocs/changes.xml
>URL: http://svn.apache.org/viewcvs/maven/maven-1/plugins/trunk/checkstyle/xdocs/changes.xml?rev=188845&r1=188844&r2=188845&view=diff
>==============================================================================
>--- maven/maven-1/plugins/trunk/checkstyle/xdocs/changes.xml (original)
>+++ maven/maven-1/plugins/trunk/checkstyle/xdocs/changes.xml Tue Jun 7 12:09:03 2005
>@@ -26,7 +26,9 @@
> </properties>
> <body>
> <release version="3.0-SNAPSHOT" date="in CVS">
>+ <action dev="carlos" type="update">Support for Java5</action>
> <action dev="carlos" type="update">Upgraded to checkstyle 4.0beta1</action>
>+ <action dev="carlos" type="fix">Remove deprecated use of root classloader</action>
> </release>
> <release version="2.5" date="2004-10-12">
> <action dev="vmassol" type="add">Added new
>
>
>
>---------------------------------------------------------------------
>To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
>For additional commands, e-mail: dev-help@maven.apache.org
>
>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@maven.apache.org
For additional commands, e-mail: dev-help@maven.apache.org