You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/02/22 05:51:20 UTC
[GitHub] [spark] Karl-WangSK opened a new pull request #31608: [MINOR][DOCS] Add table_identifier in sql-migration-guide
Karl-WangSK opened a new pull request #31608:
URL: https://github.com/apache/spark/pull/31608
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
add `table_identifier` in sql-migration-guide.md
### Why are the changes needed?
fix doc
### Does this PR introduce _any_ user-facing change?
no
### How was this patch tested?
Manual test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31608: [MINOR][DOCS] Add table_identifier in sql-migration-guide
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31608:
URL: https://github.com/apache/spark/pull/31608#issuecomment-783156147
**[Test build #135336 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135336/testReport)** for PR 31608 at commit [`7dcd44f`](https://github.com/apache/spark/commit/7dcd44f0abb59a61fa22554cfa525d4a9e3c0047).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31608: [MINOR][DOCS] Add table_identifier in sql-migration-guide for SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31608:
URL: https://github.com/apache/spark/pull/31608#issuecomment-783156378
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135336/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on a change in pull request #31608: [MINOR][DOCS] Add table_identifier in sql-migration-guide
Posted by GitBox <gi...@apache.org>.
wangyum commented on a change in pull request #31608:
URL: https://github.com/apache/spark/pull/31608#discussion_r580018130
##########
File path: docs/sql-migration-guide.md
##########
@@ -89,7 +89,7 @@ license: |
- In Spark 3.0, `SHOW TBLPROPERTIES` throws `AnalysisException` if the table does not exist. In Spark version 2.4 and below, this scenario caused `NoSuchTableException`.
- - In Spark 3.0, `SHOW CREATE TABLE` always returns Spark DDL, even when the given table is a Hive SerDe table. For generating Hive DDL, use `SHOW CREATE TABLE AS SERDE` command instead.
+ - In Spark 3.0, `SHOW CREATE TABLE table_identifier` always returns Spark DDL, even when the given table is a Hive SerDe table. For generating Hive DDL, use `SHOW CREATE TABLE table_identifier AS SERDE` command instead.
Review comment:
+1. Otherwise, users will be confused whether it is `SHOW CREATE TABLE AS SERDE table_identifier` or `SHOW CREATE TABLE table_identifier AS SERDE`.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31608: [MINOR][DOCS] Add table_identifier in sql-migration-guide
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31608:
URL: https://github.com/apache/spark/pull/31608#issuecomment-783116314
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum closed pull request #31608: [MINOR][DOCS] Add table_identifier in sql-migration-guide for SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
wangyum closed pull request #31608:
URL: https://github.com/apache/spark/pull/31608
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #31608: [MINOR][DOCS] Add table_identifier in sql-migration-guide for SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #31608:
URL: https://github.com/apache/spark/pull/31608#issuecomment-783333845
Merged to master, branch-3.1 and branch-3.0.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31608: [MINOR][DOCS] Add table_identifier in sql-migration-guide for SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31608:
URL: https://github.com/apache/spark/pull/31608#issuecomment-783223050
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39916/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31608: [MINOR][DOCS] Add table_identifier in sql-migration-guide for SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31608:
URL: https://github.com/apache/spark/pull/31608#issuecomment-783223050
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/39916/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] wangyum commented on pull request #31608: [MINOR][DOCS] Add table_identifier in sql-migration-guide
Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #31608:
URL: https://github.com/apache/spark/pull/31608#issuecomment-783138283
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #31608: [MINOR][DOCS] Add table_identifier in sql-migration-guide
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #31608:
URL: https://github.com/apache/spark/pull/31608#issuecomment-783149101
**[Test build #135336 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135336/testReport)** for PR 31608 at commit [`7dcd44f`](https://github.com/apache/spark/commit/7dcd44f0abb59a61fa22554cfa525d4a9e3c0047).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31608: [MINOR][DOCS] Add table_identifier in sql-migration-guide for SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31608:
URL: https://github.com/apache/spark/pull/31608#issuecomment-783183556
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39916/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #31608: [MINOR][DOCS] Add table_identifier in sql-migration-guide
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #31608:
URL: https://github.com/apache/spark/pull/31608#issuecomment-783116314
Can one of the admins verify this patch?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31608: [MINOR][DOCS] Add table_identifier in sql-migration-guide
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31608:
URL: https://github.com/apache/spark/pull/31608#issuecomment-783149101
**[Test build #135336 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/135336/testReport)** for PR 31608 at commit [`7dcd44f`](https://github.com/apache/spark/commit/7dcd44f0abb59a61fa22554cfa525d4a9e3c0047).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #31608: [MINOR][DOCS] Add table_identifier in sql-migration-guide
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #31608:
URL: https://github.com/apache/spark/pull/31608#issuecomment-783156378
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/135336/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #31608: [MINOR][DOCS] Add table_identifier in sql-migration-guide for SHOW CREATE TABLE
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #31608:
URL: https://github.com/apache/spark/pull/31608#issuecomment-783209378
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/39916/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org