[GitHub] [arrow-rs] alamb commented on a diff in pull request #3845: Add timezone support to JSON reader

["alamb (via GitHub)" <gi...@apache.org>]

alamb commented on code in PR #3845:
URL: https://github.com/apache/arrow-rs/pull/3845#discussion_r1140290622


##########
arrow-array/src/types.rs:
##########
@@ -287,30 +287,28 @@ impl ArrowTemporalType for DurationMicrosecondType {}
 impl ArrowTemporalType for DurationNanosecondType {}
 
 /// A timestamp type allows us to create array builders that take a timestamp.
-pub trait ArrowTimestampType: ArrowTemporalType {
+pub trait ArrowTimestampType: ArrowTemporalType<Native = i64> {

Review Comment:
   I don't understand how these are sealed -- https://docs.rs/arrow/35.0.0/arrow/datatypes/trait.ArrowTimestampType.html
   
   Maybe we should add a doc commen note here explaining that they are sealed 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org