[GitHub] [helix] somecodemonkey commented on a diff in pull request #2276: trim mapFields strings to resolve prefix space issue

[GitBox <gi...@apache.org>]

somecodemonkey commented on code in PR #2276:
URL: https://github.com/apache/helix/pull/2276#discussion_r1019738122


##########
helix-front/src/app/resource/shared/resource.service.ts:
##########
@@ -81,9 +81,9 @@ export class ResourceService extends HelixService {
           const par = data.mapFields[partition];
 
           ret.partitions.push({
-            name: partition,
-            currentState: par.CURRENT_STATE,
-            info: par.INFO,
+            name: partition.trim(),
+            currentState: par.CURRENT_STATE.trim(),
+            info: par.INFO.trim(),

Review Comment:
   If leading/trailing spaces are invalid can you not capture them through form validation so it is obvious to the user instead of silently altering their input?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org