You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by mccheah <gi...@git.apache.org> on 2018/10/30 22:45:23 UTC

[GitHub] spark pull request #22805: [SPARK-25809][K8S][TEST] New K8S integration test...

Github user mccheah commented on a diff in the pull request:

    https://github.com/apache/spark/pull/22805#discussion_r229512765
  
    --- Diff: resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/SparkKubernetesClientFactory.scala ---
    @@ -63,6 +66,8 @@ private[spark] object SparkKubernetesClientFactory {
           .getOption(s"$kubernetesAuthConfPrefix.$CLIENT_CERT_FILE_CONF_SUFFIX")
         val dispatcher = new Dispatcher(
           ThreadUtils.newDaemonCachedThreadPool("kubernetes-dispatcher"))
    +
    +    // TODO Create builder in a way that respects configurable context
    --- End diff --
    
    Can we add a Spark ticket here?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org