You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by "Jark Wu (JIRA)" <ji...@apache.org> on 2019/07/24 12:27:00 UTC

[jira] [Resolved] (FLINK-13378) Fix SINGLE_VALUE is not correctly supported in blink planner

     [ https://issues.apache.org/jira/browse/FLINK-13378?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jark Wu resolved FLINK-13378.
-----------------------------
    Resolution: Fixed

Fixed in 1.10.0: 759b1d4bcde5d22761caee120f74054c6a4e2325
Fixed in 1.9.0: 353dd8d8087f12fe155537acc8887831cc776c9b

> Fix SINGLE_VALUE is not correctly supported in blink planner
> ------------------------------------------------------------
>
>                 Key: FLINK-13378
>                 URL: https://issues.apache.org/jira/browse/FLINK-13378
>             Project: Flink
>          Issue Type: Bug
>          Components: Table SQL / Planner
>    Affects Versions: 1.9.0, 1.10.0
>            Reporter: Louis Xu
>            Assignee: Jingsong Lee
>            Priority: Blocker
>              Labels: pull-request-available
>             Fix For: 1.9.0, 1.10.0
>
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> There some problem in SingleValueAggFunction:
> 1.The comment in the method is "value = count == 0 ? exception : operand(0)", but actually it need to be "value = count > 0 ? exception : operand(0)" according to the code and logic.
> 2.The throwException expression should call(THROW_EXCEPTION, literal(msg), typeLiteral(type)).
> And there are some bugs to support it in blink-planner:
> 1.RexNodeConverter lack converter for THROW_EXCEPTION
> 2.PlannerExpressions lack expr to support type inference for THROW_EXCEPTION



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)