You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/12/19 10:39:55 UTC
[kudu-CR] Fix flakiness in ToolTest.TestRemoteReplicaCopy
Hello Dinesh Bhat, Mike Percy,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5543
to review the following change.
Change subject: Fix flakiness in ToolTest.TestRemoteReplicaCopy
......................................................................
Fix flakiness in ToolTest.TestRemoteReplicaCopy
This test created a table, and then immediately asserted on the error
message returned when trying to copy a tablet on top of an existing
tablet. In fact, the destination tablet might still be in the 'creating'
transition, in which case the copy attempt failed with an unexpected
error message.
This patch fixes the issue by waiting for the RUNNING state first.
Tested a loop 500x with 4 stress threads in a RELEASE build (where this
seemed to be most flaky according to the dashboard).
Change-Id: I740f6b469561a17792a315caf4a10c2627b55149
---
M src/kudu/tools/kudu-tool-test.cc
1 file changed, 5 insertions(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/43/5543/1
--
To view, visit http://gerrit.cloudera.org:8080/5543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: I740f6b469561a17792a315caf4a10c2627b55149
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] Fix flakiness in ToolTest.TestRemoteReplicaCopy
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has submitted this change and it was merged.
Change subject: Fix flakiness in ToolTest.TestRemoteReplicaCopy
......................................................................
Fix flakiness in ToolTest.TestRemoteReplicaCopy
This test created a table, and then immediately asserted on the error
message returned when trying to copy a tablet on top of an existing
tablet. In fact, the destination tablet might still be in the 'creating'
transition, in which case the copy attempt failed with an unexpected
error message.
This patch fixes the issue by waiting for the RUNNING state first.
Tested a loop 500x with 4 stress threads in a RELEASE build (where this
seemed to be most flaky according to the dashboard).
Change-Id: I740f6b469561a17792a315caf4a10c2627b55149
Reviewed-on: http://gerrit.cloudera.org:8080/5543
Tested-by: Kudu Jenkins
Reviewed-by: Dinesh Bhat <di...@cloudera.com>
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/tools/kudu-tool-test.cc
1 file changed, 5 insertions(+), 1 deletion(-)
Approvals:
Dinesh Bhat: Looks good to me, but someone else must approve
Adar Dembo: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I740f6b469561a17792a315caf4a10c2627b55149
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] Fix flakiness in ToolTest.TestRemoteReplicaCopy
Posted by "Dinesh Bhat (Code Review)" <ge...@cloudera.org>.
Dinesh Bhat has posted comments on this change.
Change subject: Fix flakiness in ToolTest.TestRemoteReplicaCopy
......................................................................
Patch Set 1: Code-Review+1
Thanks Todd for fixing this, ship it from my side.
--
To view, visit http://gerrit.cloudera.org:8080/5543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I740f6b469561a17792a315caf4a10c2627b55149
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No
[kudu-CR] Fix flakiness in ToolTest.TestRemoteReplicaCopy
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: Fix flakiness in ToolTest.TestRemoteReplicaCopy
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5543
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I740f6b469561a17792a315caf4a10c2627b55149
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dinesh Bhat <di...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: No