You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "lvshaokang (via GitHub)" <gi...@apache.org> on 2023/04/22 14:22:50 UTC

[GitHub] [doris] lvshaokang opened a new pull request, #18933: [fix](sequence-column) Fix sequence_col column used default expr insert failed

lvshaokang opened a new pull request, #18933:
URL: https://github.com/apache/doris/pull/18933

   
   # Proposed changes
   
   Issue Number: close #18911 
   
   ## Problem summary
   
   Describe your changes.
   
   ## Checklist(Required)
   
   * [ ] Does it affect the original behavior
   * [ ] Has unit tests been added
   * [ ] Has document been added or modified
   * [ ] Does it need to update dependencies
   * [ ] Is this PR support rollback (If NO, please explain WHY)
   
   ## Further comments
   
   If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] dataroaring merged pull request #18933: [fix](sequence-column) Fix sequence_col column used default expr insert failed

Posted by "dataroaring (via GitHub)" <gi...@apache.org>.
dataroaring merged PR #18933:
URL: https://github.com/apache/doris/pull/18933


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] hello-stephen commented on pull request #18933: [fix](sequence-column) Fix sequence_col column used default expr insert failed

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #18933:
URL: https://github.com/apache/doris/pull/18933#issuecomment-1519011544

   TeamCity pipeline, clickbench performance test result:
    the sum of best hot time: 33.3 seconds
    stream load tsv:          429 seconds loaded 74807831229 Bytes, about 166 MB/s
    stream load json:         23 seconds loaded 2358488459 Bytes, about 97 MB/s
    stream load orc:          59 seconds loaded 1101869774 Bytes, about 17 MB/s
    stream load parquet:          30 seconds loaded 861443392 Bytes, about 27 MB/s
    https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230423093318_clickbench_pr_133309.html


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] liaoxin01 commented on pull request #18933: [fix](sequence-column) Fix sequence_col column used default expr insert failed

Posted by "liaoxin01 (via GitHub)" <gi...@apache.org>.
liaoxin01 commented on PR #18933:
URL: https://github.com/apache/doris/pull/18933#issuecomment-1519004962

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] zclllyybb commented on pull request #18933: [fix](sequence-column) Fix sequence_col column used default expr insert failed

Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on PR #18933:
URL: https://github.com/apache/doris/pull/18933#issuecomment-1531842562

   Ooops... Sorry, I made a mistake and wrongly thought it was because of a series of known issues with the pipeline. But actually it's not. The actual reason for P0 failure is that your changes make there an inequality of `block`'s and output descriptor's column number, in `VOlapTableSink::_validate_data` 😄 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] lvshaokang commented on pull request #18933: [fix](sequence-column) Fix sequence_col column used default expr insert failed

Posted by "lvshaokang (via GitHub)" <gi...@apache.org>.
lvshaokang commented on PR #18933:
URL: https://github.com/apache/doris/pull/18933#issuecomment-1521522992

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] lvshaokang commented on pull request #18933: [fix](sequence-column) Fix sequence_col column used default expr insert failed

Posted by "lvshaokang (via GitHub)" <gi...@apache.org>.
lvshaokang commented on PR #18933:
URL: https://github.com/apache/doris/pull/18933#issuecomment-1528753089

   > we will fix the p0 regression soonly
   
   @zclllyybb Ok, if already fix the p0 regression, could you call me? I will re-run it. Thanks!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] lvshaokang commented on pull request #18933: [fix](sequence-column) Fix sequence_col column used default expr insert failed

Posted by "lvshaokang (via GitHub)" <gi...@apache.org>.
lvshaokang commented on PR #18933:
URL: https://github.com/apache/doris/pull/18933#issuecomment-1534139268

   > Ooops... Sorry, I made a mistake and wrongly thought it was because of a series of known issues with the pipeline. But actually it's not. The actual reason for P0 failure is that your changes make there an inequality of `block`'s and output descriptor's column number, in `VOlapTableSink::_validate_data` 😄
   
   @zclllyybb Could you offer a more detailed logs for me, i would like to known the exception column order is? Btw, I have tested the above error case with locally `run-regression-test.sh` and no error was reported.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] lvshaokang commented on pull request #18933: [fix](sequence-column) Fix sequence_col column used default expr insert failed

Posted by "lvshaokang (via GitHub)" <gi...@apache.org>.
lvshaokang commented on PR #18933:
URL: https://github.com/apache/doris/pull/18933#issuecomment-1527198835

   
   run buildall
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] lvshaokang commented on pull request #18933: [fix](sequence-column) Fix sequence_col column used default expr insert failed

Posted by "lvshaokang (via GitHub)" <gi...@apache.org>.
lvshaokang commented on PR #18933:
URL: https://github.com/apache/doris/pull/18933#issuecomment-1536011212

   
   run buildall
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #18933: [fix](sequence-column) Fix sequence_col column used default expr insert failed

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18933:
URL: https://github.com/apache/doris/pull/18933#issuecomment-1519005183

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] github-actions[bot] commented on pull request #18933: [fix](sequence-column) Fix sequence_col column used default expr insert failed

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #18933:
URL: https://github.com/apache/doris/pull/18933#issuecomment-1538030397

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] lvshaokang commented on pull request #18933: [fix](sequence-column) Fix sequence_col column used default expr insert failed

Posted by "lvshaokang (via GitHub)" <gi...@apache.org>.
lvshaokang commented on PR #18933:
URL: https://github.com/apache/doris/pull/18933#issuecomment-1522664386

   
   run buildall
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] lvshaokang commented on pull request #18933: [fix](sequence-column) Fix sequence_col column used default expr insert failed

Posted by "lvshaokang (via GitHub)" <gi...@apache.org>.
lvshaokang commented on PR #18933:
URL: https://github.com/apache/doris/pull/18933#issuecomment-1525723915

   run buildall
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] lvshaokang commented on pull request #18933: [fix](sequence-column) Fix sequence_col column used default expr insert failed

Posted by "lvshaokang (via GitHub)" <gi...@apache.org>.
lvshaokang commented on PR #18933:
URL: https://github.com/apache/doris/pull/18933#issuecomment-1527185890

   run p0


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] zclllyybb commented on pull request #18933: [fix](sequence-column) Fix sequence_col column used default expr insert failed

Posted by "zclllyybb (via GitHub)" <gi...@apache.org>.
zclllyybb commented on PR #18933:
URL: https://github.com/apache/doris/pull/18933#issuecomment-1527610376

   please rebase after https://github.com/apache/doris/pull/19216 . thank you


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] lvshaokang commented on pull request #18933: [fix](sequence-column) Fix sequence_col column used default expr insert failed

Posted by "lvshaokang (via GitHub)" <gi...@apache.org>.
lvshaokang commented on PR #18933:
URL: https://github.com/apache/doris/pull/18933#issuecomment-1535615051

   
   run buildall
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] lvshaokang commented on pull request #18933: [fix](sequence-column) Fix sequence_col column used default expr insert failed

Posted by "lvshaokang (via GitHub)" <gi...@apache.org>.
lvshaokang commented on PR #18933:
URL: https://github.com/apache/doris/pull/18933#issuecomment-1535200150

   
   run buildall
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] lvshaokang commented on pull request #18933: [fix](sequence-column) Fix sequence_col column used default expr insert failed

Posted by "lvshaokang (via GitHub)" <gi...@apache.org>.
lvshaokang commented on PR #18933:
URL: https://github.com/apache/doris/pull/18933#issuecomment-1535789472

   
   run buildall
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] lvshaokang commented on pull request #18933: [fix](sequence-column) Fix sequence_col column used default expr insert failed

Posted by "lvshaokang (via GitHub)" <gi...@apache.org>.
lvshaokang commented on PR #18933:
URL: https://github.com/apache/doris/pull/18933#issuecomment-1535968979

   run clickbench


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


[GitHub] [doris] liaoxin01 commented on pull request #18933: [fix](sequence-column) Fix sequence_col column used default expr insert failed

Posted by "liaoxin01 (via GitHub)" <gi...@apache.org>.
liaoxin01 commented on PR #18933:
URL: https://github.com/apache/doris/pull/18933#issuecomment-1518933129

   please add a regression test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org