You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/08/03 08:56:01 UTC

[GitHub] [spark] cxzl25 opened a new pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

cxzl25 opened a new pull request #33621:
URL: https://github.com/apache/spark/pull/33621


   ### What changes were proposed in this pull request?
   SPARK-35286 replace `SessionState.start` with `SessionState.setCurrentSessionState`, but `SessionState.close` will create a `HiveMetaStoreClient` , connect to the Hive Meta Store Server, and then load all functions.
   
   
   ### Why are the changes needed?
   Avoid wasting resources and accelerate the exit speed.
   
   ### Does this PR introduce _any_ user-facing change?
   No
   
   
   ### How was this patch tested?
   exist UT
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cxzl25 commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
cxzl25 commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-909121377


   Gentle ping @wangyum @yaooqinn @HyukjinKwon @juliuszsompolski @ @dragqueen95


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-893399789


   **[Test build #142091 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142091/testReport)** for PR 33621 at commit [`086c388`](https://github.com/apache/spark/commit/086c388bf59a7ee2c6c3f48a80d6c2ab3f4a23df).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-891710448


   **[Test build #141990 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141990/testReport)** for PR 33621 at commit [`9091c24`](https://github.com/apache/spark/commit/9091c24400f29378cf677e49c9f864b06ab8df60).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cxzl25 commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
cxzl25 commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-892362241


   [HIVE-12853](https://issues.apache.org/jira/browse/HIVE-12853) (>=2.1) will create the `hive.downloaded.resources.dir` directory when constructing sessionstate.
   https://github.com/apache/hive/blob/branch-2.1/ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java#L389
   
   
   SPARK-35556 (Remove close HiveClient's SessionState) did not clean up the resource dir even when the Hive version was greater than or equal to 2.1.
   
   Currently need to clean up the resource dir and then `SessionState#detachSession`.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-894179810






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-891912148


   **[Test build #142000 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142000/testReport)** for PR 33621 at commit [`13a71eb`](https://github.com/apache/spark/commit/13a71eb38c9e3f56687f82c567fef3a60dfbd7fe).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-891666753


   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cxzl25 commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
cxzl25 commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-909121377


   Gentle ping @wangyum @yaooqinn @HyukjinKwon @juliuszsompolski @ @dragqueen95


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-895322232


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46739/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] wangyum commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-891710092


   ok to test.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cxzl25 commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
cxzl25 commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-892365082


   > can we have a test with `ADD JAR` command to see whether the resource dir being removed successfully after `detachSession `
   
   I can add a UT to check the resource dir cleanup.
   
   SPARK-34955 removed the behavior of `ADD JAR` calling `runSqlHive`, now `ADD JAR` will not put jar in the resource directory.
   
   
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-895315668


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142227/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] wangyum edited a comment on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
wangyum edited a comment on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-892263573


   Could we change [this line](https://github.com/apache/hive/blob/branch-2.3/ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java#L1596) to `Hive threadLocalHive = Hive.getWithoutRegisterFns(sessionConf);`?
   
   It seems that this change makes hive.downloaded.resources.dir can not be removed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-891666753


   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-891958920


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142000/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-895273507


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46739/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-894081959


   **[Test build #142146 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142146/testReport)** for PR 33621 at commit [`d0c228b`](https://github.com/apache/spark/commit/d0c228b16803a5eb835822795e1f0a74b0327f28).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-893484123


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142091/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] juliuszsompolski commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
juliuszsompolski commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-894264488


   cc @dragqueen95 FYI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cxzl25 commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
cxzl25 commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-891688113


   cc @wangyum  @yaooqinn 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] yaooqinn commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
yaooqinn commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-892349860


   can we have a test with `ADD JAR` command to see whether the resource dir being removed successfully after `detachSession `


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cxzl25 commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
cxzl25 commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-909121377


   Gentle ping @wangyum @yaooqinn @HyukjinKwon @juliuszsompolski @ @dragqueen95


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cxzl25 commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
cxzl25 commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-891687874


   `SessionState.close` -> `Hive.create` -> `registerAllFunctions`
   ![image](https://user-images.githubusercontent.com/3898450/127992027-c1546695-6622-4c35-a6b7-0b1b2c26ee76.png)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-891945023


   **[Test build #142000 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142000/testReport)** for PR 33621 at commit [`13a71eb`](https://github.com/apache/spark/commit/13a71eb38c9e3f56687f82c567fef3a60dfbd7fe).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-893433500


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46602/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-891912148


   **[Test build #142000 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142000/testReport)** for PR 33621 at commit [`13a71eb`](https://github.com/apache/spark/commit/13a71eb38c9e3f56687f82c567fef3a60dfbd7fe).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-893482809


   **[Test build #142091 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142091/testReport)** for PR 33621 at commit [`086c388`](https://github.com/apache/spark/commit/086c388bf59a7ee2c6c3f48a80d6c2ab3f4a23df).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-894165504


   **[Test build #142146 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142146/testReport)** for PR 33621 at commit [`d0c228b`](https://github.com/apache/spark/commit/d0c228b16803a5eb835822795e1f0a74b0327f28).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] wangyum edited a comment on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
wangyum edited a comment on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-891712553


   cc @HyukjinKwon 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-894179810






-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-895184885


   **[Test build #142227 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142227/testReport)** for PR 33621 at commit [`d3086a5`](https://github.com/apache/spark/commit/d3086a535794dcd4984d30ea66063f8eab5ad95a).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-891743178


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46501/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-895184885


   **[Test build #142227 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142227/testReport)** for PR 33621 at commit [`d3086a5`](https://github.com/apache/spark/commit/d3086a535794dcd4984d30ea66063f8eab5ad95a).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-891922100


   Kubernetes integration test unable to build dist.
   
   exiting with code: 1
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46512/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-891781307


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46501/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-891733879


   **[Test build #141990 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141990/testReport)** for PR 33621 at commit [`9091c24`](https://github.com/apache/spark/commit/9091c24400f29378cf677e49c9f864b06ab8df60).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cxzl25 commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
cxzl25 commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-893391669


   The current `SparkSQLCLIDriver` calls `SessionState.close`, so its download resource dir has been cleaned up, but `HiveClientImpl` and `SparkSQLCLIDriver` have not been cleaned up.
   In this PR, I clean up these resource dirs.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-891922140


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46512/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-891922140


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46512/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-894143637


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46658/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-891710448


   **[Test build #141990 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/141990/testReport)** for PR 33621 at commit [`9091c24`](https://github.com/apache/spark/commit/9091c24400f29378cf677e49c9f864b06ab8df60).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-895322334


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46739/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-892156501


   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-893399789


   **[Test build #142091 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142091/testReport)** for PR 33621 at commit [`086c388`](https://github.com/apache/spark/commit/086c388bf59a7ee2c6c3f48a80d6c2ab3f4a23df).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] github-actions[bot] closed pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #33621:
URL: https://github.com/apache/spark/pull/33621


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] github-actions[bot] closed pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #33621:
URL: https://github.com/apache/spark/pull/33621


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-894081959


   **[Test build #142146 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142146/testReport)** for PR 33621 at commit [`d0c228b`](https://github.com/apache/spark/commit/d0c228b16803a5eb835822795e1f0a74b0327f28).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-894172862


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46658/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] wangyum commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-891712553


   + @HyukjinKwon 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-891958920


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142000/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-893479403


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46602/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-891777682


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46501/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cxzl25 commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
cxzl25 commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-892347756


   > Could we change [this line](https://github.com/apache/hive/blob/branch-2.3/ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java#L1596) to `Hive threadLocalHive = Hive.getWithoutRegisterFns(sessionConf);`?
   
   [HIVE-17368](https://issues.apache.org/jira/browse/HIVE-17368) avoid creating a `threadLocalHive` in the `unCacheDataNucleusClassLoaders` method.
   
   https://github.com/apache/hive/blob/branch-3.0/ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java#L1772
   
   > It seems that this change makes hive.downloaded.resources.dir can not be removed.
   
   AFIAK, because `SessionState.start` is not used, the resources directory will not be created.
   Because SPARK-35286 avoids creating session dir, that is, it will not call `createSessionDirs`.
   ```java
     /**
      * Create dirs & session paths for this session:
      * 1. HDFS scratch dir
      * 2. Local scratch dir
      * 3. Local downloaded resource dir
      * 4. HDFS session path
      * 5. hold a lock file in HDFS session dir to indicate the it is in use
      * 6. Local session path
      * 7. HDFS temp table space
      * @param userName
      * @throws IOException
      */
     private void createSessionDirs(String userName) throws IOException {
   ```
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-893484123


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142091/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-893479403


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46602/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-895314114


   **[Test build #142227 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/142227/testReport)** for PR 33621 at commit [`d3086a5`](https://github.com/apache/spark/commit/d3086a535794dcd4984d30ea66063f8eab5ad95a).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds the following public classes _(experimental)_:
     * `class BlockSavedOnDecommissionedBlockManagerException(blockId: BlockId)`
     * `case class EnsureRequirements(optimizeOutRepartition: Boolean = true) extends Rule[SparkPlan] `


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-893473605


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/46602/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-891743194


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141990/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-892156501


   Can one of the admins verify this patch?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-895315668


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/142227/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-895322334


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46739/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] wangyum commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
wangyum commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-892263573


   Could we change [this line](https://github.com/apache/hive/blob/branch-2.3/ql/src/java/org/apache/hadoop/hive/ql/session/SessionState.java#L1596) to `Hive threadLocalHive = Hive.getWithoutRegisterFns(sessionConf);`?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-891781307


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/46501/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-892273780


   Thanks for pinging me @wangyum. The fix seems making sense


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-891743194


   
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/141990/
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #33621: [SPARK-36390][SQL] Replace SessionState.close with SessionState.detachSession

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #33621:
URL: https://github.com/apache/spark/pull/33621#issuecomment-893974905


   cc @juliuszsompolski FYI


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org