[GitHub] [hbase] joshelser commented on a change in pull request #722: HBASE-23065 [hbtop] Top-N heavy hitter user and client drill downs

[GitBox <gi...@apache.org>]

joshelser commented on a change in pull request #722: HBASE-23065 [hbtop] Top-N heavy hitter user and client drill downs
URL: https://github.com/apache/hbase/pull/722#discussion_r337063114
 
 

 ##########
 File path: hbase-server/src/test/java/org/apache/hadoop/hbase/TestClientClusterMetrics.java
 ##########
 @@ -72,6 +84,8 @@
   public static void setUpBeforeClass() throws Exception {
     Configuration conf = HBaseConfiguration.create();
     conf.set(CoprocessorHost.MASTER_COPROCESSOR_CONF_KEY, MyObserver.class.getName());
+    conf.set("hbase.security.authorization", Boolean.TRUE.toString());
+    conf.set("hbase.security.exec.permission.checks", Boolean.TRUE.toString());
 
 Review comment:
   If you're setting these, do you also want to deploy the AccessController?
   
   If not, what are these needed for?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services