[GitHub] [spark] squito commented on a change in pull request #26924: [SPARK-30285][CORE]Fix race condition between LiveListenerBus#stop and AsyncEventQueue#removeListenerOnError

[GitBox <gi...@apache.org>]

squito commented on a change in pull request #26924: [SPARK-30285][CORE]Fix race condition between LiveListenerBus#stop and AsyncEventQueue#removeListenerOnError
URL: https://github.com/apache/spark/pull/26924#discussion_r359031895
 
 

 ##########
 File path: core/src/main/java/org/apache/spark/SparkFirehoseListener.java
 ##########
 @@ -30,6 +30,14 @@
  */
 public class SparkFirehoseListener implements SparkListenerInterface {
 
+  @Override
+  public boolean dead() {
+    return false;
+  }
+
+  @Override
+  public void dead_$eq(boolean dead) { }
 
 Review comment:
   these methods should actually be implemented, so anybody extending this in java gets the fix as well.
   
   ideally we could do this somehow so this doesn't get exposed at all part of the api, but I can't think of a way to do that ...

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org