You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by mo...@apache.org on 2016/06/17 04:40:53 UTC
zeppelin git commit: [ZEPPELIN-698] #756 Added new shortcuts but
didn't removed old one
Repository: zeppelin
Updated Branches:
refs/heads/master ff197d062 -> f786d1387
[ZEPPELIN-698] #756 Added new shortcuts but didn't removed old one
### What is this PR for?
#756 Added new shortcuts but didn't removed old one
https://github.com/apache/zeppelin/pull/756#issuecomment-226423090
### What type of PR is it?
Bug Fix
### Todos
* [x] - Remove old shortcuts
### What is the Jira issue?
https://issues.apache.org/jira/browse/ZEPPELIN-698
### Questions:
* Does the licenses files need update? no
* Is there breaking changes for older versions? no
* Does this needs documentation? no
Author: Lee moon soo <mo...@apache.org>
Closes #1029 from Leemoonsoo/ZEPPELIN-698-FOLLOWUP and squashes the following commits:
33f6a46 [Lee moon soo] Remove shortcuts ctrl+alt+1~0-=
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/f786d138
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/f786d138
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/f786d138
Branch: refs/heads/master
Commit: f786d1387a7ccae0387e470abb44912d5f322d6b
Parents: ff197d0
Author: Lee moon soo <mo...@apache.org>
Authored: Thu Jun 16 07:58:52 2016 -0700
Committer: Lee moon soo <mo...@apache.org>
Committed: Thu Jun 16 21:42:38 2016 -0700
----------------------------------------------------------------------
.../src/app/notebook/paragraph/paragraph.controller.js | 13 -------------
1 file changed, 13 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/f786d138/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js b/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
index dfdad30..21a17b2 100644
--- a/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
+++ b/zeppelin-web/src/app/notebook/paragraph/paragraph.controller.js
@@ -1053,19 +1053,6 @@ angular.module('zeppelinWebApp')
} else if (keyEvent.ctrlKey && keyEvent.shiftKey && keyCode === 187) { // Ctrl + Shift + =
$scope.paragraph.config.colWidth = Math.min(12, $scope.paragraph.config.colWidth + 1);
$scope.changeColWidth();
- } else if (keyEvent.ctrlKey && keyEvent.altKey && ((keyCode >= 48 && keyCode <=57) || keyCode === 189 || keyCode === 187)) { // Ctrl + Alt + [1~9,0,-,=]
- var colWidth = 12;
- if (keyCode === 48) {
- colWidth = 10;
- } else if (keyCode === 189) {
- colWidth = 11;
- } else if (keyCode === 187) {
- colWidth = 12;
- } else {
- colWidth = keyCode - 48;
- }
- $scope.paragraph.config.colWidth = colWidth;
- $scope.changeColWidth();
} else if (keyEvent.ctrlKey && keyEvent.altKey && keyCode === 84) { // Ctrl + Alt + t
if ($scope.paragraph.config.title) {
$scope.hideTitle();