You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by "lhotari (via GitHub)" <gi...@apache.org> on 2024/06/07 08:28:35 UTC
[PR] [fix][misc] Disable JFR based telemetry collection since it's not used [pulsar]
lhotari opened a new pull request, #22869:
URL: https://github.com/apache/pulsar/pull/22869
### Motivation
<img width="1016" alt="image" src="https://github.com/apache/pulsar/assets/66864/0c1cba08-cf70-4f44-b27c-77f121fd6070">
This happens in MultiBrokerLeaderElectionTest which has starts 10 embedded brokers in the test.
<img width="1089" alt="image" src="https://github.com/apache/pulsar/assets/66864/ac183a09-ae54-42e6-a650-d781878a9ea8">
<!-- Explain here the context, and why you're making that change. What is the problem you're trying to solve. -->
### Modifications
- disable JFR based telemetry collection since it's not used at the moment.
### Documentation
<!-- DO NOT REMOVE THIS SECTION. CHECK THE PROPER BOX ONLY. -->
- [ ] `doc` <!-- Your PR contains doc changes. -->
- [ ] `doc-required` <!-- Your PR changes impact docs and you will update later -->
- [x] `doc-not-needed` <!-- Your PR changes do not impact docs -->
- [ ] `doc-complete` <!-- Docs have been already added -->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][misc] Disable JFR based telemetry collection since it's not used [pulsar]
Posted by "merlimat (via GitHub)" <gi...@apache.org>.
merlimat merged PR #22869:
URL: https://github.com/apache/pulsar/pull/22869
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][misc] Disable JFR based telemetry collection since it's not used [pulsar]
Posted by "heesung-sn (via GitHub)" <gi...@apache.org>.
heesung-sn commented on PR #22869:
URL: https://github.com/apache/pulsar/pull/22869#issuecomment-2155152469
LGTM.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [fix][misc] Disable JFR based telemetry collection since it's not used [pulsar]
Posted by "lhotari (via GitHub)" <gi...@apache.org>.
lhotari commented on PR #22869:
URL: https://github.com/apache/pulsar/pull/22869#issuecomment-2154355097
@dragosvictor Please review. It looks like we didn't properly disable JFR metrics in #22616 or the 1.38.0 upgrade enabled more JFR metrics by default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org