You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/12/13 17:20:40 UTC

[GitHub] [arrow] paleolimbot opened a new pull request, #14935: ARROW-17637: [R] as.Date fails going from timestamp[us] to timestamp[s]

paleolimbot opened a new pull request, #14935:
URL: https://github.com/apache/arrow/pull/14935

   Before this PR:
   
   ``` r
   library(arrow, warn.conflicts = FALSE)
   #> Some features are not enabled in this build of Arrow. Run `arrow_info()` for more information.
   library(dplyr, warn.conflicts = FALSE)
   library(lubridate, warn.conflicts = FALSE)
   #> Loading required package: timechange
   
   # Use as_datetime() because as.POSIXct() truncates the fractional seconds
   ds <- InMemoryDataset$create(data.frame(x = as_datetime('2022-05-05T00:00:01.676632')))
   ds %>%
     mutate(date = as.Date(x)) %>%
     collect()
   #> Error in `compute.arrow_dplyr_query()` at r/R/dplyr-collect.R:22:2:
   #> ! Invalid: Casting from timestamp[us, tz=UTC] to timestamp[s, tz=UTC] would lose data: 1651708801676632
   #> /Users/dewey/Desktop/rscratch/arrow/cpp/src/arrow/compute/exec.cc:821  kernel_->exec(kernel_ctx_, input, out)
   #> /Users/dewey/Desktop/rscratch/arrow/cpp/src/arrow/compute/exec.cc:789  ExecuteSingleSpan(input, &output)
   #> /Users/dewey/Desktop/rscratch/arrow/cpp/src/arrow/compute/exec/expression.cc:608  executor->Execute( ExecBatch(std::move(arguments), all_scalar ? 1 : input.length), &listener)
   #> /Users/dewey/Desktop/rscratch/arrow/cpp/src/arrow/compute/exec/expression.cc:590  ExecuteScalarExpression(call->arguments[i], input, exec_context)
   #> /Users/dewey/Desktop/rscratch/arrow/cpp/src/arrow/compute/exec/project_node.cc:91  ExecuteScalarExpression(simplified_expr, target, plan()->exec_context())
   #> /Users/dewey/Desktop/rscratch/arrow/cpp/src/arrow/record_batch.cc:334  ReadNext(&batch)
   #> /Users/dewey/Desktop/rscratch/arrow/cpp/src/arrow/record_batch.cc:348  ToRecordBatches()
   
   #> Backtrace:
   #>      ▆
   #>   1. ├─ds %>% mutate(date = as.Date(x)) %>% collect()
   #>   2. ├─dplyr::collect(.)
   #>   3. └─arrow:::collect.arrow_dplyr_query(.)
   #>   4.   └─arrow:::compute.arrow_dplyr_query(x) at r/R/dplyr-collect.R:22:2
   #>   5.     └─base::tryCatch(...) at r/R/dplyr-collect.R:40:2
   #>   6.       └─base (local) tryCatchList(expr, classes, parentenv, handlers)
   #>   7.         └─base (local) tryCatchOne(expr, names, parentenv, handlers[[1L]])
   #>   8.           └─value[[3L]](cond)
   #>   9.             └─arrow:::augment_io_error_msg(e, call, schema = schema()) at r/R/dplyr-collect.R:49:6
   #>  10.               └─rlang::abort(msg, call = call) at r/R/util.R:251:2
   ```
   
   <sup>Created on 2022-12-13 with [reprex v2.0.2](https://reprex.tidyverse.org)</sup>
   
   After this PR:
   
   ``` r
   library(arrow, warn.conflicts = FALSE)
   #> Some features are not enabled in this build of Arrow. Run `arrow_info()` for more information.
   library(dplyr, warn.conflicts = FALSE)
   library(lubridate, warn.conflicts = FALSE)
   #> Loading required package: timechange
   
   # Use as_datetime() because as.POSIXct() truncates the fractional seconds
   ds <- InMemoryDataset$create(data.frame(x = as_datetime('2022-05-05T00:00:01.676632')))
   ds %>%
     mutate(date = as.Date(x)) %>%
     collect()
   #>                     x       date
   #> 1 2022-05-05 00:00:01 2022-05-05
   ```
   
   <sup>Created on 2022-12-13 with [reprex v2.0.2](https://reprex.tidyverse.org)</sup>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] ursabot commented on pull request #14935: ARROW-17637: [R] as.Date fails going from timestamp[us] to timestamp[s]

Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14935:
URL: https://github.com/apache/arrow/pull/14935#issuecomment-1353245100

   Benchmark runs are scheduled for baseline = 4751c89b24365d5e6d0f75e70e496d5acc69dc17 and contender = 702dbf3982e76f89866ce3cbebc004a351ed0caa. 702dbf3982e76f89866ce3cbebc004a351ed0caa is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
   Conbench compare runs links:
   [Finished :arrow_down:0.0% :arrow_up:0.0%] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/5023d6e072694af18833cbba014cd25a...6321c8594e764a0c84b6ea782fdf1477/)
   [Finished :arrow_down:0.26% :arrow_up:0.07%] [test-mac-arm](https://conbench.ursa.dev/compare/runs/ae5b8368ed9b4e908a85c29be18668df...585e1362c3e24203be77a2b8e7e1caa2/)
   [Finished :arrow_down:0.54% :arrow_up:0.0%] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/bf611b6aa5234d388d0a7b5b6dc6ea85...b28d630ea814444b81437cca990f2968/)
   [Finished :arrow_down:0.41% :arrow_up:0.03%] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/69f526543b13410f9b1a526d1bd777d6...70f6f09a83d6443084dce0b379009fbe/)
   Buildkite builds:
   [Finished] [`702dbf39` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2005)
   [Finished] [`702dbf39` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2027)
   [Finished] [`702dbf39` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1997)
   [Finished] [`702dbf39` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2019)
   [Finished] [`4751c89b` ec2-t3-xlarge-us-east-2](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ec2-t3-xlarge-us-east-2/builds/2004)
   [Finished] [`4751c89b` test-mac-arm](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-test-mac-arm/builds/2026)
   [Finished] [`4751c89b` ursa-i9-9960x](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-i9-9960x/builds/1996)
   [Finished] [`4751c89b` ursa-thinkcentre-m75q](https://buildkite.com/apache-arrow/arrow-bci-benchmark-on-ursa-thinkcentre-m75q/builds/2018)
   Supported benchmarks:
   ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
   test-mac-arm: Supported benchmark langs: C++, Python, R
   ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
   ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] ursabot commented on pull request #14935: ARROW-17637: [R] as.Date fails going from timestamp[us] to timestamp[s]

Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #14935:
URL: https://github.com/apache/arrow/pull/14935#issuecomment-1353245442

   ['Python', 'R'] benchmarks have high level of regressions.
   [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/bf611b6aa5234d388d0a7b5b6dc6ea85...b28d630ea814444b81437cca990f2968/)
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] github-actions[bot] commented on pull request #14935: ARROW-17637: [R] as.Date fails going from timestamp[us] to timestamp[s]

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14935:
URL: https://github.com/apache/arrow/pull/14935#issuecomment-1349143448

   :warning: Ticket **has not been started in JIRA**, please click 'Start Progress'.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] github-actions[bot] commented on pull request #14935: ARROW-17637: [R] as.Date fails going from timestamp[us] to timestamp[s]

Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #14935:
URL: https://github.com/apache/arrow/pull/14935#issuecomment-1349143336

   https://issues.apache.org/jira/browse/ARROW-17637


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


[GitHub] [arrow] paleolimbot merged pull request #14935: ARROW-17637: [R] as.Date fails going from timestamp[us] to timestamp[s]

Posted by GitBox <gi...@apache.org>.
paleolimbot merged PR #14935:
URL: https://github.com/apache/arrow/pull/14935


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org