You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by GitBox <gi...@apache.org> on 2022/08/06 12:50:44 UTC
[GitHub] [jena] afs commented on a diff in pull request #1315: GH-1314 Bulk retrieval and caching with SERVICE clause
afs commented on code in PR #1315:
URL: https://github.com/apache/jena/pull/1315#discussion_r939525193
##########
jena-extras/jena-serviceenhancer/pom.xml:
##########
@@ -0,0 +1,185 @@
+<?xml version="1.0" encoding="UTF-8"?>
Review Comment:
I am still get 36 warning from Eclipse:
* Javadoc : `@return` without text after it.
* try-with-resource
* Missing `@Override`
* Unnecessary casts
Eclispe or IntelliJ will pick these up.
When people start working with the Jena codebase, it's nice to give them a reasonable clean view.
As Release Manager, it is also helpful to have a clean view so I can see when new things arise.
```
Javadoc: Description expected after @return BatchQueryRewriter.java line 129
Javadoc: Description expected after @return IteratorFactoryWithBuffer.java line 96
Javadoc: Description expected after @return Ref.java line 73
Javadoc: Description expected after @return ServiceOpts.java line 118
Javadoc: Description expected after @return Slice.java line 57
Javadoc: Description expected after @return Slice.java line 90
Javadoc: Description expected after @return VarScopeUtils.java line 105
Resource 'disposable' should be managed by try-with-resource AsyncClaimingCacheImplGuava.java line 378 Java Problem
Resource 'reclaim' should be managed by try-with-resource AsyncClaimingCacheImplGuava.java line 385
Resource 'ref' should be managed by try-with-resource AsyncClaimingCacheImplGuava.java line 376
The method claim(K) of type AsyncClaimingCacheImplGuava<K,V> should be tagged with @Override since it actually overrides a superinterface method AsyncClaimingCacheImplGuava.java line 162
The method close() of type SliceAccessor<A> should be tagged with @Override since it actually overrides a superinterface method SliceAccessor.java line 108
The method createSubIterator(boolean) of type IteratorFactoryWithBuffer<T,I>.SubIteratorImpl should be tagged with @Override since it actually overrides a superinterface method IteratorFactoryWithBuffer.java line 135
The method exec(OpService) of type OpServiceExecutorImpl should be tagged with @Override since it actually overrides a superinterface method OpServiceExecutorImpl.java line 51
The method getArrayOps() of type BufferLike<A> should be tagged with @Override since it actually overrides a superinterface method BufferLike.java line 33
The method getDelegate() of type RefDelegateBase<T,R> should be tagged with @Override since it actually overrides a superinterface method RefDelegateBase.java line 31
The method getFailedRanges() of type SliceMetaDataImpl should be tagged with @Override since it actually overrides a superinterface method SliceMetaDataImpl.java line 70
The method getItems() of type BatchImpl<K,T> should be tagged with @Override since it actually overrides a superinterface method BatchImpl.java line 76
The method getLoadedRanges() of type SliceMetaDataImpl should be tagged with @Override since it actually overrides a superinterface method SliceMetaDataImpl.java line 62
The method getMaximumKnownSize() of type SliceMetaDataImpl should be tagged with @Override since it actually overrides a superinterface method SliceMetaDataImpl.java line 78
The method getMinimumKnownSize() of type SliceMetaDataImpl should be tagged with @Override since it actually overrides a superinterface method SliceMetaDataImpl.java line 74
The method getNextValidIndex() of type BatchImpl<K,T> should be tagged with @Override since it actually overrides a superinterface method BatchImpl.java line 68
The method getRanges() of type RangeBufferImpl<A> should be tagged with @Override since it actually overrides a superinterface method RangeBufferImpl.java line 90
The method isEmpty() of type BatchImpl<K,T> should be tagged with @Override since it actually overrides a superinterface method BatchImpl.java line 80
The method newSliceAccessor() of type SliceWithPages<T> should be tagged with @Override since it actually overrides a superinterface method SliceWithPages.java line 31
The method put(K, T) of type BatchImpl<K,T> should be tagged with @Override since it actually overrides a superinterface method BatchImpl.java line 58
The method size() of type BatchImpl<K,T> should be tagged with @Override since it actually overrides a superinterface method BatchImpl.java line 84
The method start() of type ServiceEnhancerInit should be tagged with @Override since it actually overrides a superinterface method ServiceEnhancerInit.java line 58
The method unsafeRead(A, int, long, int) of type SliceAccessorImpl<A> should be tagged with @Override since it actually overrides a superinterface method SliceAccessorImpl.java line 286
Unnecessary cast from A to A BufferOverArray.java line 50
Unnecessary cast from int to long PageUtils.java line 44
Unnecessary cast from K to K AsyncClaimingCacheImplGuava.java line 307
Unnecessary cast from long to long RangeBufferImpl.java line 83
Unnecessary cast from Ref to Ref<T> RefImpl.java line 162
Unnecessary cast from V to V AsyncClaimingCacheImplGuava.java line 307
Unnecessary cast from V to V AsyncClaimingCacheImplGuava.java line 324
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org