You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2022/10/14 03:01:18 UTC
[GitHub] [arrow-rs] tustvold opened a new pull request, #2870: Filter DecimalArray as PrimitiveArray (#2637)
tustvold opened a new pull request, #2870:
URL: https://github.com/apache/arrow-rs/pull/2870
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Part of #2637
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
Uses the optimised filter primitive implementation for filtering decimal arrays
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
No
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] ursabot commented on pull request #2870: Filter DecimalArray as PrimitiveArray ~80% Faster (#2637)
Posted by GitBox <gi...@apache.org>.
ursabot commented on PR #2870:
URL: https://github.com/apache/arrow-rs/pull/2870#issuecomment-1279831611
Benchmark runs are scheduled for baseline = f055f51c9d80799c54b68f790cf6656ce5ad090a and contender = ede36d7ab1c144ac27a0c78a99668a1af2ae6413. ede36d7ab1c144ac27a0c78a99668a1af2ae6413 is a master commit associated with this PR. Results will be available as each benchmark for each run completes.
Conbench compare runs links:
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ec2-t3-xlarge-us-east-2] [ec2-t3-xlarge-us-east-2](https://conbench.ursa.dev/compare/runs/d9ae57c742304bf5bcc1ce99c78c0a25...dc88d23eb26d4feb99f5f73e46aef394/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on test-mac-arm] [test-mac-arm](https://conbench.ursa.dev/compare/runs/c9ee273f05f247178152a452e6263aec...6ca5e7590ff04b6c8a3102975072bd13/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-i9-9960x] [ursa-i9-9960x](https://conbench.ursa.dev/compare/runs/e126d7eed08f402a8070fbbaf744b90d...1c75e3beeea54a12a7c79b8bace55e8d/)
[Skipped :warning: Benchmarking of arrow-rs-commits is not supported on ursa-thinkcentre-m75q] [ursa-thinkcentre-m75q](https://conbench.ursa.dev/compare/runs/cf95eff3315e466fac11c85e79621f0f...1c4dd66421e040d99495beed7f897bf0/)
Buildkite builds:
Supported benchmarks:
ec2-t3-xlarge-us-east-2: Supported benchmark langs: Python, R. Runs only benchmarks with cloud = True
test-mac-arm: Supported benchmark langs: C++, Python, R
ursa-i9-9960x: Supported benchmark langs: Python, R, JavaScript
ursa-thinkcentre-m75q: Supported benchmark langs: C++, Java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #2870: Filter DecimalArray as PrimitiveArray ~80% Faster (#2637)
Posted by GitBox <gi...@apache.org>.
tustvold merged PR #2870:
URL: https://github.com/apache/arrow-rs/pull/2870
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #2870: Filter DecimalArray as PrimitiveArray (#2637)
Posted by GitBox <gi...@apache.org>.
tustvold commented on PR #2870:
URL: https://github.com/apache/arrow-rs/pull/2870#issuecomment-1279821199
```
filter decimal128 (kept 1/2)
time: [92.406 µs 92.455 µs 92.515 µs]
change: [-66.107% -66.043% -65.967%] (p = 0.00 < 0.05)
Performance has improved.
Found 11 outliers among 100 measurements (11.00%)
4 (4.00%) high mild
7 (7.00%) high severe
filter decimal128 high selectivity (kept 1023/1024)
time: [51.903 µs 52.226 µs 52.571 µs]
change: [-58.848% -58.570% -58.303%] (p = 0.00 < 0.05)
Performance has improved.
Found 3 outliers among 100 measurements (3.00%)
3 (3.00%) high mild
filter decimal128 low selectivity (kept 1/1024)
time: [2.8865 µs 2.8877 µs 2.8891 µs]
change: [-20.743% -20.519% -20.286%] (p = 0.00 < 0.05)
Performance has improved.
Found 1 outliers among 100 measurements (1.00%)
1 (1.00%) high severe
filter context decimal128 (kept 1/2)
time: [41.956 µs 43.880 µs 45.982 µs]
change: [-84.841% -84.535% -84.193%] (p = 0.00 < 0.05)
Performance has improved.
Found 13 outliers among 100 measurements (13.00%)
13 (13.00%) high severe
filter context decimal128 high selectivity (kept 1023/1024)
time: [49.703 µs 50.000 µs 50.358 µs]
change: [-58.433% -58.128% -57.825%] (p = 0.00 < 0.05)
Performance has improved.
filter context decimal128 low selectivity (kept 1/1024)
time: [367.45 ns 367.51 ns 367.59 ns]
change: [-88.839% -88.822% -88.791%] (p = 0.00 < 0.05)
Performance has improved.
Found 7 outliers among 100 measurements (7.00%)
1 (1.00%) low mild
6 (6.00%) high severe
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] Dandandan commented on pull request #2870: Filter DecimalArray as PrimitiveArray ~80% Faster (#2637)
Posted by GitBox <gi...@apache.org>.
Dandandan commented on PR #2870:
URL: https://github.com/apache/arrow-rs/pull/2870#issuecomment-1279833457
Nice @tustvold
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org