You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hbase.apache.org by "Li Pi (JIRA)" <ji...@apache.org> on 2011/08/29 16:20:38 UTC

[jira] [Created] (HBASE-4278) Race condition in Slab.java that occurs due to spinlock unlocking early.

Race condition in Slab.java that occurs due to spinlock unlocking early.
------------------------------------------------------------------------

                 Key: HBASE-4278
                 URL: https://issues.apache.org/jira/browse/HBASE-4278
             Project: HBase
          Issue Type: Sub-task
            Reporter: Li Pi
            Assignee: Li Pi


Just a race condition in 4027. Occurs due to a spinlock that happens if the slab allocator is empty. When the slab allocator gets gets a slice of memory returned, if multiple threads are locked, both can be freed at the same time, leading one to throw an exception.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4278) Race condition in Slab.java that occurs due to spinlock unlocking early

Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13092935#comment-13092935 ] 

Ted Yu commented on HBASE-4278:
-------------------------------

Integrated to TRUNK.

Thanks for the patch Li.

> Race condition in Slab.java that occurs due to spinlock unlocking early
> -----------------------------------------------------------------------
>
>                 Key: HBASE-4278
>                 URL: https://issues.apache.org/jira/browse/HBASE-4278
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Li Pi
>            Assignee: Li Pi
>             Fix For: 0.92.0
>
>         Attachments: 4278.diff, 4278.diff
>
>
> Just a race condition in 4027. Occurs due to a spinlock that happens if the slab allocator is empty. When the slab allocator gets gets a slice of memory returned, if multiple threads are locked, both can be freed at the same time, leading one to throw an exception.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4278) Race condition in Slab.java that occurs due to spinlock unlocking early.

Posted by "Li Pi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Li Pi updated HBASE-4278:
-------------------------

    Status: Patch Available  (was: Open)

fixed.

> Race condition in Slab.java that occurs due to spinlock unlocking early.
> ------------------------------------------------------------------------
>
>                 Key: HBASE-4278
>                 URL: https://issues.apache.org/jira/browse/HBASE-4278
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Li Pi
>            Assignee: Li Pi
>             Fix For: 0.92.0
>
>
> Just a race condition in 4027. Occurs due to a spinlock that happens if the slab allocator is empty. When the slab allocator gets gets a slice of memory returned, if multiple threads are locked, both can be freed at the same time, leading one to throw an exception.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4278) Race condition in Slab.java that occurs due to spinlock unlocking early

Posted by "Li Pi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Li Pi updated HBASE-4278:
-------------------------

    Resolution: Fixed
        Status: Resolved  (was: Patch Available)

> Race condition in Slab.java that occurs due to spinlock unlocking early
> -----------------------------------------------------------------------
>
>                 Key: HBASE-4278
>                 URL: https://issues.apache.org/jira/browse/HBASE-4278
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Li Pi
>            Assignee: Li Pi
>             Fix For: 0.92.0
>
>         Attachments: 4278.diff, 4278.diff
>
>
> Just a race condition in 4027. Occurs due to a spinlock that happens if the slab allocator is empty. When the slab allocator gets gets a slice of memory returned, if multiple threads are locked, both can be freed at the same time, leading one to throw an exception.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4278) Race condition in Slab.java that occurs due to spinlock unlocking early.

Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13092860#comment-13092860 ] 

Ted Yu commented on HBASE-4278:
-------------------------------

The patch contains changes for src/docbkx/book.xml which I assume was unintended.
+1 on patch for Slab.java.

> Race condition in Slab.java that occurs due to spinlock unlocking early.
> ------------------------------------------------------------------------
>
>                 Key: HBASE-4278
>                 URL: https://issues.apache.org/jira/browse/HBASE-4278
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Li Pi
>            Assignee: Li Pi
>             Fix For: 0.92.0
>
>         Attachments: 4278.diff
>
>
> Just a race condition in 4027. Occurs due to a spinlock that happens if the slab allocator is empty. When the slab allocator gets gets a slice of memory returned, if multiple threads are locked, both can be freed at the same time, leading one to throw an exception.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4278) Race condition in Slab.java that occurs due to spinlock unlocking early

Posted by "Ted Yu (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ted Yu updated HBASE-4278:
--------------------------

    Summary: Race condition in Slab.java that occurs due to spinlock unlocking early  (was: Race condition in Slab.java that occurs due to spinlock unlocking early.)

> Race condition in Slab.java that occurs due to spinlock unlocking early
> -----------------------------------------------------------------------
>
>                 Key: HBASE-4278
>                 URL: https://issues.apache.org/jira/browse/HBASE-4278
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Li Pi
>            Assignee: Li Pi
>             Fix For: 0.92.0
>
>         Attachments: 4278.diff, 4278.diff
>
>
> Just a race condition in 4027. Occurs due to a spinlock that happens if the slab allocator is empty. When the slab allocator gets gets a slice of memory returned, if multiple threads are locked, both can be freed at the same time, leading one to throw an exception.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4278) Race condition in Slab.java that occurs due to spinlock unlocking early.

Posted by "Li Pi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Li Pi updated HBASE-4278:
-------------------------

    Attachment: 4278.diff

whoops.

> Race condition in Slab.java that occurs due to spinlock unlocking early.
> ------------------------------------------------------------------------
>
>                 Key: HBASE-4278
>                 URL: https://issues.apache.org/jira/browse/HBASE-4278
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Li Pi
>            Assignee: Li Pi
>             Fix For: 0.92.0
>
>         Attachments: 4278.diff, 4278.diff
>
>
> Just a race condition in 4027. Occurs due to a spinlock that happens if the slab allocator is empty. When the slab allocator gets gets a slice of memory returned, if multiple threads are locked, both can be freed at the same time, leading one to throw an exception.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4278) Race condition in Slab.java that occurs due to spinlock unlocking early.

Posted by "Li Pi (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13092864#comment-13092864 ] 

Li Pi commented on HBASE-4278:
------------------------------

oh, whoops, will resubmit patch.

> Race condition in Slab.java that occurs due to spinlock unlocking early.
> ------------------------------------------------------------------------
>
>                 Key: HBASE-4278
>                 URL: https://issues.apache.org/jira/browse/HBASE-4278
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Li Pi
>            Assignee: Li Pi
>             Fix For: 0.92.0
>
>         Attachments: 4278.diff, 4278.diff
>
>
> Just a race condition in 4027. Occurs due to a spinlock that happens if the slab allocator is empty. When the slab allocator gets gets a slice of memory returned, if multiple threads are locked, both can be freed at the same time, leading one to throw an exception.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (HBASE-4278) Race condition in Slab.java that occurs due to spinlock unlocking early.

Posted by "Li Pi (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/HBASE-4278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Li Pi updated HBASE-4278:
-------------------------

    Attachment: 4278.diff

discovered by ted yu.

> Race condition in Slab.java that occurs due to spinlock unlocking early.
> ------------------------------------------------------------------------
>
>                 Key: HBASE-4278
>                 URL: https://issues.apache.org/jira/browse/HBASE-4278
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Li Pi
>            Assignee: Li Pi
>             Fix For: 0.92.0
>
>         Attachments: 4278.diff
>
>
> Just a race condition in 4027. Occurs due to a spinlock that happens if the slab allocator is empty. When the slab allocator gets gets a slice of memory returned, if multiple threads are locked, both can be freed at the same time, leading one to throw an exception.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (HBASE-4278) Race condition in Slab.java that occurs due to spinlock unlocking early

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/HBASE-4278?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093022#comment-13093022 ] 

Hudson commented on HBASE-4278:
-------------------------------

Integrated in HBase-TRUNK #2157 (See [https://builds.apache.org/job/HBase-TRUNK/2157/])
    HBASE-4278  Race condition in Slab.java that occurs due to spinlock unlocking
               early (Li Pi)

tedyu : 
Files : 
* /hbase/trunk/CHANGES.txt
* /hbase/trunk/src/main/java/org/apache/hadoop/hbase/io/hfile/slab/Slab.java


> Race condition in Slab.java that occurs due to spinlock unlocking early
> -----------------------------------------------------------------------
>
>                 Key: HBASE-4278
>                 URL: https://issues.apache.org/jira/browse/HBASE-4278
>             Project: HBase
>          Issue Type: Sub-task
>            Reporter: Li Pi
>            Assignee: Li Pi
>             Fix For: 0.92.0
>
>         Attachments: 4278.diff, 4278.diff
>
>
> Just a race condition in 4027. Occurs due to a spinlock that happens if the slab allocator is empty. When the slab allocator gets gets a slice of memory returned, if multiple threads are locked, both can be freed at the same time, leading one to throw an exception.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira