You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2022/02/23 07:30:26 UTC

[GitHub] [iceberg] happyprg commented on a change in pull request #4203: chore: commenting invalid typo `commited` in base_transaction.py and fix invalid typos in test_cases

happyprg commented on a change in pull request #4203:
URL: https://github.com/apache/iceberg/pull/4203#discussion_r812616419



##########
File path: python_legacy/iceberg/core/base_transaction.py
##########
@@ -60,6 +60,7 @@ def __init__(self, ops, start):
     def table(self):
         return self.transaction_table
 
+    # NOTE: function name has typo in the word `comitted`. Kept for backwards compatability in legacy python API.
     def check_last_operation_commited(self, operation):

Review comment:
       
   > Wasn't there a second typo? I would include the comment with both, s
   
   @kbendick 
   What's mean exactly? (Sorry My native language is not English.)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org