[GitHub] [lucene] uschindler commented on a change in pull request #643: LUCENE-10400: revise binary dictionaries' constructor in kuromoji

[GitBox <gi...@apache.org>]

uschindler commented on a change in pull request #643:
URL: https://github.com/apache/lucene/pull/643#discussion_r802620259



##########
File path: lucene/core/src/java/org/apache/lucene/util/IOUtils.java
##########
@@ -526,4 +526,17 @@ public static void fsync(Path fileToSync, boolean isDir) throws IOException {
   public interface IOFunction<T, R> {
     R apply(T t) throws IOException;
   }
+
+  /**
+   * A resource supplier function that may throw an IOException.
+   *
+   * <p>Note that this would open a resource such as a File. Consumers should make sure to close the
+   * resource (e.g., use try-with-resources)
+   *
+   * @see java.util.function.Supplier
+   */
+  @FunctionalInterface

Review comment:
       I was also not aware that this interface already existed. Because all others were in IOUtils, so this was inconsistent before.
   
   IMHO, I agree with @mocobeta - Move all of them to IOUtils. Separate classes bloat the Javadocs.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org