You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@commons.apache.org by sebb <se...@gmail.com> on 2012/08/07 15:13:50 UTC
Re: svn commit: r1370208 - in /commons/proper/jexl/branches/2.0:
RELEASE-NOTES.txt pom.xml src/site/xdoc/changes.xml
On 7 August 2012 13:36, <he...@apache.org> wrote:
> Author: henrib
> Date: Tue Aug 7 12:36:38 2012
> New Revision: 1370208
>
> URL: http://svn.apache.org/viewvc?rev=1370208&view=rev
> Log:
> Reflect last changes in release notes and changes.xml;
OK
> Added toolchain usage to force 1.5 in pom
The Commons Parent POM already provides different Java profiles for
compile/test.
Not sure using toolchain helps here; it may make things harder for
users and developers.
It must be possible to build with Java 1.6+, not just 1.5.
> Modified:
> commons/proper/jexl/branches/2.0/RELEASE-NOTES.txt
> commons/proper/jexl/branches/2.0/pom.xml
> commons/proper/jexl/branches/2.0/src/site/xdoc/changes.xml
>
> Modified: commons/proper/jexl/branches/2.0/RELEASE-NOTES.txt
> URL: http://svn.apache.org/viewvc/commons/proper/jexl/branches/2.0/RELEASE-NOTES.txt?rev=1370208&r1=1370207&r2=1370208&view=diff
> ==============================================================================
> --- commons/proper/jexl/branches/2.0/RELEASE-NOTES.txt (original)
> +++ commons/proper/jexl/branches/2.0/RELEASE-NOTES.txt Tue Aug 7 12:36:38 2012
> @@ -40,8 +40,11 @@ Its goal is to expose scripting features
> Release 2.1.2:
> ========================================================================================================================
>
> -Version 2.1.2 is a micro release to fix bugs reported since 2.1.1:
> +Version 2.1.2 is a micro release to fix issues reported in 2.1.1:
>
> +* JEXL-136: Script calls within scripts may fail with number arguments
> +* JEXL-135: Using map as script parameter or local variable
> +* JEXL-134: Issue with evaluation of concat of variables : \r + \n gives 0
> * JEXL-131: UnifiedJexl parsing may fail with NPE
> * JEXL-130: Ternary Conditional fails for Object values
> * JEXL-126: Decimal numbers literals should be 'double' by default (instead of 'float')
>
> Modified: commons/proper/jexl/branches/2.0/pom.xml
> URL: http://svn.apache.org/viewvc/commons/proper/jexl/branches/2.0/pom.xml?rev=1370208&r1=1370207&r2=1370208&view=diff
> ==============================================================================
> --- commons/proper/jexl/branches/2.0/pom.xml (original)
> +++ commons/proper/jexl/branches/2.0/pom.xml Tue Aug 7 12:36:38 2012
> @@ -120,6 +120,8 @@
> </dependencies>
>
> <properties>
> + <toolchains.jdk.version>1.5</toolchains.jdk.version>
> + <toolchains.jdk.vendor>sun</toolchains.jdk.vendor>
> <maven.compile.source>1.5</maven.compile.source>
> <maven.compile.target>1.5</maven.compile.target>
> <commons.componentid>jexl</commons.componentid>
>
> Modified: commons/proper/jexl/branches/2.0/src/site/xdoc/changes.xml
> URL: http://svn.apache.org/viewvc/commons/proper/jexl/branches/2.0/src/site/xdoc/changes.xml?rev=1370208&r1=1370207&r2=1370208&view=diff
> ==============================================================================
> --- commons/proper/jexl/branches/2.0/src/site/xdoc/changes.xml (original)
> +++ commons/proper/jexl/branches/2.0/src/site/xdoc/changes.xml Tue Aug 7 12:36:38 2012
> @@ -26,6 +26,12 @@
> </properties>
> <body>
> <release version="2.1.2" date="2012-07-30">
> + <action dev="henrib" type="fix" issue="JEXL-136">
> + Script calls within scripts may fail with number arguments
> + </action>
> + <action dev="henrib" type="fix" issue="JEXL-135" due-to="Tomas Kukosa">
> + using map as script parameter or local variable
> + </action>
> <action dev="henrib" type="fix" issue="JEXL-134" due-to="Manoj Mokashi">
> Issue with evaluation of concat of variables : \r + \n gives 0
> </action>
>
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1370208 - in /commons/proper/jexl/branches/2.0:
RELEASE-NOTES.txt pom.xml src/site/xdoc/changes.xml
Posted by henrib <he...@apache.org>.
I corrected the toolchain configuration (thanks for pointing it out the
error) and commented out its usage from the pom.
Jexl 2.1.2 is all yours now.
--
View this message in context: http://apache-commons.680414.n4.nabble.com/Re-svn-commit-r1370208-in-commons-proper-jexl-branches-2-0-RELEASE-NOTES-txt-pom-xml-src-site-xdoc-cl-tp4637751p4637757.html
Sent from the Commons - Dev mailing list archive at Nabble.com.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1370208 - in /commons/proper/jexl/branches/2.0:
RELEASE-NOTES.txt pom.xml src/site/xdoc/changes.xml
Posted by sebb <se...@gmail.com>.
On 7 August 2012 15:16, henrib <he...@apache.org> wrote:
> Just trying to ensure that I will not generate a public jexl2 release
> compiled against a jdk6.
Did not prevent me using Java 1.6 to compile.
Try updating a source file to add a call to "".isEmpty() - a Java 1.6+
method - and see what happens if you compile with the default Java set
to 1.6
That compiles fine for me on WinXP
Compiling with 1.6 will still generate 1.5-compatible code provided
that the source/target properties are set correctly.
Note that the Continuum build should pick up any usage of Java 1.6+
methods which is the only other issue here.
> Since most (if not all) JEXL users can't even use published snapshots, the
> likelihood of anyone attempting to compile jexl2 and not being able to
> comment the toolchain plugin in the pom seems very low...
It's a pain having to update the pom just to check with different JVMs.
That's partly why CP now includes the java-1.x profiles.
Also, the way that is implemented actually works!
> Anyhow, you can revert the modification and you are more than welcome to
> release jexl-2.1.2 if you want to. :-
I don't mind it being present if it adds utility without causing problems.
>
>
> --
> View this message in context: http://apache-commons.680414.n4.nabble.com/Re-svn-commit-r1370208-in-commons-proper-jexl-branches-2-0-RELEASE-NOTES-txt-pom-xml-src-site-xdoc-cl-tp4637751p4637754.html
> Sent from the Commons - Dev mailing list archive at Nabble.com.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org
Re: svn commit: r1370208 - in /commons/proper/jexl/branches/2.0:
RELEASE-NOTES.txt pom.xml src/site/xdoc/changes.xml
Posted by henrib <he...@apache.org>.
Just trying to ensure that I will not generate a public jexl2 release
compiled against a jdk6.
Since most (if not all) JEXL users can't even use published snapshots, the
likelihood of anyone attempting to compile jexl2 and not being able to
comment the toolchain plugin in the pom seems very low...
Anyhow, you can revert the modification and you are more than welcome to
release jexl-2.1.2 if you want to. :-)
--
View this message in context: http://apache-commons.680414.n4.nabble.com/Re-svn-commit-r1370208-in-commons-proper-jexl-branches-2-0-RELEASE-NOTES-txt-pom-xml-src-site-xdoc-cl-tp4637751p4637754.html
Sent from the Commons - Dev mailing list archive at Nabble.com.