You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Alexander Rukletsov <ru...@gmail.com> on 2017/01/12 13:19:33 UTC
Review Request 55454: Ensured zero health check timeout means infinite
timeout.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55454/
-----------------------------------------------------------
Review request for mesos, Gast�n Kleiman, haosdent huang, and Vinod Kone.
Bugs: MESOS-6908
https://issues.apache.org/jira/browse/MESOS-6908
Repository: mesos
Description
-------
Prior to this patch, zero health check timeout was interpreted
literally, which is not very helpful since a health check did not
even get a chance to finish. This patch fixes this behaviour by
interpreting zero as `Duration::max()` effectively rendering the
timeout infinite.
Diffs
-----
include/mesos/mesos.proto ab68ff85c4af5d254779b30a7f27eda9fcb790eb
include/mesos/v1/mesos.proto caefa239be6ead10b9a5fc91ba120ea9c8775313
src/health-check/health_checker.cpp a8424b75927d15dc1b897faf0e47cf075c70ff26
Diff: https://reviews.apache.org/r/55454/diff/
Testing
-------
make check
Thanks,
Alexander Rukletsov
Re: Review Request 55454: Ensured zero health check timeout means
infinite timeout.
Posted by Gastón Kleiman <ga...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55454/#review161509
-----------------------------------------------------------
Ship it!
Ship It!
- Gast�n Kleiman
On Jan. 12, 2017, 1:19 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55454/
> -----------------------------------------------------------
>
> (Updated Jan. 12, 2017, 1:19 p.m.)
>
>
> Review request for mesos, Gast�n Kleiman, haosdent huang, and Vinod Kone.
>
>
> Bugs: MESOS-6908
> https://issues.apache.org/jira/browse/MESOS-6908
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Prior to this patch, zero health check timeout was interpreted
> literally, which is not very helpful since a health check did not
> even get a chance to finish. This patch fixes this behaviour by
> interpreting zero as `Duration::max()` effectively rendering the
> timeout infinite.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto ab68ff85c4af5d254779b30a7f27eda9fcb790eb
> include/mesos/v1/mesos.proto caefa239be6ead10b9a5fc91ba120ea9c8775313
> src/health-check/health_checker.cpp a8424b75927d15dc1b897faf0e47cf075c70ff26
>
> Diff: https://reviews.apache.org/r/55454/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 55454: Ensured zero health check timeout means
infinite timeout.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55454/#review162056
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Jan. 18, 2017, 9:31 a.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55454/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2017, 9:31 a.m.)
>
>
> Review request for mesos, Gast�n Kleiman, haosdent huang, and Vinod Kone.
>
>
> Bugs: MESOS-6908
> https://issues.apache.org/jira/browse/MESOS-6908
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Prior to this patch, zero health check timeout was interpreted
> literally, which is not very helpful since a health check did not
> even get a chance to finish. This patch fixes this behaviour by
> interpreting zero as `Duration::max()` effectively rendering the
> timeout infinite.
>
>
> Diffs
> -----
>
> include/mesos/mesos.proto 8f14444d6957a97eff1e0a94817d38e7a7de6d69
> include/mesos/v1/mesos.proto 74e7851b147ab821dceeab6e838d34b092f101c3
> src/health-check/health_checker.cpp a8424b75927d15dc1b897faf0e47cf075c70ff26
>
> Diff: https://reviews.apache.org/r/55454/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 55454: Ensured zero health check timeout means
infinite timeout.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55454/
-----------------------------------------------------------
(Updated Jan. 20, 2017, 2:49 p.m.)
Review request for mesos, Gast�n Kleiman, haosdent huang, and Vinod Kone.
Changes
-------
Rebased.
Bugs: MESOS-6908
https://issues.apache.org/jira/browse/MESOS-6908
Repository: mesos
Description
-------
Prior to this patch, zero health check timeout was interpreted
literally, which is not very helpful since a health check did not
even get a chance to finish. This patch fixes this behaviour by
interpreting zero as `Duration::max()` effectively rendering the
timeout infinite.
Diffs (updated)
-----
include/mesos/mesos.proto 8f14444d6957a97eff1e0a94817d38e7a7de6d69
include/mesos/v1/mesos.proto 74e7851b147ab821dceeab6e838d34b092f101c3
src/health-check/health_checker.cpp a8424b75927d15dc1b897faf0e47cf075c70ff26
Diff: https://reviews.apache.org/r/55454/diff/
Testing
-------
make check
Thanks,
Alexander Rukletsov
Re: Review Request 55454: Ensured zero health check timeout means
infinite timeout.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55454/
-----------------------------------------------------------
(Updated Jan. 19, 2017, 5:39 p.m.)
Review request for mesos, Gast�n Kleiman, haosdent huang, and Vinod Kone.
Changes
-------
Rebased.
Bugs: MESOS-6908
https://issues.apache.org/jira/browse/MESOS-6908
Repository: mesos
Description
-------
Prior to this patch, zero health check timeout was interpreted
literally, which is not very helpful since a health check did not
even get a chance to finish. This patch fixes this behaviour by
interpreting zero as `Duration::max()` effectively rendering the
timeout infinite.
Diffs (updated)
-----
include/mesos/mesos.proto 8f14444d6957a97eff1e0a94817d38e7a7de6d69
include/mesos/v1/mesos.proto 74e7851b147ab821dceeab6e838d34b092f101c3
src/health-check/health_checker.cpp a8424b75927d15dc1b897faf0e47cf075c70ff26
Diff: https://reviews.apache.org/r/55454/diff/
Testing
-------
make check
Thanks,
Alexander Rukletsov
Re: Review Request 55454: Ensured zero health check timeout means
infinite timeout.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55454/
-----------------------------------------------------------
(Updated Jan. 18, 2017, 9:31 a.m.)
Review request for mesos, Gast�n Kleiman, haosdent huang, and Vinod Kone.
Changes
-------
Rebased.
Bugs: MESOS-6908
https://issues.apache.org/jira/browse/MESOS-6908
Repository: mesos
Description
-------
Prior to this patch, zero health check timeout was interpreted
literally, which is not very helpful since a health check did not
even get a chance to finish. This patch fixes this behaviour by
interpreting zero as `Duration::max()` effectively rendering the
timeout infinite.
Diffs (updated)
-----
include/mesos/mesos.proto 8f14444d6957a97eff1e0a94817d38e7a7de6d69
include/mesos/v1/mesos.proto 74e7851b147ab821dceeab6e838d34b092f101c3
src/health-check/health_checker.cpp a8424b75927d15dc1b897faf0e47cf075c70ff26
Diff: https://reviews.apache.org/r/55454/diff/
Testing
-------
make check
Thanks,
Alexander Rukletsov