You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@cloudstack.apache.org by GitBox <gi...@apache.org> on 2022/11/02 08:40:15 UTC

[GitHub] [cloudstack] DaanHoogland commented on a diff in pull request #6858: allow a new upgrade version without DB changes to be inserted

DaanHoogland commented on code in PR #6858:
URL: https://github.com/apache/cloudstack/pull/6858#discussion_r1011371738


##########
engine/schema/src/main/java/com/cloud/upgrade/DatabaseVersionHierarchy.java:
##########
@@ -131,7 +131,7 @@ private CloudStackVersion getRecentVersion(final CloudStackVersion fromVersion)
         return toList()
                  .reverse()
                  .stream()
-                 .filter(version -> fromVersion.compareTo(version) < 0)

Review Comment:
   unfortunately a lot of four digit versions are already in the DBs around the world. In addition to that, we might want to add a DB patch in a security release at some pioint in which case we want to take the fourth digit into account.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@cloudstack.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org