[GitHub] [geode] echobravopapa commented on a change in pull request #5758: GEODE-8721: member that should become coordinator never detects loss of current coordinator

[GitBox <gi...@apache.org>]

echobravopapa commented on a change in pull request #5758:
URL: https://github.com/apache/geode/pull/5758#discussion_r526379316



##########
File path: geode-membership/src/main/java/org/apache/geode/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
##########
@@ -257,6 +257,7 @@ public void run() {
           return;
         }
 
+        // TODO - why are we taking two clock readings and setting currentTimeStamp twice?

Review comment:
       seems to be done to detect JVM pauses and delay suspect processing in those cases...

##########
File path: geode-membership/src/main/java/org/apache/geode/distributed/internal/membership/gms/fd/GMSHealthMonitor.java
##########
@@ -1242,7 +1243,11 @@ void processMessage(FinalCheckPassedMessage<ID> m) {
     if (isStopping) {
       return;
     }
-    contactedBy(m.getSuspect());
+    // if we're currently processing a final-check for this member don't artificially update the

Review comment:
       solid fix!




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org