You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by sravan-s <gi...@git.apache.org> on 2017/03/14 08:29:17 UTC

[GitHub] zeppelin pull request #2132: [ZEPPELIN-2253] Piechart won't render when colu...

GitHub user sravan-s opened a pull request:

    https://github.com/apache/zeppelin/pull/2132

    [ZEPPELIN-2253] Piechart won't render when column selected as 'key' is changed

    ### What is this PR for?
    * Fixes issue with pie chart rendering, if user changes pie chart's domain
    * When pie chart's key(domain) is changed, this error is logged:
      'Uncaught TypeError: arcs[idx] is not a function at pie.js:358'
    * Even if user changes the key and values again, chart remains broken
    * Fix: set this.chart to null, which makes render function to initialize new
    pie chart constructor 
    ### What type of PR is it?
    [Bug Fix]
    
    ### What is the Jira issue?
    * [ZEPPELIN-533](https://issues.apache.org/jira/browse/ZEPPELIN-2253)
    
    ### How should this be tested?
    * Create a new pie chart using built in visualization
    * Remove column selected as 'key'
    * Add a new column as 'key'
    * Chart is rendered perfectly
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sravan-s/zeppelin ZEPPELIN-2253

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/2132.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #2132
    
----
commit 310aecfe5f02f2fa2911b1f1a37337719e12c574
Author: ess_ess <sr...@gmail.com>
Date:   2017-03-14T07:57:16Z

    Initialize chart to null inside 'render()'
    
    * Fixes ZEPPELIN-2253
    * When pie chart's key(domain) is changed, this error is logged:
     'Uncaught TypeError: arcs[idx] is not a function at pie.js:358'
    * Even if we change key and values, chart remains broken
    
    * Fix: set this.chart to null, which inturn makes this.render to
    intialize a new chart constructor

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2132: [ZEPPELIN-2253] Piechart won't render when column sele...

Posted by sravan-s <gi...@git.apache.org>.

Github user sravan-s commented on the issue:

    https://github.com/apache/zeppelin/pull/2132
  
    A video showing the bug is uploaded at JIRA, cannot seem to upload the video here, the webm format isn't supported
    If someone else could propose a better solution, it's appreciated :smiley: 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #2132: [ZEPPELIN-2253] Piechart won't render when column sele...

Posted by Leemoonsoo <gi...@git.apache.org>.

Github user Leemoonsoo commented on the issue:

    https://github.com/apache/zeppelin/pull/2132
  
    Tested and LGTM.
    
    Merge to master and branch-0.7 if no further comments.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #2132: [ZEPPELIN-2253] Piechart won't render when colu...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/2132


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---