You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "Jackie-Jiang (via GitHub)" <gi...@apache.org> on 2026/09/25 22:21:00 UTC
[PR] Remove JUnit and run all tests through the TestNG Surefire provider [pinot]
Jackie-Jiang opened a new pull request, #19675:
URL: https://github.com/apache/pinot/pull/19675
## Summary
Every test in the repo runs through Surefire's native TestNG provider again, and nothing from JUnit remains on any classpath.
- **TestNG suites instead of the JUnit Platform bridge.** #19633 replaced the TestNG XML suites with `@Suite` classes run through `testng-engine`, which needed `junit-platform-suite`, `junit-platform-launcher` and the `OrderedTestNGSuite` listener to restore class order. This restores the explicit `surefire-testng` provider and the XML suites: the five integration suites as they were, a new `logical-table-integration-test-suite.xml` for the package #19652 added, and the two controller suites (with the `statefull` typo fixed). The lane profiles and the controller profile select them with `suiteXmlFiles`; CI profile ids are unchanged.
- **`junit-jupiter-api` removed entirely.** Its only remaining runtime user was Kafka's `KafkaClusterTestKit.waitForReadyBrokers()`, whose polling helper (`TestUtils.waitForCondition`) calls JUnit's `assertTrue`. `EmbeddedKafkaCluster` now does the same two steps with public Kafka API (wait on each controller's `waitForReadyBrokers` future, then poll until every broker's metadata cache reports all brokers alive) and reports timeout through TestNG's `fail`. The dependency, its managed version and the version property go from the root POM and the four modules that declared it.
- **Checkstyle rejects any `org.junit` import**, so JUnit cannot come back through a new test or a copied snippet.
- The testing docs now say TestNG only.
## Notes
- Surefire's provider auto-detection selects the JUnit Platform whenever `junit-platform-commons` is on the test classpath (which `junit-jupiter-api` alone brings) and then silently adds `testng-engine` when TestNG is present. Declaring the `surefire-testng` provider explicitly makes provider selection independent of classpath contents.
- The logical-table suite lists its eight `BaseLogicalTableIntegrationTest` subclasses explicitly. TestNG's `<package>` include/exclude patterns match sub-package names rather than classes, so `KafkaPartitionSubsetChaosIntegrationTest` (which starts its own cluster) could not be excluded from a package selection; the lane profile still runs it directly.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Disallow JUnit test APIs in tests and drop the unused JUnit artifacts [pinot]
Posted by "Jackie-Jiang (via GitHub)" <gi...@apache.org>.
Jackie-Jiang merged PR #19675:
URL: https://github.com/apache/pinot/pull/19675
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Disallow JUnit test APIs in tests and drop the unused JUnit artifacts [pinot]
Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 commented on PR #19675:
URL: https://github.com/apache/pinot/pull/19675#issuecomment-5844455959
Documentation follow-up: https://github.com/pinot-contrib/pinot-docs/pull/1068 (merged).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
Re: [PR] Disallow JUnit test APIs in tests and drop the unused JUnit artifacts [pinot]
Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #19675:
URL: https://github.com/apache/pinot/pull/19675#issuecomment-5842125362
## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/19675?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 100.00%. Comparing base ([`b4f9fe1`](https://app.codecov.io/gh/apache/pinot/commit/b4f9fe180bf559f7a3f269a009628c7de8e71f53?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`591e2ff`](https://app.codecov.io/gh/apache/pinot/commit/591e2ffa19e13b5a0390f610a602293499664433?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## master #19675 +/- ##
==============================================
+ Coverage 58.28% 100.00% +41.71%
+ Complexity 7 6 -1
==============================================
Files 2703 3 -2700
Lines 166178 6 -166172
Branches 27067 0 -27067
==============================================
- Hits 96861 6 -96855
+ Misses 61188 0 -61188
+ Partials 8129 0 -8129
```
| [Flag](https://app.codecov.io/gh/apache/pinot/pull/19675/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
|---|---|---|
| [integration](https://app.codecov.io/gh/apache/pinot/pull/19675/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (ø)` | |
| [integration1](https://app.codecov.io/gh/apache/pinot/pull/19675/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (ø)` | |
| [java-25](https://app.codecov.io/gh/apache/pinot/pull/19675/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (+41.71%)` | :arrow_up: |
| [lane-a](https://app.codecov.io/gh/apache/pinot/pull/19675/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (ø)` | |
| [lane-b](https://app.codecov.io/gh/apache/pinot/pull/19675/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `0.00% <ø> (ø)` | |
| [temurin](https://app.codecov.io/gh/apache/pinot/pull/19675/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `100.00% <ø> (+41.71%)` | :arrow_up: |
| [unittests](https://app.codecov.io/gh/apache/pinot/pull/19675/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
| [unittests1](https://app.codecov.io/gh/apache/pinot/pull/19675/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
</details>
[:umbrella: View full report in Codecov by Harness](https://app.codecov.io/gh/apache/pinot/pull/19675?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
:loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
<details><summary> :rocket: New features to boost your workflow: </summary>
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org